From f2fa9337a174fbf6cd21b0452779324cd077b6dc Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Thu, 17 Dec 2020 14:10:01 +0100 Subject: [PATCH 01/11] all analysis options point to the root one --- analysis_options.yaml | 9 ++++++++- .../android_alarm_manager_plus/analysis_options.yaml | 11 +---------- packages/android_alarm_manager_plus/pubspec.yaml | 2 +- packages/android_intent_plus/analysis_options.yaml | 11 +---------- packages/android_intent_plus/pubspec.yaml | 2 +- packages/battery_plus/analysis_options.yaml | 1 + packages/battery_plus/pubspec.yaml | 2 +- packages/battery_plus_linux/analysis_options.yaml | 2 +- .../analysis_options.yaml | 1 + packages/battery_plus_platform_interface/pubspec.yaml | 2 +- packages/battery_plus_web/analysis_options.yaml | 1 + packages/battery_plus_web/pubspec.yaml | 1 + packages/connectivity_plus/analysis_options.yaml | 1 + packages/connectivity_plus/pubspec.yaml | 2 +- .../connectivity_plus_linux/analysis_options.yaml | 2 +- packages/connectivity_plus_macos/pubspec.yaml | 3 --- .../analysis_options.yaml | 1 + .../connectivity_plus_platform_interface/pubspec.yaml | 2 +- packages/connectivity_plus_web/analysis_options.yaml | 1 + packages/connectivity_plus_web/pubspec.yaml | 1 + packages/device_info_plus/analysis_options.yaml | 1 + packages/device_info_plus/pubspec.yaml | 2 +- packages/device_info_plus_linux/analysis_options.yaml | 2 +- packages/device_info_plus_linux/pubspec.yaml | 2 +- .../analysis_options.yaml | 1 + .../device_info_plus_platform_interface/pubspec.yaml | 2 +- packages/device_info_plus_web/analysis_options.yaml | 1 + packages/device_info_plus_web/pubspec.yaml | 1 + packages/package_info_plus/analysis_options.yaml | 1 + packages/package_info_plus/pubspec.yaml | 2 +- .../package_info_plus_linux/analysis_options.yaml | 1 + packages/package_info_plus_linux/pubspec.yaml | 1 + packages/package_info_plus_macos/pubspec.yaml | 3 --- .../analysis_options.yaml | 1 + .../package_info_plus_platform_interface/pubspec.yaml | 2 +- packages/package_info_plus_web/analysis_options.yaml | 1 + packages/package_info_plus_web/pubspec.yaml | 2 +- .../package_info_plus_windows/analysis_options.yaml | 1 + packages/package_info_plus_windows/pubspec.yaml | 1 + packages/sensors_plus/analysis_options.yaml | 1 + packages/sensors_plus/pubspec.yaml | 2 +- .../analysis_options.yaml | 1 + packages/sensors_plus_platform_interface/pubspec.yaml | 2 +- packages/sensors_plus_web/analysis_options.yaml | 1 + packages/sensors_plus_web/pubspec.yaml | 1 + packages/share_plus/analysis_options.yaml | 1 + packages/share_plus/pubspec.yaml | 2 +- packages/share_plus_linux/analysis_options.yaml | 2 +- packages/share_plus_linux/pubspec.yaml | 2 +- .../analysis_options.yaml | 1 + packages/share_plus_platform_interface/pubspec.yaml | 2 +- packages/share_plus_web/analysis_options.yaml | 1 + packages/share_plus_web/pubspec.yaml | 2 +- packages/share_plus_windows/analysis_options.yaml | 2 +- packages/share_plus_windows/pubspec.yaml | 2 +- 55 files changed, 60 insertions(+), 51 deletions(-) create mode 100644 packages/battery_plus/analysis_options.yaml create mode 100644 packages/battery_plus_platform_interface/analysis_options.yaml create mode 100644 packages/battery_plus_web/analysis_options.yaml create mode 100644 packages/connectivity_plus/analysis_options.yaml create mode 100644 packages/connectivity_plus_platform_interface/analysis_options.yaml create mode 100644 packages/connectivity_plus_web/analysis_options.yaml create mode 100644 packages/device_info_plus/analysis_options.yaml create mode 100644 packages/device_info_plus_platform_interface/analysis_options.yaml create mode 100644 packages/device_info_plus_web/analysis_options.yaml create mode 100644 packages/package_info_plus/analysis_options.yaml create mode 100644 packages/package_info_plus_linux/analysis_options.yaml create mode 100644 packages/package_info_plus_platform_interface/analysis_options.yaml create mode 100644 packages/package_info_plus_web/analysis_options.yaml create mode 100644 packages/package_info_plus_windows/analysis_options.yaml create mode 100644 packages/sensors_plus/analysis_options.yaml create mode 100644 packages/sensors_plus_platform_interface/analysis_options.yaml create mode 100644 packages/sensors_plus_web/analysis_options.yaml create mode 100644 packages/share_plus/analysis_options.yaml create mode 100644 packages/share_plus_platform_interface/analysis_options.yaml create mode 100644 packages/share_plus_web/analysis_options.yaml diff --git a/analysis_options.yaml b/analysis_options.yaml index cb7a0a41d2..225e9a759d 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,4 +1,11 @@ include: package:pedantic/analysis_options.1.8.0.yaml + +analyzer: + exclude: + # Ignore generated files + - '**/*.g.dart' + - 'lib/src/generated/*.dart' + linter: rules: - - public_member_api_docs \ No newline at end of file + - public_member_api_docs diff --git a/packages/android_alarm_manager_plus/analysis_options.yaml b/packages/android_alarm_manager_plus/analysis_options.yaml index 9b5dd6e0d8..f04c6cf0f3 100644 --- a/packages/android_alarm_manager_plus/analysis_options.yaml +++ b/packages/android_alarm_manager_plus/analysis_options.yaml @@ -1,10 +1 @@ -include: package:pedantic/analysis_options.yaml - -analyzer: - exclude: - # Ignore generated files - - '**/*.g.dart' - - 'lib/src/generated/*.dart' -linter: - rules: - - public_member_api_docs \ No newline at end of file +include: ../../analysis_options.yaml diff --git a/packages/android_alarm_manager_plus/pubspec.yaml b/packages/android_alarm_manager_plus/pubspec.yaml index 6fa299178e..2df10addcf 100644 --- a/packages/android_alarm_manager_plus/pubspec.yaml +++ b/packages/android_alarm_manager_plus/pubspec.yaml @@ -12,7 +12,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.9.0 + pedantic: ^1.9.2 flutter: plugin: diff --git a/packages/android_intent_plus/analysis_options.yaml b/packages/android_intent_plus/analysis_options.yaml index 9b5dd6e0d8..f04c6cf0f3 100644 --- a/packages/android_intent_plus/analysis_options.yaml +++ b/packages/android_intent_plus/analysis_options.yaml @@ -1,10 +1 @@ -include: package:pedantic/analysis_options.yaml - -analyzer: - exclude: - # Ignore generated files - - '**/*.g.dart' - - 'lib/src/generated/*.dart' -linter: - rules: - - public_member_api_docs \ No newline at end of file +include: ../../analysis_options.yaml diff --git a/packages/android_intent_plus/pubspec.yaml b/packages/android_intent_plus/pubspec.yaml index e17b9622be..78973fb850 100644 --- a/packages/android_intent_plus/pubspec.yaml +++ b/packages/android_intent_plus/pubspec.yaml @@ -21,7 +21,7 @@ dev_dependencies: mockito: ^3.0.0 flutter_test: sdk: flutter - pedantic: ^1.9.0 + pedantic: ^1.9.2 environment: sdk: ">=2.3.0 <3.0.0" diff --git a/packages/battery_plus/analysis_options.yaml b/packages/battery_plus/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/battery_plus/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/battery_plus/pubspec.yaml b/packages/battery_plus/pubspec.yaml index af2531eb2a..49ae2bbe86 100644 --- a/packages/battery_plus/pubspec.yaml +++ b/packages/battery_plus/pubspec.yaml @@ -39,7 +39,7 @@ dev_dependencies: sdk: flutter integration_test: ^0.9.1 plugin_platform_interface: ^1.0.0 - pedantic: ^1.9.0 + pedantic: ^1.9.2 environment: sdk: '>=2.1.0 <3.0.0' diff --git a/packages/battery_plus_linux/analysis_options.yaml b/packages/battery_plus_linux/analysis_options.yaml index 486705dbf2..f04c6cf0f3 100644 --- a/packages/battery_plus_linux/analysis_options.yaml +++ b/packages/battery_plus_linux/analysis_options.yaml @@ -1 +1 @@ -include: package:pedantic/analysis_options.1.9.0.yaml +include: ../../analysis_options.yaml diff --git a/packages/battery_plus_platform_interface/analysis_options.yaml b/packages/battery_plus_platform_interface/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/battery_plus_platform_interface/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/battery_plus_platform_interface/pubspec.yaml b/packages/battery_plus_platform_interface/pubspec.yaml index cf4f229505..7733330d29 100644 --- a/packages/battery_plus_platform_interface/pubspec.yaml +++ b/packages/battery_plus_platform_interface/pubspec.yaml @@ -17,4 +17,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.9.0 + pedantic: ^1.9.2 diff --git a/packages/battery_plus_web/analysis_options.yaml b/packages/battery_plus_web/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/battery_plus_web/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/battery_plus_web/pubspec.yaml b/packages/battery_plus_web/pubspec.yaml index e7fb5b815e..01ea4c2804 100644 --- a/packages/battery_plus_web/pubspec.yaml +++ b/packages/battery_plus_web/pubspec.yaml @@ -26,6 +26,7 @@ dev_dependencies: sdk: flutter integration_test: ^0.9.1 mockito: ^4.1.2 + pedantic: ^1.9.2 environment: sdk: '>=2.6.0 <3.0.0' diff --git a/packages/connectivity_plus/analysis_options.yaml b/packages/connectivity_plus/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/connectivity_plus/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus/pubspec.yaml b/packages/connectivity_plus/pubspec.yaml index 8b4ec3f0ab..c4a2caf31e 100644 --- a/packages/connectivity_plus/pubspec.yaml +++ b/packages/connectivity_plus/pubspec.yaml @@ -37,7 +37,7 @@ dev_dependencies: integration_test: ^0.9.1 mockito: ^4.1.1 plugin_platform_interface: ^1.0.0 - pedantic: ^1.8.0 + pedantic: ^1.9.2 environment: sdk: ">=2.1.0 <3.0.0" diff --git a/packages/connectivity_plus_linux/analysis_options.yaml b/packages/connectivity_plus_linux/analysis_options.yaml index 486705dbf2..f04c6cf0f3 100644 --- a/packages/connectivity_plus_linux/analysis_options.yaml +++ b/packages/connectivity_plus_linux/analysis_options.yaml @@ -1 +1 @@ -include: package:pedantic/analysis_options.1.9.0.yaml +include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus_macos/pubspec.yaml b/packages/connectivity_plus_macos/pubspec.yaml index 26fc43194f..90099bbb74 100644 --- a/packages/connectivity_plus_macos/pubspec.yaml +++ b/packages/connectivity_plus_macos/pubspec.yaml @@ -18,6 +18,3 @@ dependencies: connectivity_plus_platform_interface: ^0.3.0 flutter: sdk: flutter - -dev_dependencies: - pedantic: ^1.8.0 diff --git a/packages/connectivity_plus_platform_interface/analysis_options.yaml b/packages/connectivity_plus_platform_interface/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/connectivity_plus_platform_interface/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus_platform_interface/pubspec.yaml b/packages/connectivity_plus_platform_interface/pubspec.yaml index c3684e656e..ac2ebd3c2c 100644 --- a/packages/connectivity_plus_platform_interface/pubspec.yaml +++ b/packages/connectivity_plus_platform_interface/pubspec.yaml @@ -13,7 +13,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.8.0 + pedantic: ^1.9.2 environment: sdk: ">=2.1.0 <3.0.0" diff --git a/packages/connectivity_plus_web/analysis_options.yaml b/packages/connectivity_plus_web/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/connectivity_plus_web/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus_web/pubspec.yaml b/packages/connectivity_plus_web/pubspec.yaml index a92df8874f..f8cf2ea5de 100644 --- a/packages/connectivity_plus_web/pubspec.yaml +++ b/packages/connectivity_plus_web/pubspec.yaml @@ -26,6 +26,7 @@ dev_dependencies: sdk: flutter integration_test: ^0.9.1 mockito: ^4.1.1 + pedantic: ^1.9.2 environment: sdk: ">=2.6.0 <3.0.0" diff --git a/packages/device_info_plus/analysis_options.yaml b/packages/device_info_plus/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/device_info_plus/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/device_info_plus/pubspec.yaml b/packages/device_info_plus/pubspec.yaml index e87276615c..35a815fa91 100644 --- a/packages/device_info_plus/pubspec.yaml +++ b/packages/device_info_plus/pubspec.yaml @@ -29,7 +29,7 @@ dev_dependencies: test: ^1.3.0 flutter_test: sdk: flutter - pedantic: ^1.8.0 + pedantic: ^1.9.2 environment: sdk: ">=2.1.0<3.0.0" diff --git a/packages/device_info_plus_linux/analysis_options.yaml b/packages/device_info_plus_linux/analysis_options.yaml index 108d1058ac..f04c6cf0f3 100644 --- a/packages/device_info_plus_linux/analysis_options.yaml +++ b/packages/device_info_plus_linux/analysis_options.yaml @@ -1 +1 @@ -include: package:pedantic/analysis_options.yaml +include: ../../analysis_options.yaml diff --git a/packages/device_info_plus_linux/pubspec.yaml b/packages/device_info_plus_linux/pubspec.yaml index 4186bf0255..40eb251ca7 100644 --- a/packages/device_info_plus_linux/pubspec.yaml +++ b/packages/device_info_plus_linux/pubspec.yaml @@ -18,4 +18,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.9.0 + pedantic: ^1.9.2 diff --git a/packages/device_info_plus_platform_interface/analysis_options.yaml b/packages/device_info_plus_platform_interface/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/device_info_plus_platform_interface/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/device_info_plus_platform_interface/pubspec.yaml b/packages/device_info_plus_platform_interface/pubspec.yaml index f85738ed6f..45ecd8ea5a 100644 --- a/packages/device_info_plus_platform_interface/pubspec.yaml +++ b/packages/device_info_plus_platform_interface/pubspec.yaml @@ -14,7 +14,7 @@ dev_dependencies: flutter_test: sdk: flutter mockito: ^4.1.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 environment: sdk: ">=2.7.0 <3.0.0" diff --git a/packages/device_info_plus_web/analysis_options.yaml b/packages/device_info_plus_web/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/device_info_plus_web/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/device_info_plus_web/pubspec.yaml b/packages/device_info_plus_web/pubspec.yaml index dfb34b542e..dd78c8ba6f 100644 --- a/packages/device_info_plus_web/pubspec.yaml +++ b/packages/device_info_plus_web/pubspec.yaml @@ -26,6 +26,7 @@ dev_dependencies: sdk: flutter integration_test: ^0.9.1 mockito: ^4.1.2 + pedantic: ^1.9.2 environment: sdk: '>=2.6.0 <3.0.0' diff --git a/packages/package_info_plus/analysis_options.yaml b/packages/package_info_plus/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/package_info_plus/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/package_info_plus/pubspec.yaml b/packages/package_info_plus/pubspec.yaml index d845cdf465..966ea199ca 100644 --- a/packages/package_info_plus/pubspec.yaml +++ b/packages/package_info_plus/pubspec.yaml @@ -37,7 +37,7 @@ dev_dependencies: sdk: flutter test: any integration_test: ^0.9.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 environment: sdk: ">=2.1.0 <3.0.0" diff --git a/packages/package_info_plus_linux/analysis_options.yaml b/packages/package_info_plus_linux/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/package_info_plus_linux/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_linux/pubspec.yaml b/packages/package_info_plus_linux/pubspec.yaml index 4480c2bbae..62bd7f8963 100644 --- a/packages/package_info_plus_linux/pubspec.yaml +++ b/packages/package_info_plus_linux/pubspec.yaml @@ -17,3 +17,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter + pedantic: ^1.9.2 diff --git a/packages/package_info_plus_macos/pubspec.yaml b/packages/package_info_plus_macos/pubspec.yaml index 43279f1d5c..cbfa161722 100644 --- a/packages/package_info_plus_macos/pubspec.yaml +++ b/packages/package_info_plus_macos/pubspec.yaml @@ -18,6 +18,3 @@ environment: dependencies: flutter: sdk: flutter - -dev_dependencies: - pedantic: ^1.8.0 diff --git a/packages/package_info_plus_platform_interface/analysis_options.yaml b/packages/package_info_plus_platform_interface/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/package_info_plus_platform_interface/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_platform_interface/pubspec.yaml b/packages/package_info_plus_platform_interface/pubspec.yaml index 5421892ea9..9e9241d3c2 100644 --- a/packages/package_info_plus_platform_interface/pubspec.yaml +++ b/packages/package_info_plus_platform_interface/pubspec.yaml @@ -14,7 +14,7 @@ dev_dependencies: flutter_test: sdk: flutter mockito: ^4.1.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 environment: sdk: ">=2.1.0 <3.0.0" diff --git a/packages/package_info_plus_web/analysis_options.yaml b/packages/package_info_plus_web/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/package_info_plus_web/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_web/pubspec.yaml b/packages/package_info_plus_web/pubspec.yaml index 3aadae7445..f0ab23376e 100644 --- a/packages/package_info_plus_web/pubspec.yaml +++ b/packages/package_info_plus_web/pubspec.yaml @@ -24,8 +24,8 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.8.0 mockito: ^4.1.1 + pedantic: ^1.9.2 environment: sdk: ">=2.2.0 <3.0.0" diff --git a/packages/package_info_plus_windows/analysis_options.yaml b/packages/package_info_plus_windows/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/package_info_plus_windows/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_windows/pubspec.yaml b/packages/package_info_plus_windows/pubspec.yaml index 366d66a9dd..10c445db59 100644 --- a/packages/package_info_plus_windows/pubspec.yaml +++ b/packages/package_info_plus_windows/pubspec.yaml @@ -18,3 +18,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter + pedantic: ^1.9.2 diff --git a/packages/sensors_plus/analysis_options.yaml b/packages/sensors_plus/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/sensors_plus/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/sensors_plus/pubspec.yaml b/packages/sensors_plus/pubspec.yaml index bc665cb4cb..44c03c57e1 100644 --- a/packages/sensors_plus/pubspec.yaml +++ b/packages/sensors_plus/pubspec.yaml @@ -27,7 +27,7 @@ dev_dependencies: sdk: flutter integration_test: ^0.9.1 mockito: ^4.1.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 environment: sdk: '>=2.1.0<3.0.0' diff --git a/packages/sensors_plus_platform_interface/analysis_options.yaml b/packages/sensors_plus_platform_interface/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/sensors_plus_platform_interface/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/sensors_plus_platform_interface/pubspec.yaml b/packages/sensors_plus_platform_interface/pubspec.yaml index e1530b136a..bd0666daf2 100644 --- a/packages/sensors_plus_platform_interface/pubspec.yaml +++ b/packages/sensors_plus_platform_interface/pubspec.yaml @@ -14,7 +14,7 @@ dev_dependencies: flutter_test: sdk: flutter mockito: ^4.1.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 test: any environment: diff --git a/packages/sensors_plus_web/analysis_options.yaml b/packages/sensors_plus_web/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/sensors_plus_web/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/sensors_plus_web/pubspec.yaml b/packages/sensors_plus_web/pubspec.yaml index aa9f88bf00..5aaaf82db8 100644 --- a/packages/sensors_plus_web/pubspec.yaml +++ b/packages/sensors_plus_web/pubspec.yaml @@ -30,3 +30,4 @@ dev_dependencies: sdk: flutter integration_test: ^0.9.1 mockito: ^4.1.2 + pedantic: ^1.9.2 diff --git a/packages/share_plus/analysis_options.yaml b/packages/share_plus/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/share_plus/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/share_plus/pubspec.yaml b/packages/share_plus/pubspec.yaml index 9c58878e12..d483c668db 100644 --- a/packages/share_plus/pubspec.yaml +++ b/packages/share_plus/pubspec.yaml @@ -35,8 +35,8 @@ dev_dependencies: flutter_test: sdk: flutter integration_test: ^0.9.1 - pedantic: ^1.8.0 url_launcher: ^5.7.2 + pedantic: ^1.9.2 environment: sdk: ">=2.1.0 <3.0.0" diff --git a/packages/share_plus_linux/analysis_options.yaml b/packages/share_plus_linux/analysis_options.yaml index 108d1058ac..f04c6cf0f3 100644 --- a/packages/share_plus_linux/analysis_options.yaml +++ b/packages/share_plus_linux/analysis_options.yaml @@ -1 +1 @@ -include: package:pedantic/analysis_options.yaml +include: ../../analysis_options.yaml diff --git a/packages/share_plus_linux/pubspec.yaml b/packages/share_plus_linux/pubspec.yaml index b501f65f3b..4ef1495804 100644 --- a/packages/share_plus_linux/pubspec.yaml +++ b/packages/share_plus_linux/pubspec.yaml @@ -19,4 +19,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.9.0 + pedantic: ^1.9.2 diff --git a/packages/share_plus_platform_interface/analysis_options.yaml b/packages/share_plus_platform_interface/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/share_plus_platform_interface/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/share_plus_platform_interface/pubspec.yaml b/packages/share_plus_platform_interface/pubspec.yaml index a400b3b111..fdb92e5d68 100644 --- a/packages/share_plus_platform_interface/pubspec.yaml +++ b/packages/share_plus_platform_interface/pubspec.yaml @@ -16,7 +16,7 @@ dev_dependencies: sdk: flutter integration_test: ^0.9.1 mockito: ^3.0.0 - pedantic: ^1.8.0 + pedantic: ^1.9.2 test: ^1.3.0 environment: diff --git a/packages/share_plus_web/analysis_options.yaml b/packages/share_plus_web/analysis_options.yaml new file mode 100644 index 0000000000..f04c6cf0f3 --- /dev/null +++ b/packages/share_plus_web/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../analysis_options.yaml diff --git a/packages/share_plus_web/pubspec.yaml b/packages/share_plus_web/pubspec.yaml index 53b0befacd..c893d6d38d 100644 --- a/packages/share_plus_web/pubspec.yaml +++ b/packages/share_plus_web/pubspec.yaml @@ -26,7 +26,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.8.0 + pedantic: ^1.9.2 mockito: ^4.1.1 integration_test: ^0.9.2 diff --git a/packages/share_plus_windows/analysis_options.yaml b/packages/share_plus_windows/analysis_options.yaml index 108d1058ac..f04c6cf0f3 100644 --- a/packages/share_plus_windows/analysis_options.yaml +++ b/packages/share_plus_windows/analysis_options.yaml @@ -1 +1 @@ -include: package:pedantic/analysis_options.yaml +include: ../../analysis_options.yaml diff --git a/packages/share_plus_windows/pubspec.yaml b/packages/share_plus_windows/pubspec.yaml index dd999aa241..adb3e686ff 100644 --- a/packages/share_plus_windows/pubspec.yaml +++ b/packages/share_plus_windows/pubspec.yaml @@ -18,4 +18,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.9.0 + pedantic: ^1.9.2 From 4132d611dbe4adcb246ba43d41e367a63423bf8c Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Thu, 17 Dec 2020 14:20:05 +0100 Subject: [PATCH 02/11] small fixes --- .gitignore | 2 ++ analysis_options.yaml | 2 +- melos.yaml | 4 ++-- packages/android_alarm_manager_plus/example/pubspec.yaml | 6 +++++- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index d88e57a703..53c8c36a0b 100644 --- a/.gitignore +++ b/.gitignore @@ -45,3 +45,5 @@ build/ .classpath .settings /.fvm + +.melos_tool/ diff --git a/analysis_options.yaml b/analysis_options.yaml index 225e9a759d..5fdfa9bdf6 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:pedantic/analysis_options.1.8.0.yaml +include: package:pedantic/analysis_options.1.9.0.yaml analyzer: exclude: diff --git a/melos.yaml b/melos.yaml index 6d746c7ca4..648af8757d 100644 --- a/melos.yaml +++ b/melos.yaml @@ -78,8 +78,8 @@ scripts: rm -rf ./build ./android/.gradle ./ios/.symlinks ./ios/Pods ./android/.idea ./.idea ./.dart-tool/build dev_dependencies: - pedantic: 1.8.0 + pedantic: 1.9.2 environment: sdk: ">=2.1.0 <3.0.0" - flutter: ">=1.12.13+hotfix.5 <2.0.0" \ No newline at end of file + flutter: ">=1.12.13+hotfix.5 <2.0.0" diff --git a/packages/android_alarm_manager_plus/example/pubspec.yaml b/packages/android_alarm_manager_plus/example/pubspec.yaml index 7b09668ce7..ab3d5e0225 100644 --- a/packages/android_alarm_manager_plus/example/pubspec.yaml +++ b/packages/android_alarm_manager_plus/example/pubspec.yaml @@ -1,6 +1,10 @@ name: android_alarm_manager_example description: Demonstrates how to use the android_alarm_manager_plus plugin. +environment: + sdk: ">=2.1.0 <3.0.0" + flutter: ">=1.12.13+hotfix.5 <2.0.0" + dependencies: flutter: sdk: flutter @@ -16,7 +20,7 @@ dev_dependencies: sdk: flutter flutter_test: sdk: flutter - pedantic: ^1.8.0 + pedantic: ^1.9.2 flutter: uses-material-design: true From 9754c664e5e95a2babff919062b5b522b91f0e1c Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Thu, 17 Dec 2020 14:27:58 +0100 Subject: [PATCH 03/11] battery_plus analysis fixed --- packages/battery_plus/example/lib/main.dart | 4 ++-- .../battery_plus/example/test_driver/battery_plus_e2e.dart | 4 ++-- .../example/test_driver/battery_plus_e2e_test.dart | 4 ++-- packages/battery_plus/lib/battery_plus.dart | 4 +--- packages/battery_plus/test/battery_test.dart | 3 +-- 5 files changed, 8 insertions(+), 11 deletions(-) diff --git a/packages/battery_plus/example/lib/main.dart b/packages/battery_plus/example/lib/main.dart index e5408dd143..720109152c 100644 --- a/packages/battery_plus/example/lib/main.dart +++ b/packages/battery_plus/example/lib/main.dart @@ -36,7 +36,7 @@ class MyHomePage extends StatefulWidget { } class _MyHomePageState extends State { - Battery _battery = Battery(); + final Battery _battery = Battery(); BatteryState _batteryState; StreamSubscription _batteryStateSubscription; @@ -64,7 +64,7 @@ class _MyHomePageState extends State { floatingActionButton: FloatingActionButton( child: const Icon(Icons.battery_unknown), onPressed: () async { - final int batteryLevel = await _battery.batteryLevel; + final batteryLevel = await _battery.batteryLevel; // ignore: unawaited_futures showDialog( context: context, diff --git a/packages/battery_plus/example/test_driver/battery_plus_e2e.dart b/packages/battery_plus/example/test_driver/battery_plus_e2e.dart index 729639d197..b031396cba 100644 --- a/packages/battery_plus/example/test_driver/battery_plus_e2e.dart +++ b/packages/battery_plus/example/test_driver/battery_plus_e2e.dart @@ -10,8 +10,8 @@ void main() { IntegrationTestWidgetsFlutterBinding.ensureInitialized(); testWidgets('Can get battery level', (WidgetTester tester) async { - final Battery battery = Battery(); - final int batteryLevel = await battery.batteryLevel; + final battery = Battery(); + final batteryLevel = await battery.batteryLevel; expect(batteryLevel, isNotNull); }); } diff --git a/packages/battery_plus/example/test_driver/battery_plus_e2e_test.dart b/packages/battery_plus/example/test_driver/battery_plus_e2e_test.dart index c0cbdcab2f..44c08f5784 100644 --- a/packages/battery_plus/example/test_driver/battery_plus_e2e_test.dart +++ b/packages/battery_plus/example/test_driver/battery_plus_e2e_test.dart @@ -7,8 +7,8 @@ import 'dart:io'; import 'package:flutter_driver/flutter_driver.dart'; Future main() async { - final FlutterDriver driver = await FlutterDriver.connect(); - final String data = + final driver = await FlutterDriver.connect(); + final data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); final Map result = jsonDecode(data); diff --git a/packages/battery_plus/lib/battery_plus.dart b/packages/battery_plus/lib/battery_plus.dart index 4109da6e92..5658aa14e6 100644 --- a/packages/battery_plus/lib/battery_plus.dart +++ b/packages/battery_plus/lib/battery_plus.dart @@ -23,9 +23,7 @@ class Battery { // EventChannel because it is overridden. Forcing the class to be a singleton class can prevent // misuse of creating a second instance from a programmer. factory Battery() { - if (_singleton == null) { - _singleton = Battery._(); - } + _singleton ??= Battery._(); return _singleton; } diff --git a/packages/battery_plus/test/battery_test.dart b/packages/battery_plus/test/battery_test.dart index 2dc7e15a33..4c4eb4ab1e 100644 --- a/packages/battery_plus/test/battery_test.dart +++ b/packages/battery_plus/test/battery_test.dart @@ -45,8 +45,7 @@ void main() { }); test('receive values', () async { - final StreamQueue queue = - StreamQueue(battery.onBatteryStateChanged); + final queue = StreamQueue(battery.onBatteryStateChanged); controller.add(BatteryState.full); expect(await queue.next, BatteryState.full); From db05041a789a6c4138d9e764985de75d016e70b4 Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Thu, 17 Dec 2020 14:37:21 +0100 Subject: [PATCH 04/11] analyze fixes wip --- .../lib/src/battery_plus_linux_real.dart | 1 + packages/battery_plus_linux/lib/src/upower_device.dart | 3 +++ .../lib/src/method_channel_battery_plus.dart | 2 ++ .../test/battery_plus_platform_interface_test.dart | 2 +- packages/connectivity_plus/example/lib/main.dart | 2 +- .../example/test_driver/connectivity_plus_e2e.dart | 2 +- .../example/test_driver/connectivity_plus_e2e_test.dart | 2 +- packages/connectivity_plus/test/connectivity_test.dart | 8 +++++++- .../lib/src/connectivity_real.dart | 3 +++ .../connectivity_plus_linux/lib/src/network_manager.dart | 3 +++ .../lib/src/method_channel_connectivity.dart | 3 ++- .../test/method_channel_connectivity_test.dart | 2 +- packages/connectivity_plus_web/test/lib/main.dart | 2 +- .../example/test_driver/device_info_plus_e2e.dart | 2 +- .../example/test_driver/device_info_plus_e2e_test.dart | 2 +- packages/device_info_plus_linux/lib/src/device_info.dart | 2 ++ .../lib/method_channel/method_channel_device_info.dart | 2 ++ .../test/method_channel_device_info_test.dart | 2 +- packages/package_info_plus/example/lib/main.dart | 2 +- .../example/test_driver/package_info_plus_e2e.dart | 2 +- .../example/test_driver/package_info_plus_e2e_test.dart | 2 +- packages/package_info_plus/test/package_info_test.dart | 2 +- .../lib/method_channel_package_info.dart | 2 +- .../test/method_channel_package_info_test.dart | 2 +- .../package_info_plus_web/lib/package_info_plus_web.dart | 2 +- packages/sensors_plus/example/lib/main.dart | 2 +- packages/sensors_plus/example/lib/snake.dart | 2 +- .../example/test_driver/sensors_plus_e2e.dart | 2 +- .../example/test_driver/sensors_plus_e2e_test.dart | 2 +- packages/sensors_plus/lib/src/sensors.dart | 3 +++ packages/sensors_plus/test/sensors_test.dart | 2 +- .../lib/src/method_channel_sensors.dart | 3 +++ .../test/sensors_plus_platform_interface_test.dart | 2 +- packages/sensors_plus_web/lib/src/sensors.dart | 5 ++++- packages/share_plus/example/lib/image_previews.dart | 2 +- .../example/test_driver/share_plus_e2e_test.dart | 2 +- .../lib/method_channel/method_channel_share.dart | 2 +- .../test/share_plus_platform_interface_test.dart | 2 +- 38 files changed, 61 insertions(+), 29 deletions(-) diff --git a/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart b/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart index 80752b2f43..4e71994957 100644 --- a/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart +++ b/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart @@ -49,6 +49,7 @@ class BatteryPlusLinux extends BatteryPlatform { StreamController _stateController; @visibleForTesting + // ignore: public_member_api_docs UPowerDeviceFactory createDevice = () => UPowerDevice.display(); void _addState(UPowerBatteryState value) { diff --git a/packages/battery_plus_linux/lib/src/upower_device.dart b/packages/battery_plus_linux/lib/src/upower_device.dart index 53032f3b68..746b44534c 100644 --- a/packages/battery_plus_linux/lib/src/upower_device.dart +++ b/packages/battery_plus_linux/lib/src/upower_device.dart @@ -4,6 +4,9 @@ const _kInterface = 'org.freedesktop.UPower'; const _kDeviceAddress = 'org.freedesktop.UPower.Device'; const _kDisplayDevicePath = '/org/freedesktop/UPower/devices/DisplayDevice'; +// Used internally +// ignore_for_file: public_member_api_docs + enum UPowerBatteryState { unknown, charging, diff --git a/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart b/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart index 395fce06de..c6b808f289 100644 --- a/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart +++ b/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart @@ -26,11 +26,13 @@ class MethodChannelBattery extends BatteryPlatform { Stream _onBatteryStateChanged; /// Returns the current battery level in percent. + @override Future get batteryLevel => methodChannel .invokeMethod('getBatteryLevel') .then((dynamic result) => result); /// Fires whenever the battery state changes. + @override Stream get onBatteryStateChanged { if (_onBatteryStateChanged == null) { _onBatteryStateChanged = eventChannel diff --git a/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart b/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart index 6456d5d40a..fcd730041a 100644 --- a/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart +++ b/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart @@ -7,7 +7,7 @@ void main() { TestWidgetsFlutterBinding.ensureInitialized(); group('$MethodChannelBattery', () { - final List log = []; + final log = []; MethodChannelBattery methodChannelBattery; setUp(() async { diff --git a/packages/connectivity_plus/example/lib/main.dart b/packages/connectivity_plus/example/lib/main.dart index 76eecb88f4..05b5be655c 100644 --- a/packages/connectivity_plus/example/lib/main.dart +++ b/packages/connectivity_plus/example/lib/main.dart @@ -126,7 +126,7 @@ class _MyHomePageState extends State { try { if (!kIsWeb && Platform.isIOS) { - LocationAuthorizationStatus status = + var status = await _connectivity.getLocationServiceAuthorization(); if (status == LocationAuthorizationStatus.notDetermined) { status = diff --git a/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e.dart b/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e.dart index a5839fcd0f..7e46d2d647 100644 --- a/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e.dart +++ b/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e.dart @@ -18,7 +18,7 @@ void main() { }); testWidgets('test connectivity result', (WidgetTester tester) async { - final ConnectivityResult result = await _connectivity.checkConnectivity(); + final result = await _connectivity.checkConnectivity(); expect(result, isNotNull); switch (result) { case ConnectivityResult.wifi: diff --git a/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart b/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart index c0cbdcab2f..760fefbebb 100644 --- a/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart +++ b/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart @@ -7,7 +7,7 @@ import 'dart:io'; import 'package:flutter_driver/flutter_driver.dart'; Future main() async { - final FlutterDriver driver = await FlutterDriver.connect(); + final driver = await FlutterDriver.connect(); final String data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); diff --git a/packages/connectivity_plus/test/connectivity_test.dart b/packages/connectivity_plus/test/connectivity_test.dart index 9ac08586e4..ea1f0f4845 100644 --- a/packages/connectivity_plus/test/connectivity_test.dart +++ b/packages/connectivity_plus/test/connectivity_test.dart @@ -48,7 +48,7 @@ void main() { }); test('requestLocationServiceAuthorization', () async { - LocationAuthorizationStatus result = + var result = await connectivity.requestLocationServiceAuthorization(); expect(result, kRequestLocationResult); }); @@ -64,28 +64,34 @@ void main() { class MockConnectivityPlatform extends Mock with MockPlatformInterfaceMixin implements ConnectivityPlatform { + @override Future checkConnectivity() async { return kCheckConnectivityResult; } + @override Future getWifiName() async { return kWifiNameResult; } + @override Future getWifiBSSID() async { return kWifiBSSIDResult; } + @override Future getWifiIP() async { return kWifiIpAddressResult; } + @override Future requestLocationServiceAuthorization({ bool requestAlwaysLocationUsage = false, }) async { return kRequestLocationResult; } + @override Future getLocationServiceAuthorization() async { return kGetLocationResult; } diff --git a/packages/connectivity_plus_linux/lib/src/connectivity_real.dart b/packages/connectivity_plus_linux/lib/src/connectivity_real.dart index cddbd7f158..bd1308a163 100644 --- a/packages/connectivity_plus_linux/lib/src/connectivity_real.dart +++ b/packages/connectivity_plus_linux/lib/src/connectivity_real.dart @@ -5,6 +5,9 @@ import 'package:meta/meta.dart'; import 'network_manager.dart'; +// Used internally +// ignore_for_file: public_member_api_docs + typedef _DeviceGetter = Future Function(NMDevice device); typedef _ConnectionGetter = Future Function(NMConnection connection); diff --git a/packages/connectivity_plus_linux/lib/src/network_manager.dart b/packages/connectivity_plus_linux/lib/src/network_manager.dart index a130ecaf2e..38601baee4 100644 --- a/packages/connectivity_plus_linux/lib/src/network_manager.dart +++ b/packages/connectivity_plus_linux/lib/src/network_manager.dart @@ -2,6 +2,9 @@ import 'dart:async'; import 'package:dbus/dbus.dart'; +// Used internally +// ignore_for_file: public_member_api_docs + const _kNetworkManager = 'org.freedesktop.NetworkManager'; const _kActiveConnection = _kNetworkManager + '.Connection.Active'; const _kDevice = _kNetworkManager + '.Device'; diff --git a/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart b/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart index 2cbc23df6d..612ed8db98 100644 --- a/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart +++ b/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart @@ -25,6 +25,7 @@ class MethodChannelConnectivity extends ConnectivityPlatform { Stream _onConnectivityChanged; /// Fires whenever the connectivity state changes. + @override Stream get onConnectivityChanged { if (_onConnectivityChanged == null) { _onConnectivityChanged = eventChannel @@ -44,7 +45,7 @@ class MethodChannelConnectivity extends ConnectivityPlatform { @override Future getWifiName() async { - String wifiName = await methodChannel.invokeMethod('wifiName'); + var wifiName = await methodChannel.invokeMethod('wifiName'); // as Android might return , uniforming result // our iOS implementation will return null if (wifiName == '') { diff --git a/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart b/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart index 3624532830..cf32a0b98b 100644 --- a/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart +++ b/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart @@ -92,7 +92,7 @@ void main() { }); test('getWifiIP', () async { - final String result = await methodChannelConnectivity.getWifiIP(); + final result = await methodChannelConnectivity.getWifiIP(); expect(result, '127.0.0.1'); expect( log, diff --git a/packages/connectivity_plus_web/test/lib/main.dart b/packages/connectivity_plus_web/test/lib/main.dart index bc41b614c0..eb02713f20 100644 --- a/packages/connectivity_plus_web/test/lib/main.dart +++ b/packages/connectivity_plus_web/test/lib/main.dart @@ -24,7 +24,7 @@ void main() { when(connection.downlink).thenReturn(downlink); when(connection.rtt).thenReturn(downlink); - NetworkInformationApiConnectivityPlugin plugin = + var plugin = NetworkInformationApiConnectivityPlugin.withConnection(connection); expect(plugin.checkConnectivity(), completion(equals(expected))); } diff --git a/packages/device_info_plus/example/test_driver/device_info_plus_e2e.dart b/packages/device_info_plus/example/test_driver/device_info_plus_e2e.dart index 88811ca901..a2d4cd3d5f 100644 --- a/packages/device_info_plus/example/test_driver/device_info_plus_e2e.dart +++ b/packages/device_info_plus/example/test_driver/device_info_plus_e2e.dart @@ -16,7 +16,7 @@ void main() { WebBrowserInfo webBrowserInfo; setUpAll(() async { - final DeviceInfoPlugin deviceInfoPlugin = DeviceInfoPlugin(); + final deviceInfoPlugin = DeviceInfoPlugin(); if (Platform.isIOS) { iosInfo = await deviceInfoPlugin.iosInfo; } else if (Platform.isAndroid) { diff --git a/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart b/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart index 7a2c213387..a6241a7645 100644 --- a/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart +++ b/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart @@ -8,7 +8,7 @@ import 'dart:io'; import 'package:flutter_driver/flutter_driver.dart'; Future main() async { - final FlutterDriver driver = await FlutterDriver.connect(); + final driver = await FlutterDriver.connect(); final String data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); diff --git a/packages/device_info_plus_linux/lib/src/device_info.dart b/packages/device_info_plus_linux/lib/src/device_info.dart index 202fc23c5f..cd266fae1b 100644 --- a/packages/device_info_plus_linux/lib/src/device_info.dart +++ b/packages/device_info_plus_linux/lib/src/device_info.dart @@ -5,10 +5,12 @@ import 'package:file/file.dart'; import 'package:file/local.dart'; import 'package:meta/meta.dart'; +/// See [DeviceInfoPlatform] class DeviceInfoLinux extends DeviceInfoPlatform { LinuxDeviceInfo _cache; final FileSystem _fileSystem; + /// DeviceInfoLinux({@visibleForTesting FileSystem fileSystem}) : _fileSystem = fileSystem ?? LocalFileSystem(); diff --git a/packages/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart b/packages/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart index 91d3a9e14a..d7e41fc62d 100644 --- a/packages/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart +++ b/packages/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart @@ -13,6 +13,7 @@ class MethodChannelDeviceInfo extends DeviceInfoPlatform { MethodChannel('dev.fluttercommunity.plus/device_info'); // Method channel for Android devices + @override Future androidInfo() async { return AndroidDeviceInfo.fromMap( (await channel.invokeMethod('getAndroidDeviceInfo')) @@ -21,6 +22,7 @@ class MethodChannelDeviceInfo extends DeviceInfoPlatform { } // Method channel for iOS devices + @override Future iosInfo() async { return IosDeviceInfo.fromMap( (await channel.invokeMethod('getIosDeviceInfo')).cast(), diff --git a/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart b/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart index 0524dec49a..593fa6fbdb 100644 --- a/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart +++ b/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart @@ -42,7 +42,7 @@ void main() { }); test("iosInfo", () async { - final IosDeviceInfo result = await methodChannelDeviceInfo.iosInfo(); + final result = await methodChannelDeviceInfo.iosInfo(); expect(result.name, "iPhone 10"); }); }); diff --git a/packages/package_info_plus/example/lib/main.dart b/packages/package_info_plus/example/lib/main.dart index 5d2c61e480..67403c8ed1 100644 --- a/packages/package_info_plus/example/lib/main.dart +++ b/packages/package_info_plus/example/lib/main.dart @@ -48,7 +48,7 @@ class _MyHomePageState extends State { } Future _initPackageInfo() async { - final PackageInfo info = await PackageInfo.fromPlatform(); + final info = await PackageInfo.fromPlatform(); setState(() { _packageInfo = info; }); diff --git a/packages/package_info_plus/example/test_driver/package_info_plus_e2e.dart b/packages/package_info_plus/example/test_driver/package_info_plus_e2e.dart index ac1468834d..9d37f1bf3e 100644 --- a/packages/package_info_plus/example/test_driver/package_info_plus_e2e.dart +++ b/packages/package_info_plus/example/test_driver/package_info_plus_e2e.dart @@ -13,7 +13,7 @@ void main() { IntegrationTestWidgetsFlutterBinding.ensureInitialized(); testWidgets('fromPlatform', (WidgetTester tester) async { - final PackageInfo info = await PackageInfo.fromPlatform(); + final info = await PackageInfo.fromPlatform(); // These tests are based on the example app. The tests should be updated if any related info changes. if (Platform.isAndroid) { expect(info.appName, 'package_info_example'); diff --git a/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart b/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart index f532c389a0..fb1c34d609 100644 --- a/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart +++ b/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart @@ -8,7 +8,7 @@ import 'dart:io'; import 'package:flutter_driver/flutter_driver.dart'; Future main() async { - final FlutterDriver driver = await FlutterDriver.connect(); + final driver = await FlutterDriver.connect(); final String data = await driver.requestData( null, timeout: const Duration(minutes: 1), diff --git a/packages/package_info_plus/test/package_info_test.dart b/packages/package_info_plus/test/package_info_test.dart index 2f2099ac51..16f0b62731 100644 --- a/packages/package_info_plus/test/package_info_test.dart +++ b/packages/package_info_plus/test/package_info_test.dart @@ -35,7 +35,7 @@ void main() { }); test('fromPlatform', () async { - final PackageInfo info = await PackageInfo.fromPlatform(); + final info = await PackageInfo.fromPlatform(); expect(info.appName, 'package_info_example'); expect(info.buildNumber, '1'); expect(info.packageName, 'io.flutter.plugins.packageinfoexample'); diff --git a/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart b/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart index ee310992f7..6708d11d56 100644 --- a/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart +++ b/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart @@ -10,7 +10,7 @@ const MethodChannel _channel = class MethodChannelPackageInfo extends PackageInfoPlatform { @override Future getAll() async { - final Map map = + final map = await _channel.invokeMapMethod('getAll'); return PackageInfoData( appName: map["appName"], diff --git a/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart b/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart index 57a5d3fefa..c52467fa31 100644 --- a/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart +++ b/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart @@ -37,7 +37,7 @@ void main() { group('$MethodChannelPackageInfo()', () { const MethodChannel channel = MethodChannel('dev.fluttercommunity.plus/package_info'); - final List log = []; + final log = []; channel.setMockMethodCallHandler((MethodCall methodCall) async { log.add(methodCall); switch (methodCall.method) { diff --git a/packages/package_info_plus_web/lib/package_info_plus_web.dart b/packages/package_info_plus_web/lib/package_info_plus_web.dart index 1c1945a0ab..75e296ac76 100644 --- a/packages/package_info_plus_web/lib/package_info_plus_web.dart +++ b/packages/package_info_plus_web/lib/package_info_plus_web.dart @@ -17,7 +17,7 @@ class PackageInfoPlugin extends PackageInfoPlatform { @override Future getAll() async { - String url = + var url = "${Uri.parse(window.document.baseUri).removeFragment()}/version.json"; final response = await get(url); diff --git a/packages/sensors_plus/example/lib/main.dart b/packages/sensors_plus/example/lib/main.dart index 45574f3d5f..4ce6b5c6e6 100644 --- a/packages/sensors_plus/example/lib/main.dart +++ b/packages/sensors_plus/example/lib/main.dart @@ -115,7 +115,7 @@ class _MyHomePageState extends State { @override void dispose() { super.dispose(); - for (StreamSubscription subscription in _streamSubscriptions) { + for (var subscription in _streamSubscriptions) { subscription.cancel(); } } diff --git a/packages/sensors_plus/example/lib/snake.dart b/packages/sensors_plus/example/lib/snake.dart index f9dbd36120..b709978205 100644 --- a/packages/sensors_plus/example/lib/snake.dart +++ b/packages/sensors_plus/example/lib/snake.dart @@ -96,7 +96,7 @@ class SnakeState extends State { } void _step() { - final math.Point newDirection = acceleration == null + final newDirection = acceleration == null ? null : acceleration.x.abs() < 1.0 && acceleration.y.abs() < 1.0 ? null diff --git a/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart b/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart index 975df43806..975653af06 100644 --- a/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart +++ b/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart @@ -12,7 +12,7 @@ void main() { testWidgets('Can subscript to accelerometerEvents and get non-null events', (WidgetTester tester) async { - final Completer completer = + final completer = Completer(); StreamSubscription subscription; subscription = accelerometerEvents.listen((AccelerometerEvent event) { diff --git a/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart b/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart index 7a2c213387..0a17315fc5 100644 --- a/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart +++ b/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart @@ -9,7 +9,7 @@ import 'package:flutter_driver/flutter_driver.dart'; Future main() async { final FlutterDriver driver = await FlutterDriver.connect(); - final String data = + final data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); final Map result = jsonDecode(data); diff --git a/packages/sensors_plus/lib/src/sensors.dart b/packages/sensors_plus/lib/src/sensors.dart index 968daa2ad8..1c9e3bed39 100644 --- a/packages/sensors_plus/lib/src/sensors.dart +++ b/packages/sensors_plus/lib/src/sensors.dart @@ -14,16 +14,19 @@ class Sensors extends SensorsPlatform { static SensorsPlatform get _platform => SensorsPlatform.instance; /// A broadcast stream of events from the device accelerometer. + @override Stream get accelerometerEvents { return _platform.accelerometerEvents; } /// A broadcast stream of events from the device gyroscope. + @override Stream get gyroscopeEvents { return _platform.gyroscopeEvents; } /// Events from the device accelerometer with gravity removed. + @override Stream get userAccelerometerEvents { return _platform.userAccelerometerEvents; } diff --git a/packages/sensors_plus/test/sensors_test.dart b/packages/sensors_plus/test/sensors_test.dart index 40726513c1..002069124a 100644 --- a/packages/sensors_plus/test/sensors_test.dart +++ b/packages/sensors_plus/test/sensors_test.dart @@ -15,7 +15,7 @@ void main() { test('$accelerometerEvents are streamed', () async { const String channelName = 'dev.fluttercommunity.plus/sensors/accelerometer'; - const List sensorData = [1.0, 2.0, 3.0]; + const sensorData = [1.0, 2.0, 3.0]; _initializeFakeSensorChannel(channelName, sensorData); final AccelerometerEvent event = await accelerometerEvents.first; diff --git a/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart b/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart index 3a30405f16..336ccb62e3 100644 --- a/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart +++ b/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart @@ -23,6 +23,7 @@ class MethodChannelSensors extends SensorsPlatform { Stream _userAccelerometerEvents; /// A broadcast stream of events from the device accelerometer. + @override Stream get accelerometerEvents { if (_accelerometerEvents == null) { _accelerometerEvents = _accelerometerEventChannel @@ -36,6 +37,7 @@ class MethodChannelSensors extends SensorsPlatform { } /// A broadcast stream of events from the device gyroscope. + @override Stream get gyroscopeEvents { if (_gyroscopeEvents == null) { _gyroscopeEvents = @@ -48,6 +50,7 @@ class MethodChannelSensors extends SensorsPlatform { } /// Events from the device accelerometer with gravity removed. + @override Stream get userAccelerometerEvents { if (_userAccelerometerEvents == null) { _userAccelerometerEvents = _userAccelerometerEventChannel diff --git a/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart b/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart index 06ce8cf1a8..f12549a542 100644 --- a/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart +++ b/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart @@ -48,7 +48,7 @@ void main() { const List sensorData = [3.0, 4.0, 5.0]; _initializeFakeSensorChannel(channelName, sensorData); - final GyroscopeEvent event = await gyroscopeEvents.first; + final event = await gyroscopeEvents.first; expect(event.x, sensorData[0]); expect(event.y, sensorData[1]); diff --git a/packages/sensors_plus_web/lib/src/sensors.dart b/packages/sensors_plus_web/lib/src/sensors.dart index bb7ecac855..11a40c65b3 100644 --- a/packages/sensors_plus_web/lib/src/sensors.dart +++ b/packages/sensors_plus_web/lib/src/sensors.dart @@ -51,6 +51,7 @@ class SensorsPlugin extends SensorsPlatform { StreamController _accelerometerStreamController; Stream _accelerometerResultStream; + @override Stream get accelerometerEvents { if (_accelerometerStreamController == null) { _accelerometerStreamController = StreamController(); @@ -96,12 +97,13 @@ class SensorsPlugin extends SensorsPlatform { StreamController _gyroscopeEventStreamController; Stream _gyroscopeEventResultStream; + @override Stream get gyroscopeEvents { if (_gyroscopeEventStreamController == null) { _gyroscopeEventStreamController = StreamController(); _featureDetected( () { - final html.Gyroscope _gyroscope = html.Gyroscope(); + final _gyroscope = html.Gyroscope(); setProperty( _gyroscope, @@ -141,6 +143,7 @@ class SensorsPlugin extends SensorsPlatform { StreamController _userAccelerometerStreamController; Stream _userAccelerometerResultStream; + @override Stream get userAccelerometerEvents { if (_userAccelerometerStreamController == null) { _userAccelerometerStreamController = diff --git a/packages/share_plus/example/lib/image_previews.dart b/packages/share_plus/example/lib/image_previews.dart index 61ecec43bd..51db176b06 100644 --- a/packages/share_plus/example/lib/image_previews.dart +++ b/packages/share_plus/example/lib/image_previews.dart @@ -22,7 +22,7 @@ class ImagePreviews extends StatelessWidget { return Container(); } - List imageWidgets = []; + var imageWidgets = []; for (int i = 0; i < imagePaths.length; i++) { imageWidgets.add(_ImagePreview( imagePaths[i], diff --git a/packages/share_plus/example/test_driver/share_plus_e2e_test.dart b/packages/share_plus/example/test_driver/share_plus_e2e_test.dart index 7a2c213387..a6241a7645 100644 --- a/packages/share_plus/example/test_driver/share_plus_e2e_test.dart +++ b/packages/share_plus/example/test_driver/share_plus_e2e_test.dart @@ -8,7 +8,7 @@ import 'dart:io'; import 'package:flutter_driver/flutter_driver.dart'; Future main() async { - final FlutterDriver driver = await FlutterDriver.connect(); + final driver = await FlutterDriver.connect(); final String data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); diff --git a/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart b/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart index 4330277492..a9e514f845 100644 --- a/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart +++ b/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart @@ -54,7 +54,7 @@ class MethodChannelShare extends SharePlatform { assert(paths != null); assert(paths.isNotEmpty); assert(paths.every((element) => element != null && element.isNotEmpty)); - final Map params = { + final params = { 'paths': paths, 'mimeTypes': mimeTypes ?? paths.map((String path) => _mimeTypeForPath(path)).toList(), diff --git a/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart b/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart index b6d7930294..4ad325d81e 100644 --- a/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart +++ b/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart @@ -77,7 +77,7 @@ void main() { }); test('sharing file sets correct mimeType', () async { - final String path = 'tempfile-83649a.png'; + final path = 'tempfile-83649a.png'; final File file = File(path); try { file.createSync(); From a42d3d9f23e4b942ceca777496f5ade0f7fdae73 Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Thu, 17 Dec 2020 14:44:53 +0100 Subject: [PATCH 05/11] fixed all analysis errors --- .../lib/src/method_channel_battery_plus.dart | 4 +--- .../battery_plus_platform_interface_test.dart | 4 ++-- .../connectivity_plus/example/lib/main.dart | 8 ++++---- .../connectivity_plus_e2e_test.dart | 2 +- .../lib/connectivity_plus.dart | 4 +--- .../test/connectivity_test.dart | 14 ++++++------- .../lib/src/method_channel_connectivity.dart | 4 +--- .../method_channel_connectivity_test.dart | 15 +++++++------- .../connectivity_plus_web/test/lib/main.dart | 5 ++--- .../device_info_plus_e2e_test.dart | 2 +- .../lib/model/web_browser_info.dart | 14 ++++++------- .../test/method_channel_device_info_test.dart | 18 ++++++++--------- .../package_info_plus_e2e_test.dart | 2 +- .../test/package_info_test.dart | 2 +- .../lib/method_channel_package_info.dart | 8 ++++---- .../method_channel_package_info_test.dart | 6 +++--- .../lib/package_info_plus_web.dart | 2 +- packages/sensors_plus/example/lib/main.dart | 9 ++++----- packages/sensors_plus/example/lib/snake.dart | 12 +++++------ .../test_driver/sensors_plus_e2e_test.dart | 2 +- packages/sensors_plus/test/sensors_test.dart | 20 +++++++++---------- .../lib/src/method_channel_sensors.dart | 13 +++--------- .../sensors_plus_platform_interface_test.dart | 20 +++++++++---------- .../sensors_plus_web/lib/src/sensors.dart | 4 ++-- packages/sensors_plus_web/lib/src/utils.dart | 8 ++++---- .../example/lib/image_previews.dart | 4 ++-- packages/share_plus/example/lib/main.dart | 6 +++--- .../test_driver/share_plus_e2e_test.dart | 2 +- .../method_channel/method_channel_share.dart | 2 +- .../share_plus_platform_interface_test.dart | 6 +++--- 30 files changed, 101 insertions(+), 121 deletions(-) diff --git a/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart b/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart index c6b808f289..dc413ccd2d 100644 --- a/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart +++ b/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart @@ -34,11 +34,9 @@ class MethodChannelBattery extends BatteryPlatform { /// Fires whenever the battery state changes. @override Stream get onBatteryStateChanged { - if (_onBatteryStateChanged == null) { - _onBatteryStateChanged = eventChannel + _onBatteryStateChanged ??= eventChannel .receiveBroadcastStream() .map((dynamic event) => parseBatteryState(event)); - } return _onBatteryStateChanged; } } diff --git a/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart b/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart index fcd730041a..3d6ef6246e 100644 --- a/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart +++ b/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart @@ -44,13 +44,13 @@ void main() { }); test('onBatteryChanged', () async { - final BatteryState result = + final result = await methodChannelBattery.onBatteryStateChanged.first; expect(result, BatteryState.full); }); test('getBatteryLevel', () async { - final int result = await methodChannelBattery.batteryLevel; + final result = await methodChannelBattery.batteryLevel; expect(result, 100); expect( log, diff --git a/packages/connectivity_plus/example/lib/main.dart b/packages/connectivity_plus/example/lib/main.dart index 05b5be655c..9c0490fdec 100644 --- a/packages/connectivity_plus/example/lib/main.dart +++ b/packages/connectivity_plus/example/lib/main.dart @@ -104,7 +104,7 @@ class _MyHomePageState extends State { try { if (!kIsWeb && Platform.isIOS) { - LocationAuthorizationStatus status = + var status = await _connectivity.getLocationServiceAuthorization(); if (status == LocationAuthorizationStatus.notDetermined) { status = @@ -121,7 +121,7 @@ class _MyHomePageState extends State { } } on PlatformException catch (e) { print(e.toString()); - wifiName = "Failed to get Wifi Name"; + wifiName = 'Failed to get Wifi Name'; } try { @@ -143,14 +143,14 @@ class _MyHomePageState extends State { } } on PlatformException catch (e) { print(e.toString()); - wifiBSSID = "Failed to get Wifi BSSID"; + wifiBSSID = 'Failed to get Wifi BSSID'; } try { wifiIP = await _connectivity.getWifiIP(); } on PlatformException catch (e) { print(e.toString()); - wifiIP = "Failed to get Wifi IP"; + wifiIP = 'Failed to get Wifi IP'; } setState(() { diff --git a/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart b/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart index 760fefbebb..44c08f5784 100644 --- a/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart +++ b/packages/connectivity_plus/example/test_driver/connectivity_plus_e2e_test.dart @@ -8,7 +8,7 @@ import 'package:flutter_driver/flutter_driver.dart'; Future main() async { final driver = await FlutterDriver.connect(); - final String data = + final data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); final Map result = jsonDecode(data); diff --git a/packages/connectivity_plus/lib/connectivity_plus.dart b/packages/connectivity_plus/lib/connectivity_plus.dart index 3bab8c0afd..cf520e025d 100644 --- a/packages/connectivity_plus/lib/connectivity_plus.dart +++ b/packages/connectivity_plus/lib/connectivity_plus.dart @@ -24,9 +24,7 @@ class Connectivity { // EventChannel because it is overridden. Forcing the class to be a singleton class can prevent // misuse of creating a second instance from a programmer. factory Connectivity() { - if (_singleton == null) { - _singleton = Connectivity._(); - } + _singleton ??= Connectivity._(); return _singleton; } diff --git a/packages/connectivity_plus/test/connectivity_test.dart b/packages/connectivity_plus/test/connectivity_test.dart index ea1f0f4845..56ac696de7 100644 --- a/packages/connectivity_plus/test/connectivity_test.dart +++ b/packages/connectivity_plus/test/connectivity_test.dart @@ -28,34 +28,32 @@ void main() { }); test('checkConnectivity', () async { - ConnectivityResult result = await connectivity.checkConnectivity(); + final result = await connectivity.checkConnectivity(); expect(result, kCheckConnectivityResult); }); test('getWifiName', () async { - String result = await connectivity.getWifiName(); + final result = await connectivity.getWifiName(); expect(result, kWifiNameResult); }); test('getWifiBSSID', () async { - String result = await connectivity.getWifiBSSID(); + final result = await connectivity.getWifiBSSID(); expect(result, kWifiBSSIDResult); }); test('getWifiIP', () async { - String result = await connectivity.getWifiIP(); + final result = await connectivity.getWifiIP(); expect(result, kWifiIpAddressResult); }); test('requestLocationServiceAuthorization', () async { - var result = - await connectivity.requestLocationServiceAuthorization(); + final result = await connectivity.requestLocationServiceAuthorization(); expect(result, kRequestLocationResult); }); test('getLocationServiceAuthorization', () async { - LocationAuthorizationStatus result = - await connectivity.getLocationServiceAuthorization(); + final result = await connectivity.getLocationServiceAuthorization(); expect(result, kRequestLocationResult); }); }); diff --git a/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart b/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart index 612ed8db98..b95c61d585 100644 --- a/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart +++ b/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart @@ -27,12 +27,10 @@ class MethodChannelConnectivity extends ConnectivityPlatform { /// Fires whenever the connectivity state changes. @override Stream get onConnectivityChanged { - if (_onConnectivityChanged == null) { - _onConnectivityChanged = eventChannel + _onConnectivityChanged ??= eventChannel .receiveBroadcastStream() .map((dynamic result) => result.toString()) .map(parseConnectivityResult); - } return _onConnectivityChanged; } diff --git a/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart b/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart index cf32a0b98b..3165b26d87 100644 --- a/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart +++ b/packages/connectivity_plus_platform_interface/test/method_channel_connectivity_test.dart @@ -11,7 +11,7 @@ void main() { TestWidgetsFlutterBinding.ensureInitialized(); group('$MethodChannelConnectivity', () { - final List log = []; + final log = []; MethodChannelConnectivity methodChannelConnectivity; setUp(() async { @@ -58,13 +58,13 @@ void main() { }); test('onConnectivityChanged', () async { - final ConnectivityResult result = + final result = await methodChannelConnectivity.onConnectivityChanged.first; expect(result, ConnectivityResult.wifi); }); test('getWifiName', () async { - final String result = await methodChannelConnectivity.getWifiName(); + final result = await methodChannelConnectivity.getWifiName(); expect(result, '1337wifi'); expect( log, @@ -78,7 +78,7 @@ void main() { }); test('getWifiBSSID', () async { - final String result = await methodChannelConnectivity.getWifiBSSID(); + final result = await methodChannelConnectivity.getWifiBSSID(); expect(result, 'c0:ff:33:c0:d3:55'); expect( log, @@ -106,7 +106,7 @@ void main() { }); test('requestLocationServiceAuthorization', () async { - final LocationAuthorizationStatus result = + final result = await methodChannelConnectivity.requestLocationServiceAuthorization(); expect(result, LocationAuthorizationStatus.authorizedAlways); expect( @@ -121,7 +121,7 @@ void main() { }); test('getLocationServiceAuthorization', () async { - final LocationAuthorizationStatus result = + final result = await methodChannelConnectivity.getLocationServiceAuthorization(); expect(result, LocationAuthorizationStatus.authorizedAlways); expect( @@ -136,8 +136,7 @@ void main() { }); test('checkConnectivity', () async { - final ConnectivityResult result = - await methodChannelConnectivity.checkConnectivity(); + final result = await methodChannelConnectivity.checkConnectivity(); expect(result, ConnectivityResult.wifi); expect( log, diff --git a/packages/connectivity_plus_web/test/lib/main.dart b/packages/connectivity_plus_web/test/lib/main.dart index eb02713f20..d3aabdec4e 100644 --- a/packages/connectivity_plus_web/test/lib/main.dart +++ b/packages/connectivity_plus_web/test/lib/main.dart @@ -57,10 +57,9 @@ void main() { group('get onConnectivityChanged', () { test('puts change events in a Stream', () async { final connection = MockNetworkInformation(); - NetworkInformationApiConnectivityPlugin plugin = + final plugin = NetworkInformationApiConnectivityPlugin.withConnection(connection); - - Stream results = plugin.onConnectivityChanged; + final results = plugin.onConnectivityChanged; // Fake a disconnect-reconnect await connection.mockChangeValue(downlink: 0, rtt: 0); diff --git a/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart b/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart index a6241a7645..8c663fb1db 100644 --- a/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart +++ b/packages/device_info_plus/example/test_driver/device_info_plus_e2e_test.dart @@ -9,7 +9,7 @@ import 'package:flutter_driver/flutter_driver.dart'; Future main() async { final driver = await FlutterDriver.connect(); - final String data = + final data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); final Map result = jsonDecode(data); diff --git a/packages/device_info_plus_platform_interface/lib/model/web_browser_info.dart b/packages/device_info_plus_platform_interface/lib/model/web_browser_info.dart index fcfc8a13ca..39600a1b75 100644 --- a/packages/device_info_plus_platform_interface/lib/model/web_browser_info.dart +++ b/packages/device_info_plus_platform_interface/lib/model/web_browser_info.dart @@ -127,25 +127,25 @@ class WebBrowserInfo { } BrowserName _parseUserAgentToBrowserName() { - if (userAgent.contains("Firefox")) { + if (userAgent.contains('Firefox')) { return BrowserName.firefox; // "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0" - } else if (userAgent.contains("SamsungBrowser")) { + } else if (userAgent.contains('SamsungBrowser')) { return BrowserName.samsungInternet; // "Mozilla/5.0 (Linux; Android 9; SAMSUNG SM-G955F Build/PPR1.180610.011) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/9.4 Chrome/67.0.3396.87 Mobile Safari/537.36 - } else if (userAgent.contains("Opera") || userAgent.contains("OPR")) { + } else if (userAgent.contains('Opera') || userAgent.contains('OPR')) { return BrowserName.opera; // "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 OPR/57.0.3098.106" - } else if (userAgent.contains("Trident")) { + } else if (userAgent.contains('Trident')) { return BrowserName.msie; // "Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; Zoom 3.6.0; wbx 1.0.0; rv:11.0) like Gecko" - } else if (userAgent.contains("Edge")) { + } else if (userAgent.contains('Edge')) { return BrowserName.edge; // "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299" - } else if (userAgent.contains("Chrome")) { + } else if (userAgent.contains('Chrome')) { return BrowserName.chrome; // "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/66.0.3359.181 Chrome/66.0.3359.181 Safari/537.36" - } else if (userAgent.contains("Safari")) { + } else if (userAgent.contains('Safari')) { return BrowserName.safari; // "Mozilla/5.0 (iPhone; CPU iPhone OS 11_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.0 Mobile/15E148 Safari/604.1 980x1306" } else { diff --git a/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart b/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart index 593fa6fbdb..d8aacc97d4 100644 --- a/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart +++ b/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart @@ -5,14 +5,12 @@ import 'package:flutter/services.dart'; import 'package:flutter_test/flutter_test.dart'; -import 'package:device_info_plus_platform_interface/device_info_plus_platform_interface.dart'; - import 'package:device_info_plus_platform_interface/method_channel/method_channel_device_info.dart'; void main() { TestWidgetsFlutterBinding.ensureInitialized(); - group("$MethodChannelDeviceInfo", () { + group('$MethodChannelDeviceInfo', () { MethodChannelDeviceInfo methodChannelDeviceInfo; setUp(() async { @@ -23,11 +21,11 @@ void main() { switch (methodCall.method) { case 'getAndroidDeviceInfo': return ({ - "brand": "Google", + 'brand': 'Google', }); case 'getIosDeviceInfo': return ({ - "name": "iPhone 10", + 'name': 'iPhone 10', }); default: return null; @@ -35,15 +33,15 @@ void main() { }); }); - test("androidInfo", () async { - final AndroidDeviceInfo result = + test('androidInfo', () async { + final result = await methodChannelDeviceInfo.androidInfo(); - expect(result.brand, "Google"); + expect(result.brand, 'Google'); }); - test("iosInfo", () async { + test('iosInfo', () async { final result = await methodChannelDeviceInfo.iosInfo(); - expect(result.name, "iPhone 10"); + expect(result.name, 'iPhone 10'); }); }); } diff --git a/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart b/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart index fb1c34d609..c66f62f15c 100644 --- a/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart +++ b/packages/package_info_plus/example/test_driver/package_info_plus_e2e_test.dart @@ -9,7 +9,7 @@ import 'package:flutter_driver/flutter_driver.dart'; Future main() async { final driver = await FlutterDriver.connect(); - final String data = await driver.requestData( + final data = await driver.requestData( null, timeout: const Duration(minutes: 1), ); diff --git a/packages/package_info_plus/test/package_info_test.dart b/packages/package_info_plus/test/package_info_test.dart index 16f0b62731..3184e860b3 100644 --- a/packages/package_info_plus/test/package_info_test.dart +++ b/packages/package_info_plus/test/package_info_test.dart @@ -9,7 +9,7 @@ import 'package:package_info_plus/package_info_plus.dart'; void main() { TestWidgetsFlutterBinding.ensureInitialized(); - const MethodChannel channel = + const channel = MethodChannel('dev.fluttercommunity.plus/package_info'); List log; diff --git a/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart b/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart index 6708d11d56..8672938827 100644 --- a/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart +++ b/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart @@ -13,10 +13,10 @@ class MethodChannelPackageInfo extends PackageInfoPlatform { final map = await _channel.invokeMapMethod('getAll'); return PackageInfoData( - appName: map["appName"], - packageName: map["packageName"], - version: map["version"], - buildNumber: map["buildNumber"], + appName: map['appName'], + packageName: map['packageName'], + version: map['version'], + buildNumber: map['buildNumber'], ); } } diff --git a/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart b/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart index c52467fa31..9ef4e6fe4c 100644 --- a/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart +++ b/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart @@ -25,7 +25,7 @@ void main() { }); test('Can be mocked with `implements`', () { - final PackageInfoPlatformMock mock = PackageInfoPlatformMock(); + final mock = PackageInfoPlatformMock(); PackageInfoPlatform.instance = mock; }); @@ -35,7 +35,7 @@ void main() { }); group('$MethodChannelPackageInfo()', () { - const MethodChannel channel = + const channel = MethodChannel('dev.fluttercommunity.plus/package_info'); final log = []; channel.setMockMethodCallHandler((MethodCall methodCall) async { @@ -54,7 +54,7 @@ void main() { } }); - final MethodChannelPackageInfo packageInfo = MethodChannelPackageInfo(); + final packageInfo = MethodChannelPackageInfo(); tearDown(() { log.clear(); diff --git a/packages/package_info_plus_web/lib/package_info_plus_web.dart b/packages/package_info_plus_web/lib/package_info_plus_web.dart index 75e296ac76..74dd794ef9 100644 --- a/packages/package_info_plus_web/lib/package_info_plus_web.dart +++ b/packages/package_info_plus_web/lib/package_info_plus_web.dart @@ -18,7 +18,7 @@ class PackageInfoPlugin extends PackageInfoPlatform { @override Future getAll() async { var url = - "${Uri.parse(window.document.baseUri).removeFragment()}/version.json"; + '${Uri.parse(window.document.baseUri).removeFragment()}/version.json'; final response = await get(url); if (response.statusCode == 200) { diff --git a/packages/sensors_plus/example/lib/main.dart b/packages/sensors_plus/example/lib/main.dart index 4ce6b5c6e6..7cea4d5c7e 100644 --- a/packages/sensors_plus/example/lib/main.dart +++ b/packages/sensors_plus/example/lib/main.dart @@ -44,16 +44,15 @@ class _MyHomePageState extends State { List _accelerometerValues; List _userAccelerometerValues; List _gyroscopeValues; - List> _streamSubscriptions = - >[]; + final _streamSubscriptions = >[]; @override Widget build(BuildContext context) { - final List accelerometer = + final accelerometer = _accelerometerValues?.map((double v) => v.toStringAsFixed(1))?.toList(); - final List gyroscope = + final gyroscope = _gyroscopeValues?.map((double v) => v.toStringAsFixed(1))?.toList(); - final List userAccelerometer = _userAccelerometerValues + final userAccelerometer = _userAccelerometerValues ?.map((double v) => v.toStringAsFixed(1)) ?.toList(); diff --git a/packages/sensors_plus/example/lib/snake.dart b/packages/sensors_plus/example/lib/snake.dart index b709978205..b21bfa0f15 100644 --- a/packages/sensors_plus/example/lib/snake.dart +++ b/packages/sensors_plus/example/lib/snake.dart @@ -33,17 +33,17 @@ class SnakeBoardPainter extends CustomPainter { @override void paint(Canvas canvas, Size size) { - final Paint blackLine = Paint()..color = Colors.black; - final Paint blackFilled = Paint() + final blackLine = Paint()..color = Colors.black; + final blackFilled = Paint() ..color = Colors.black ..style = PaintingStyle.fill; canvas.drawRect( Rect.fromPoints(Offset.zero, size.bottomLeft(Offset.zero)), blackLine, ); - for (math.Point p in state.body) { - final Offset a = Offset(cellSize * p.x, cellSize * p.y); - final Offset b = Offset(cellSize * (p.x + 1), cellSize * (p.y + 1)); + for (var p in state.body) { + final a = Offset(cellSize * p.x, cellSize * p.y); + final b = Offset(cellSize * (p.x + 1), cellSize * (p.y + 1)); canvas.drawRect(Rect.fromPoints(a, b), blackFilled); } @@ -120,7 +120,7 @@ class GameState { math.Point direction = const math.Point(1, 0); void step(math.Point newDirection) { - math.Point next = body.last + direction; + var next = body.last + direction; next = math.Point(next.x % columns, next.y % rows); body.add(next); diff --git a/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart b/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart index 0a17315fc5..8c663fb1db 100644 --- a/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart +++ b/packages/sensors_plus/example/test_driver/sensors_plus_e2e_test.dart @@ -8,7 +8,7 @@ import 'dart:io'; import 'package:flutter_driver/flutter_driver.dart'; Future main() async { - final FlutterDriver driver = await FlutterDriver.connect(); + final driver = await FlutterDriver.connect(); final data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); diff --git a/packages/sensors_plus/test/sensors_test.dart b/packages/sensors_plus/test/sensors_test.dart index 002069124a..d60d35486c 100644 --- a/packages/sensors_plus/test/sensors_test.dart +++ b/packages/sensors_plus/test/sensors_test.dart @@ -13,12 +13,12 @@ void main() { TestWidgetsFlutterBinding.ensureInitialized(); test('$accelerometerEvents are streamed', () async { - const String channelName = + const channelName = 'dev.fluttercommunity.plus/sensors/accelerometer'; const sensorData = [1.0, 2.0, 3.0]; _initializeFakeSensorChannel(channelName, sensorData); - final AccelerometerEvent event = await accelerometerEvents.first; + final event = await accelerometerEvents.first; expect(event.x, sensorData[0]); expect(event.y, sensorData[1]); @@ -26,11 +26,11 @@ void main() { }); test('$gyroscopeEvents are streamed', () async { - const String channelName = 'dev.fluttercommunity.plus/sensors/gyroscope'; - const List sensorData = [3.0, 4.0, 5.0]; + const channelName = 'dev.fluttercommunity.plus/sensors/gyroscope'; + const sensorData = [3.0, 4.0, 5.0]; _initializeFakeSensorChannel(channelName, sensorData); - final GyroscopeEvent event = await gyroscopeEvents.first; + final event = await gyroscopeEvents.first; expect(event.x, sensorData[0]); expect(event.y, sensorData[1]); @@ -38,11 +38,11 @@ void main() { }); test('$userAccelerometerEvents are streamed', () async { - const String channelName = 'dev.fluttercommunity.plus/sensors/user_accel'; - const List sensorData = [6.0, 7.0, 8.0]; + const channelName = 'dev.fluttercommunity.plus/sensors/user_accel'; + const sensorData = [6.0, 7.0, 8.0]; _initializeFakeSensorChannel(channelName, sensorData); - final UserAccelerometerEvent event = await userAccelerometerEvents.first; + final event = await userAccelerometerEvents.first; expect(event.x, sensorData[0]); expect(event.y, sensorData[1]); @@ -51,7 +51,7 @@ void main() { } void _initializeFakeSensorChannel(String channelName, List sensorData) { - const StandardMethodCodec standardMethod = StandardMethodCodec(); + const standardMethod = StandardMethodCodec(); void _emitEvent(ByteData event) { ServicesBinding.instance.defaultBinaryMessenger.handlePlatformMessage( @@ -63,7 +63,7 @@ void _initializeFakeSensorChannel(String channelName, List sensorData) { ServicesBinding.instance.defaultBinaryMessenger .setMockMessageHandler(channelName, (ByteData message) async { - final MethodCall methodCall = standardMethod.decodeMethodCall(message); + final methodCall = standardMethod.decodeMethodCall(message); if (methodCall.method == 'listen') { _emitEvent(standardMethod.encodeSuccessEnvelope(sensorData)); _emitEvent(null); diff --git a/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart b/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart index 336ccb62e3..889bd293a7 100644 --- a/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart +++ b/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart @@ -25,41 +25,34 @@ class MethodChannelSensors extends SensorsPlatform { /// A broadcast stream of events from the device accelerometer. @override Stream get accelerometerEvents { - if (_accelerometerEvents == null) { - _accelerometerEvents = _accelerometerEventChannel + _accelerometerEvents ??= _accelerometerEventChannel .receiveBroadcastStream() .map((dynamic event) { final list = event.cast(); return AccelerometerEvent(list[0], list[1], list[2]); }); - } return _accelerometerEvents; } /// A broadcast stream of events from the device gyroscope. @override Stream get gyroscopeEvents { - if (_gyroscopeEvents == null) { - _gyroscopeEvents = - _gyroscopeEventChannel.receiveBroadcastStream().map((dynamic event) { + _gyroscopeEvents ??= _gyroscopeEventChannel.receiveBroadcastStream().map((dynamic event) { final list = event.cast(); return GyroscopeEvent(list[0], list[1], list[2]); }); - } return _gyroscopeEvents; } /// Events from the device accelerometer with gravity removed. @override Stream get userAccelerometerEvents { - if (_userAccelerometerEvents == null) { - _userAccelerometerEvents = _userAccelerometerEventChannel + _userAccelerometerEvents ??= _userAccelerometerEventChannel .receiveBroadcastStream() .map((dynamic event) { final list = event.cast(); return UserAccelerometerEvent(list[0], list[1], list[2]); }); - } return _userAccelerometerEvents; } } diff --git a/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart b/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart index f12549a542..a6d2fb53f5 100644 --- a/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart +++ b/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart @@ -31,12 +31,12 @@ void main() { TestWidgetsFlutterBinding.ensureInitialized(); test('$accelerometerEvents are streamed', () async { - const String channelName = + const channelName = 'dev.fluttercommunity.plus/sensors/accelerometer'; - const List sensorData = [1.0, 2.0, 3.0]; + const sensorData = [1.0, 2.0, 3.0]; _initializeFakeSensorChannel(channelName, sensorData); - final AccelerometerEvent event = await accelerometerEvents.first; + final event = await accelerometerEvents.first; expect(event.x, sensorData[0]); expect(event.y, sensorData[1]); @@ -44,8 +44,8 @@ void main() { }); test('$gyroscopeEvents are streamed', () async { - const String channelName = 'dev.fluttercommunity.plus/sensors/gyroscope'; - const List sensorData = [3.0, 4.0, 5.0]; + const channelName = 'dev.fluttercommunity.plus/sensors/gyroscope'; + const sensorData = [3.0, 4.0, 5.0]; _initializeFakeSensorChannel(channelName, sensorData); final event = await gyroscopeEvents.first; @@ -56,11 +56,11 @@ void main() { }); test('$userAccelerometerEvents are streamed', () async { - const String channelName = 'dev.fluttercommunity.plus/sensors/user_accel'; - const List sensorData = [6.0, 7.0, 8.0]; + const channelName = 'dev.fluttercommunity.plus/sensors/user_accel'; + const sensorData = [6.0, 7.0, 8.0]; _initializeFakeSensorChannel(channelName, sensorData); - final UserAccelerometerEvent event = await userAccelerometerEvents.first; + final event = await userAccelerometerEvents.first; expect(event.x, sensorData[0]); expect(event.y, sensorData[1]); @@ -69,7 +69,7 @@ void main() { } void _initializeFakeSensorChannel(String channelName, List sensorData) { - const StandardMethodCodec standardMethod = StandardMethodCodec(); + const standardMethod = StandardMethodCodec(); void _emitEvent(ByteData event) { ServicesBinding.instance.defaultBinaryMessenger.handlePlatformMessage( @@ -81,7 +81,7 @@ void _initializeFakeSensorChannel(String channelName, List sensorData) { ServicesBinding.instance.defaultBinaryMessenger .setMockMessageHandler(channelName, (ByteData message) async { - final MethodCall methodCall = standardMethod.decodeMethodCall(message); + final methodCall = standardMethod.decodeMethodCall(message); if (methodCall.method == 'listen') { _emitEvent(standardMethod.encodeSuccessEnvelope(sensorData)); _emitEvent(null); diff --git a/packages/sensors_plus_web/lib/src/sensors.dart b/packages/sensors_plus_web/lib/src/sensors.dart index 11a40c65b3..dfe7bc7ec3 100644 --- a/packages/sensors_plus_web/lib/src/sensors.dart +++ b/packages/sensors_plus_web/lib/src/sensors.dart @@ -57,7 +57,7 @@ class SensorsPlugin extends SensorsPlatform { _accelerometerStreamController = StreamController(); _featureDetected( () { - final html.Accelerometer _accelerometer = html.Accelerometer(); + final _accelerometer = html.Accelerometer(); setProperty( _accelerometer, @@ -150,7 +150,7 @@ class SensorsPlugin extends SensorsPlatform { StreamController(); _featureDetected( () { - final html.LinearAccelerationSensor _linearAccelerationSensor = + final _linearAccelerationSensor = html.LinearAccelerationSensor(); setProperty( diff --git a/packages/sensors_plus_web/lib/src/utils.dart b/packages/sensors_plus_web/lib/src/utils.dart index bf9f2678ac..2564b00c22 100644 --- a/packages/sensors_plus_web/lib/src/utils.dart +++ b/packages/sensors_plus_web/lib/src/utils.dart @@ -21,20 +21,20 @@ Future checkPremission( } else if (premissionStatus.state == 'prompt') { /// user needs to intract with this print( - "Premission [$premissionName] still has not been granted or denied.", + 'Premission [$premissionName] still has not been granted or denied.', ); } else { /// if permission is denied, do not do anything - print("Permission [$premissionName] to use sensor was denied."); + print('Permission [$premissionName] to use sensor was denied.'); } } catch (e) { print( - "Integration with Permissions API is not enabled, still try to start app.", + 'Integration with Permissions API is not enabled, still try to start app.', ); initSensor(); } } else { - print("No Permissions API, still try to start app."); + print('No Permissions API, still try to start app.'); initSensor(); } } diff --git a/packages/share_plus/example/lib/image_previews.dart b/packages/share_plus/example/lib/image_previews.dart index 51db176b06..28dd87f49d 100644 --- a/packages/share_plus/example/lib/image_previews.dart +++ b/packages/share_plus/example/lib/image_previews.dart @@ -23,7 +23,7 @@ class ImagePreviews extends StatelessWidget { } var imageWidgets = []; - for (int i = 0; i < imagePaths.length; i++) { + for (var i = 0; i < imagePaths.length; i++) { imageWidgets.add(_ImagePreview( imagePaths[i], onDelete: onDelete != null ? () => onDelete(i) : null, @@ -46,7 +46,7 @@ class _ImagePreview extends StatelessWidget { @override Widget build(BuildContext context) { - File imageFile = File(imagePath); + final imageFile = File(imagePath); return Padding( padding: const EdgeInsets.all(8.0), child: Stack( diff --git a/packages/share_plus/example/lib/main.dart b/packages/share_plus/example/lib/main.dart index 6bbc22e5e8..b510370a0d 100644 --- a/packages/share_plus/example/lib/main.dart +++ b/packages/share_plus/example/lib/main.dart @@ -62,7 +62,7 @@ class DemoAppState extends State { ImagePreviews(imagePaths, onDelete: _onDeleteImage), ListTile( leading: Icon(Icons.add), - title: Text("Add image"), + title: Text('Add image'), onTap: () async { final imagePicker = ImagePicker(); final pickedFile = await imagePicker.getImage( @@ -93,13 +93,13 @@ class DemoAppState extends State { ); } - _onDeleteImage(int position) { + void _onDeleteImage(int position) { setState(() { imagePaths.removeAt(position); }); } - _onShare(BuildContext context) async { + void _onShare(BuildContext context) async { // A builder is used to retrieve the context immediately // surrounding the RaisedButton. // diff --git a/packages/share_plus/example/test_driver/share_plus_e2e_test.dart b/packages/share_plus/example/test_driver/share_plus_e2e_test.dart index a6241a7645..8c663fb1db 100644 --- a/packages/share_plus/example/test_driver/share_plus_e2e_test.dart +++ b/packages/share_plus/example/test_driver/share_plus_e2e_test.dart @@ -9,7 +9,7 @@ import 'package:flutter_driver/flutter_driver.dart'; Future main() async { final driver = await FlutterDriver.connect(); - final String data = + final data = await driver.requestData(null, timeout: const Duration(minutes: 1)); await driver.close(); final Map result = jsonDecode(data); diff --git a/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart b/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart index a9e514f845..ba03095640 100644 --- a/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart +++ b/packages/share_plus_platform_interface/lib/method_channel/method_channel_share.dart @@ -27,7 +27,7 @@ class MethodChannelShare extends SharePlatform { }) { assert(text != null); assert(text.isNotEmpty); - final Map params = { + final params = { 'text': text, 'subject': subject, }; diff --git a/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart b/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart index 4ad325d81e..7514249c81 100644 --- a/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart +++ b/packages/share_plus_platform_interface/test/share_plus_platform_interface_test.dart @@ -78,7 +78,7 @@ void main() { test('sharing file sets correct mimeType', () async { final path = 'tempfile-83649a.png'; - final File file = File(path); + final file = File(path); try { file.createSync(); await SharePlatform.instance.shareFiles([path]); @@ -92,8 +92,8 @@ void main() { }); test('sharing file sets passed mimeType', () async { - final String path = 'tempfile-83649a.png'; - final File file = File(path); + final path = 'tempfile-83649a.png'; + final file = File(path); try { file.createSync(); await SharePlatform.instance.shareFiles([path], mimeTypes: ['*/*']); From 097409c2b24b53421d3410ce55489dacf1580e58 Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Thu, 17 Dec 2020 14:52:59 +0100 Subject: [PATCH 06/11] format dart --- .../lib/src/method_channel_battery_plus.dart | 4 +-- .../battery_plus_platform_interface_test.dart | 3 +- .../connectivity_plus/example/lib/main.dart | 6 ++-- .../lib/src/method_channel_connectivity.dart | 6 ++-- .../test/method_channel_device_info_test.dart | 3 +- .../test/package_info_test.dart | 3 +- .../lib/method_channel_package_info.dart | 3 +- .../method_channel_package_info_test.dart | 3 +- .../example/test_driver/sensors_plus_e2e.dart | 3 +- packages/sensors_plus/test/sensors_test.dart | 3 +- .../lib/src/method_channel_sensors.dart | 29 ++++++++++--------- .../sensors_plus_platform_interface_test.dart | 3 +- .../sensors_plus_web/lib/src/sensors.dart | 3 +- 13 files changed, 31 insertions(+), 41 deletions(-) diff --git a/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart b/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart index dc413ccd2d..2861ad95c9 100644 --- a/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart +++ b/packages/battery_plus_platform_interface/lib/src/method_channel_battery_plus.dart @@ -35,8 +35,8 @@ class MethodChannelBattery extends BatteryPlatform { @override Stream get onBatteryStateChanged { _onBatteryStateChanged ??= eventChannel - .receiveBroadcastStream() - .map((dynamic event) => parseBatteryState(event)); + .receiveBroadcastStream() + .map((dynamic event) => parseBatteryState(event)); return _onBatteryStateChanged; } } diff --git a/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart b/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart index 3d6ef6246e..7974695814 100644 --- a/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart +++ b/packages/battery_plus_platform_interface/test/battery_plus_platform_interface_test.dart @@ -44,8 +44,7 @@ void main() { }); test('onBatteryChanged', () async { - final result = - await methodChannelBattery.onBatteryStateChanged.first; + final result = await methodChannelBattery.onBatteryStateChanged.first; expect(result, BatteryState.full); }); diff --git a/packages/connectivity_plus/example/lib/main.dart b/packages/connectivity_plus/example/lib/main.dart index 9c0490fdec..bd5f90df85 100644 --- a/packages/connectivity_plus/example/lib/main.dart +++ b/packages/connectivity_plus/example/lib/main.dart @@ -104,8 +104,7 @@ class _MyHomePageState extends State { try { if (!kIsWeb && Platform.isIOS) { - var status = - await _connectivity.getLocationServiceAuthorization(); + var status = await _connectivity.getLocationServiceAuthorization(); if (status == LocationAuthorizationStatus.notDetermined) { status = await _connectivity.requestLocationServiceAuthorization(); @@ -126,8 +125,7 @@ class _MyHomePageState extends State { try { if (!kIsWeb && Platform.isIOS) { - var status = - await _connectivity.getLocationServiceAuthorization(); + var status = await _connectivity.getLocationServiceAuthorization(); if (status == LocationAuthorizationStatus.notDetermined) { status = await _connectivity.requestLocationServiceAuthorization(); diff --git a/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart b/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart index b95c61d585..002df731e9 100644 --- a/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart +++ b/packages/connectivity_plus_platform_interface/lib/src/method_channel_connectivity.dart @@ -28,9 +28,9 @@ class MethodChannelConnectivity extends ConnectivityPlatform { @override Stream get onConnectivityChanged { _onConnectivityChanged ??= eventChannel - .receiveBroadcastStream() - .map((dynamic result) => result.toString()) - .map(parseConnectivityResult); + .receiveBroadcastStream() + .map((dynamic result) => result.toString()) + .map(parseConnectivityResult); return _onConnectivityChanged; } diff --git a/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart b/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart index d8aacc97d4..6eff240480 100644 --- a/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart +++ b/packages/device_info_plus_platform_interface/test/method_channel_device_info_test.dart @@ -34,8 +34,7 @@ void main() { }); test('androidInfo', () async { - final result = - await methodChannelDeviceInfo.androidInfo(); + final result = await methodChannelDeviceInfo.androidInfo(); expect(result.brand, 'Google'); }); diff --git a/packages/package_info_plus/test/package_info_test.dart b/packages/package_info_plus/test/package_info_test.dart index 3184e860b3..265887f760 100644 --- a/packages/package_info_plus/test/package_info_test.dart +++ b/packages/package_info_plus/test/package_info_test.dart @@ -9,8 +9,7 @@ import 'package:package_info_plus/package_info_plus.dart'; void main() { TestWidgetsFlutterBinding.ensureInitialized(); - const channel = - MethodChannel('dev.fluttercommunity.plus/package_info'); + const channel = MethodChannel('dev.fluttercommunity.plus/package_info'); List log; channel.setMockMethodCallHandler((MethodCall methodCall) async { diff --git a/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart b/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart index 8672938827..ddf59fa190 100644 --- a/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart +++ b/packages/package_info_plus_platform_interface/lib/method_channel_package_info.dart @@ -10,8 +10,7 @@ const MethodChannel _channel = class MethodChannelPackageInfo extends PackageInfoPlatform { @override Future getAll() async { - final map = - await _channel.invokeMapMethod('getAll'); + final map = await _channel.invokeMapMethod('getAll'); return PackageInfoData( appName: map['appName'], packageName: map['packageName'], diff --git a/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart b/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart index 9ef4e6fe4c..f3e5749dbf 100644 --- a/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart +++ b/packages/package_info_plus_platform_interface/test/method_channel_package_info_test.dart @@ -35,8 +35,7 @@ void main() { }); group('$MethodChannelPackageInfo()', () { - const channel = - MethodChannel('dev.fluttercommunity.plus/package_info'); + const channel = MethodChannel('dev.fluttercommunity.plus/package_info'); final log = []; channel.setMockMethodCallHandler((MethodCall methodCall) async { log.add(methodCall); diff --git a/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart b/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart index 975653af06..e0933ef884 100644 --- a/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart +++ b/packages/sensors_plus/example/test_driver/sensors_plus_e2e.dart @@ -12,8 +12,7 @@ void main() { testWidgets('Can subscript to accelerometerEvents and get non-null events', (WidgetTester tester) async { - final completer = - Completer(); + final completer = Completer(); StreamSubscription subscription; subscription = accelerometerEvents.listen((AccelerometerEvent event) { completer.complete(event); diff --git a/packages/sensors_plus/test/sensors_test.dart b/packages/sensors_plus/test/sensors_test.dart index d60d35486c..e8b07cf3e1 100644 --- a/packages/sensors_plus/test/sensors_test.dart +++ b/packages/sensors_plus/test/sensors_test.dart @@ -13,8 +13,7 @@ void main() { TestWidgetsFlutterBinding.ensureInitialized(); test('$accelerometerEvents are streamed', () async { - const channelName = - 'dev.fluttercommunity.plus/sensors/accelerometer'; + const channelName = 'dev.fluttercommunity.plus/sensors/accelerometer'; const sensorData = [1.0, 2.0, 3.0]; _initializeFakeSensorChannel(channelName, sensorData); diff --git a/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart b/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart index 889bd293a7..7d8c53d6a5 100644 --- a/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart +++ b/packages/sensors_plus_platform_interface/lib/src/method_channel_sensors.dart @@ -26,21 +26,22 @@ class MethodChannelSensors extends SensorsPlatform { @override Stream get accelerometerEvents { _accelerometerEvents ??= _accelerometerEventChannel - .receiveBroadcastStream() - .map((dynamic event) { - final list = event.cast(); - return AccelerometerEvent(list[0], list[1], list[2]); - }); + .receiveBroadcastStream() + .map((dynamic event) { + final list = event.cast(); + return AccelerometerEvent(list[0], list[1], list[2]); + }); return _accelerometerEvents; } /// A broadcast stream of events from the device gyroscope. @override Stream get gyroscopeEvents { - _gyroscopeEvents ??= _gyroscopeEventChannel.receiveBroadcastStream().map((dynamic event) { - final list = event.cast(); - return GyroscopeEvent(list[0], list[1], list[2]); - }); + _gyroscopeEvents ??= + _gyroscopeEventChannel.receiveBroadcastStream().map((dynamic event) { + final list = event.cast(); + return GyroscopeEvent(list[0], list[1], list[2]); + }); return _gyroscopeEvents; } @@ -48,11 +49,11 @@ class MethodChannelSensors extends SensorsPlatform { @override Stream get userAccelerometerEvents { _userAccelerometerEvents ??= _userAccelerometerEventChannel - .receiveBroadcastStream() - .map((dynamic event) { - final list = event.cast(); - return UserAccelerometerEvent(list[0], list[1], list[2]); - }); + .receiveBroadcastStream() + .map((dynamic event) { + final list = event.cast(); + return UserAccelerometerEvent(list[0], list[1], list[2]); + }); return _userAccelerometerEvents; } } diff --git a/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart b/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart index a6d2fb53f5..08814e6d81 100644 --- a/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart +++ b/packages/sensors_plus_platform_interface/test/sensors_plus_platform_interface_test.dart @@ -31,8 +31,7 @@ void main() { TestWidgetsFlutterBinding.ensureInitialized(); test('$accelerometerEvents are streamed', () async { - const channelName = - 'dev.fluttercommunity.plus/sensors/accelerometer'; + const channelName = 'dev.fluttercommunity.plus/sensors/accelerometer'; const sensorData = [1.0, 2.0, 3.0]; _initializeFakeSensorChannel(channelName, sensorData); diff --git a/packages/sensors_plus_web/lib/src/sensors.dart b/packages/sensors_plus_web/lib/src/sensors.dart index dfe7bc7ec3..8c5658f4ec 100644 --- a/packages/sensors_plus_web/lib/src/sensors.dart +++ b/packages/sensors_plus_web/lib/src/sensors.dart @@ -150,8 +150,7 @@ class SensorsPlugin extends SensorsPlatform { StreamController(); _featureDetected( () { - final _linearAccelerationSensor = - html.LinearAccelerationSensor(); + final _linearAccelerationSensor = html.LinearAccelerationSensor(); setProperty( _linearAccelerationSensor, From 9fe883af1063092ca612f8aeb621690ee1ee938a Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Thu, 17 Dec 2020 15:03:59 +0100 Subject: [PATCH 07/11] analysis options for example projects --- .../android_alarm_manager_plus/example/analysis_options.yaml | 1 + packages/android_intent_plus/example/analysis_options.yaml | 1 + packages/battery_plus/example/analysis_options.yaml | 1 + packages/battery_plus/example/pubspec.yaml | 2 +- packages/connectivity_plus/example/analysis_options.yaml | 1 + packages/connectivity_plus/example/pubspec.yaml | 2 +- packages/device_info_plus/example/analysis_options.yaml | 1 + packages/device_info_plus/example/pubspec.yaml | 2 +- packages/package_info_plus/example/analysis_options.yaml | 1 + packages/package_info_plus/example/pubspec.yaml | 2 +- packages/sensors_plus/example/analysis_options.yaml | 1 + packages/sensors_plus/example/pubspec.yaml | 2 +- packages/share_plus/example/analysis_options.yaml | 1 + packages/share_plus/example/pubspec.yaml | 2 +- 14 files changed, 14 insertions(+), 6 deletions(-) create mode 100644 packages/android_alarm_manager_plus/example/analysis_options.yaml create mode 100644 packages/android_intent_plus/example/analysis_options.yaml create mode 100644 packages/battery_plus/example/analysis_options.yaml create mode 100644 packages/connectivity_plus/example/analysis_options.yaml create mode 100644 packages/device_info_plus/example/analysis_options.yaml create mode 100644 packages/package_info_plus/example/analysis_options.yaml create mode 100644 packages/sensors_plus/example/analysis_options.yaml create mode 100644 packages/share_plus/example/analysis_options.yaml diff --git a/packages/android_alarm_manager_plus/example/analysis_options.yaml b/packages/android_alarm_manager_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/android_alarm_manager_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/android_intent_plus/example/analysis_options.yaml b/packages/android_intent_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/android_intent_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/battery_plus/example/analysis_options.yaml b/packages/battery_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/battery_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/battery_plus/example/pubspec.yaml b/packages/battery_plus/example/pubspec.yaml index f71f7ef961..1bda9f4ccc 100644 --- a/packages/battery_plus/example/pubspec.yaml +++ b/packages/battery_plus/example/pubspec.yaml @@ -15,7 +15,7 @@ dev_dependencies: flutter_driver: sdk: flutter integration_test: ^0.9.1 - pedantic: ^1.9.0 + pedantic: ^1.9.2 flutter: uses-material-design: true diff --git a/packages/connectivity_plus/example/analysis_options.yaml b/packages/connectivity_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/connectivity_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/connectivity_plus/example/pubspec.yaml b/packages/connectivity_plus/example/pubspec.yaml index 3fd6f68a89..03ddb09783 100644 --- a/packages/connectivity_plus/example/pubspec.yaml +++ b/packages/connectivity_plus/example/pubspec.yaml @@ -12,7 +12,7 @@ dev_dependencies: sdk: flutter test: any integration_test: ^0.9.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 flutter: uses-material-design: true diff --git a/packages/device_info_plus/example/analysis_options.yaml b/packages/device_info_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/device_info_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/device_info_plus/example/pubspec.yaml b/packages/device_info_plus/example/pubspec.yaml index e0cdaa0bb4..9abc1c7594 100644 --- a/packages/device_info_plus/example/pubspec.yaml +++ b/packages/device_info_plus/example/pubspec.yaml @@ -11,7 +11,7 @@ dev_dependencies: flutter_driver: sdk: flutter integration_test: ^0.9.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 flutter: uses-material-design: true diff --git a/packages/package_info_plus/example/analysis_options.yaml b/packages/package_info_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/package_info_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/package_info_plus/example/pubspec.yaml b/packages/package_info_plus/example/pubspec.yaml index b5a3e542a7..7287df5f38 100644 --- a/packages/package_info_plus/example/pubspec.yaml +++ b/packages/package_info_plus/example/pubspec.yaml @@ -18,7 +18,7 @@ dev_dependencies: flutter_driver: sdk: flutter test: any - pedantic: ^1.8.0 + pedantic: ^1.9.2 flutter: uses-material-design: true diff --git a/packages/sensors_plus/example/analysis_options.yaml b/packages/sensors_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/sensors_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/sensors_plus/example/pubspec.yaml b/packages/sensors_plus/example/pubspec.yaml index c76714ddbf..105a8c4d5b 100644 --- a/packages/sensors_plus/example/pubspec.yaml +++ b/packages/sensors_plus/example/pubspec.yaml @@ -11,7 +11,7 @@ dev_dependencies: flutter_driver: sdk: flutter integration_test: ^0.9.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 flutter: uses-material-design: true diff --git a/packages/share_plus/example/analysis_options.yaml b/packages/share_plus/example/analysis_options.yaml new file mode 100644 index 0000000000..e2badd73ea --- /dev/null +++ b/packages/share_plus/example/analysis_options.yaml @@ -0,0 +1 @@ +include: ../../../analysis_options.yaml diff --git a/packages/share_plus/example/pubspec.yaml b/packages/share_plus/example/pubspec.yaml index dcc8327a80..5ca83d08a4 100644 --- a/packages/share_plus/example/pubspec.yaml +++ b/packages/share_plus/example/pubspec.yaml @@ -12,7 +12,7 @@ dev_dependencies: flutter_driver: sdk: flutter integration_test: ^0.9.1 - pedantic: ^1.8.0 + pedantic: ^1.9.2 flutter: uses-material-design: true From 841b5fc164fda986ff9cd7b39b518c886c3fef90 Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Fri, 18 Dec 2020 10:12:51 +0100 Subject: [PATCH 08/11] single analysis options yaml file --- analysis_options.yaml | 8 +++++++- packages/android_alarm_manager_plus/analysis_options.yaml | 1 - .../example/analysis_options.yaml | 1 - packages/android_intent_plus/analysis_options.yaml | 1 - .../android_intent_plus/example/analysis_options.yaml | 1 - packages/battery_plus/analysis_options.yaml | 1 - packages/battery_plus/example/analysis_options.yaml | 1 - packages/battery_plus_linux/analysis_options.yaml | 1 - .../battery_plus_platform_interface/analysis_options.yaml | 1 - packages/battery_plus_web/analysis_options.yaml | 1 - packages/connectivity_plus/analysis_options.yaml | 1 - packages/connectivity_plus/example/analysis_options.yaml | 1 - packages/connectivity_plus_linux/analysis_options.yaml | 1 - .../analysis_options.yaml | 1 - packages/connectivity_plus_web/analysis_options.yaml | 1 - packages/device_info_plus/analysis_options.yaml | 1 - packages/device_info_plus/example/analysis_options.yaml | 1 - packages/device_info_plus_linux/analysis_options.yaml | 1 - .../analysis_options.yaml | 1 - packages/device_info_plus_web/analysis_options.yaml | 1 - packages/package_info_plus/analysis_options.yaml | 1 - packages/package_info_plus_linux/analysis_options.yaml | 1 - .../analysis_options.yaml | 1 - packages/package_info_plus_web/analysis_options.yaml | 1 - packages/package_info_plus_windows/analysis_options.yaml | 1 - packages/sensors_plus/analysis_options.yaml | 1 - packages/sensors_plus/example/analysis_options.yaml | 1 - .../sensors_plus_platform_interface/analysis_options.yaml | 1 - packages/sensors_plus_web/analysis_options.yaml | 1 - packages/share_plus/analysis_options.yaml | 1 - packages/share_plus/example/analysis_options.yaml | 1 - packages/share_plus_linux/analysis_options.yaml | 1 - .../share_plus_platform_interface/analysis_options.yaml | 1 - packages/share_plus_web/analysis_options.yaml | 1 - packages/share_plus_windows/analysis_options.yaml | 1 - 35 files changed, 7 insertions(+), 35 deletions(-) delete mode 100644 packages/android_alarm_manager_plus/analysis_options.yaml delete mode 100644 packages/android_alarm_manager_plus/example/analysis_options.yaml delete mode 100644 packages/android_intent_plus/analysis_options.yaml delete mode 100644 packages/android_intent_plus/example/analysis_options.yaml delete mode 100644 packages/battery_plus/analysis_options.yaml delete mode 100644 packages/battery_plus/example/analysis_options.yaml delete mode 100644 packages/battery_plus_linux/analysis_options.yaml delete mode 100644 packages/battery_plus_platform_interface/analysis_options.yaml delete mode 100644 packages/battery_plus_web/analysis_options.yaml delete mode 100644 packages/connectivity_plus/analysis_options.yaml delete mode 100644 packages/connectivity_plus/example/analysis_options.yaml delete mode 100644 packages/connectivity_plus_linux/analysis_options.yaml delete mode 100644 packages/connectivity_plus_platform_interface/analysis_options.yaml delete mode 100644 packages/connectivity_plus_web/analysis_options.yaml delete mode 100644 packages/device_info_plus/analysis_options.yaml delete mode 100644 packages/device_info_plus/example/analysis_options.yaml delete mode 100644 packages/device_info_plus_linux/analysis_options.yaml delete mode 100644 packages/device_info_plus_platform_interface/analysis_options.yaml delete mode 100644 packages/device_info_plus_web/analysis_options.yaml delete mode 100644 packages/package_info_plus/analysis_options.yaml delete mode 100644 packages/package_info_plus_linux/analysis_options.yaml delete mode 100644 packages/package_info_plus_platform_interface/analysis_options.yaml delete mode 100644 packages/package_info_plus_web/analysis_options.yaml delete mode 100644 packages/package_info_plus_windows/analysis_options.yaml delete mode 100644 packages/sensors_plus/analysis_options.yaml delete mode 100644 packages/sensors_plus/example/analysis_options.yaml delete mode 100644 packages/sensors_plus_platform_interface/analysis_options.yaml delete mode 100644 packages/sensors_plus_web/analysis_options.yaml delete mode 100644 packages/share_plus/analysis_options.yaml delete mode 100644 packages/share_plus/example/analysis_options.yaml delete mode 100644 packages/share_plus_linux/analysis_options.yaml delete mode 100644 packages/share_plus_platform_interface/analysis_options.yaml delete mode 100644 packages/share_plus_web/analysis_options.yaml delete mode 100644 packages/share_plus_windows/analysis_options.yaml diff --git a/analysis_options.yaml b/analysis_options.yaml index 5fdfa9bdf6..6212c8f4bc 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,3 +1,9 @@ +# This is the default analysis_options.yaml for all packages and examples +# If a package needs specific rules, create the analysis_options.yaml on it +# include this file, like: +# +# include: ../../analysis_options.yaml +# include: package:pedantic/analysis_options.1.9.0.yaml analyzer: @@ -8,4 +14,4 @@ analyzer: linter: rules: - - public_member_api_docs + public_member_api_docs: true diff --git a/packages/android_alarm_manager_plus/analysis_options.yaml b/packages/android_alarm_manager_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/android_alarm_manager_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/android_alarm_manager_plus/example/analysis_options.yaml b/packages/android_alarm_manager_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/android_alarm_manager_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/android_intent_plus/analysis_options.yaml b/packages/android_intent_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/android_intent_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/android_intent_plus/example/analysis_options.yaml b/packages/android_intent_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/android_intent_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/battery_plus/analysis_options.yaml b/packages/battery_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/battery_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/battery_plus/example/analysis_options.yaml b/packages/battery_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/battery_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/battery_plus_linux/analysis_options.yaml b/packages/battery_plus_linux/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/battery_plus_linux/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/battery_plus_platform_interface/analysis_options.yaml b/packages/battery_plus_platform_interface/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/battery_plus_platform_interface/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/battery_plus_web/analysis_options.yaml b/packages/battery_plus_web/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/battery_plus_web/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus/analysis_options.yaml b/packages/connectivity_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/connectivity_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus/example/analysis_options.yaml b/packages/connectivity_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/connectivity_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/connectivity_plus_linux/analysis_options.yaml b/packages/connectivity_plus_linux/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/connectivity_plus_linux/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus_platform_interface/analysis_options.yaml b/packages/connectivity_plus_platform_interface/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/connectivity_plus_platform_interface/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/connectivity_plus_web/analysis_options.yaml b/packages/connectivity_plus_web/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/connectivity_plus_web/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/device_info_plus/analysis_options.yaml b/packages/device_info_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/device_info_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/device_info_plus/example/analysis_options.yaml b/packages/device_info_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/device_info_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/device_info_plus_linux/analysis_options.yaml b/packages/device_info_plus_linux/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/device_info_plus_linux/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/device_info_plus_platform_interface/analysis_options.yaml b/packages/device_info_plus_platform_interface/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/device_info_plus_platform_interface/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/device_info_plus_web/analysis_options.yaml b/packages/device_info_plus_web/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/device_info_plus_web/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/package_info_plus/analysis_options.yaml b/packages/package_info_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/package_info_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_linux/analysis_options.yaml b/packages/package_info_plus_linux/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/package_info_plus_linux/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_platform_interface/analysis_options.yaml b/packages/package_info_plus_platform_interface/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/package_info_plus_platform_interface/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_web/analysis_options.yaml b/packages/package_info_plus_web/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/package_info_plus_web/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/package_info_plus_windows/analysis_options.yaml b/packages/package_info_plus_windows/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/package_info_plus_windows/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/sensors_plus/analysis_options.yaml b/packages/sensors_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/sensors_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/sensors_plus/example/analysis_options.yaml b/packages/sensors_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/sensors_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/sensors_plus_platform_interface/analysis_options.yaml b/packages/sensors_plus_platform_interface/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/sensors_plus_platform_interface/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/sensors_plus_web/analysis_options.yaml b/packages/sensors_plus_web/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/sensors_plus_web/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/share_plus/analysis_options.yaml b/packages/share_plus/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/share_plus/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/share_plus/example/analysis_options.yaml b/packages/share_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/share_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/share_plus_linux/analysis_options.yaml b/packages/share_plus_linux/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/share_plus_linux/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/share_plus_platform_interface/analysis_options.yaml b/packages/share_plus_platform_interface/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/share_plus_platform_interface/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/share_plus_web/analysis_options.yaml b/packages/share_plus_web/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/share_plus_web/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml diff --git a/packages/share_plus_windows/analysis_options.yaml b/packages/share_plus_windows/analysis_options.yaml deleted file mode 100644 index f04c6cf0f3..0000000000 --- a/packages/share_plus_windows/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../analysis_options.yaml From 478a72ff61f3226c42f737071fb117e97e8d0b09 Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Fri, 18 Dec 2020 10:50:36 +0100 Subject: [PATCH 09/11] fixed var that could be final, added lint rules for that --- analysis_options.yaml | 2 ++ packages/android_alarm_manager_plus/example/lib/main.dart | 2 +- .../test_driver/android_alarm_manager_plus_e2e_test.dart | 2 +- packages/battery_plus/example/pubspec.yaml | 1 - .../battery_plus_linux/lib/src/battery_plus_linux_real.dart | 1 + packages/connectivity_plus_web/test/lib/main.dart | 2 +- packages/package_info_plus/example/analysis_options.yaml | 1 - packages/package_info_plus_web/lib/package_info_plus_web.dart | 2 +- packages/sensors_plus/example/lib/main.dart | 2 +- packages/sensors_plus/example/lib/snake.dart | 2 +- packages/share_plus/example/lib/image_previews.dart | 2 +- 11 files changed, 10 insertions(+), 9 deletions(-) delete mode 100644 packages/package_info_plus/example/analysis_options.yaml diff --git a/analysis_options.yaml b/analysis_options.yaml index 6212c8f4bc..9bf6ea9b10 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -15,3 +15,5 @@ analyzer: linter: rules: public_member_api_docs: true + prefer_final_in_for_each: true + prefer_final_locals: true diff --git a/packages/android_alarm_manager_plus/example/lib/main.dart b/packages/android_alarm_manager_plus/example/lib/main.dart index 3b9e4542a2..8920736391 100644 --- a/packages/android_alarm_manager_plus/example/lib/main.dart +++ b/packages/android_alarm_manager_plus/example/lib/main.dart @@ -94,7 +94,7 @@ class _AlarmHomePageState extends State<_AlarmHomePage> { // Get the previous cached count and increment it. final prefs = await SharedPreferences.getInstance(); - var currentCount = prefs.getInt(countKey); + final currentCount = prefs.getInt(countKey); await prefs.setInt(countKey, currentCount + 1); // This will be null if we're running in the background. diff --git a/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e_test.dart b/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e_test.dart index 8373a3afd1..7fe1e5d061 100644 --- a/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e_test.dart +++ b/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e_test.dart @@ -12,7 +12,7 @@ Future> resumeIsolatesOnPause( FlutterDriver driver) async { final vm = await driver.serviceClient.getVM(); print('for isolates'); - for (var isolateRef in vm.isolates) { + for (final isolateRef in vm.isolates) { final isolate = await isolateRef.load(); if (isolate.isPaused) { print('isolate.resume'); diff --git a/packages/battery_plus/example/pubspec.yaml b/packages/battery_plus/example/pubspec.yaml index 1bda9f4ccc..2a811d6941 100644 --- a/packages/battery_plus/example/pubspec.yaml +++ b/packages/battery_plus/example/pubspec.yaml @@ -1,6 +1,5 @@ name: battery_plus_example description: Demonstrates how to use the battery_plus plugin. -version: 1.0.0+1 environment: sdk: ">=2.7.0 <3.0.0" diff --git a/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart b/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart index 4e71994957..98aa296c36 100644 --- a/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart +++ b/packages/battery_plus_linux/lib/src/battery_plus_linux_real.dart @@ -20,6 +20,7 @@ extension _ToBatteryState on UPowerBatteryState { } } +/// @visibleForTesting typedef UPowerDeviceFactory = UPowerDevice Function(); diff --git a/packages/connectivity_plus_web/test/lib/main.dart b/packages/connectivity_plus_web/test/lib/main.dart index d3aabdec4e..203d2ae626 100644 --- a/packages/connectivity_plus_web/test/lib/main.dart +++ b/packages/connectivity_plus_web/test/lib/main.dart @@ -24,7 +24,7 @@ void main() { when(connection.downlink).thenReturn(downlink); when(connection.rtt).thenReturn(downlink); - var plugin = + final plugin = NetworkInformationApiConnectivityPlugin.withConnection(connection); expect(plugin.checkConnectivity(), completion(equals(expected))); } diff --git a/packages/package_info_plus/example/analysis_options.yaml b/packages/package_info_plus/example/analysis_options.yaml deleted file mode 100644 index e2badd73ea..0000000000 --- a/packages/package_info_plus/example/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../../../analysis_options.yaml diff --git a/packages/package_info_plus_web/lib/package_info_plus_web.dart b/packages/package_info_plus_web/lib/package_info_plus_web.dart index 74dd794ef9..ad0e85cc6f 100644 --- a/packages/package_info_plus_web/lib/package_info_plus_web.dart +++ b/packages/package_info_plus_web/lib/package_info_plus_web.dart @@ -17,7 +17,7 @@ class PackageInfoPlugin extends PackageInfoPlatform { @override Future getAll() async { - var url = + final url = '${Uri.parse(window.document.baseUri).removeFragment()}/version.json'; final response = await get(url); diff --git a/packages/sensors_plus/example/lib/main.dart b/packages/sensors_plus/example/lib/main.dart index 7cea4d5c7e..6b46fd9bd0 100644 --- a/packages/sensors_plus/example/lib/main.dart +++ b/packages/sensors_plus/example/lib/main.dart @@ -114,7 +114,7 @@ class _MyHomePageState extends State { @override void dispose() { super.dispose(); - for (var subscription in _streamSubscriptions) { + for (final subscription in _streamSubscriptions) { subscription.cancel(); } } diff --git a/packages/sensors_plus/example/lib/snake.dart b/packages/sensors_plus/example/lib/snake.dart index b21bfa0f15..4616e8146d 100644 --- a/packages/sensors_plus/example/lib/snake.dart +++ b/packages/sensors_plus/example/lib/snake.dart @@ -41,7 +41,7 @@ class SnakeBoardPainter extends CustomPainter { Rect.fromPoints(Offset.zero, size.bottomLeft(Offset.zero)), blackLine, ); - for (var p in state.body) { + for (final p in state.body) { final a = Offset(cellSize * p.x, cellSize * p.y); final b = Offset(cellSize * (p.x + 1), cellSize * (p.y + 1)); diff --git a/packages/share_plus/example/lib/image_previews.dart b/packages/share_plus/example/lib/image_previews.dart index 28dd87f49d..c7e8729c2d 100644 --- a/packages/share_plus/example/lib/image_previews.dart +++ b/packages/share_plus/example/lib/image_previews.dart @@ -22,7 +22,7 @@ class ImagePreviews extends StatelessWidget { return Container(); } - var imageWidgets = []; + final imageWidgets = []; for (var i = 0; i < imagePaths.length; i++) { imageWidgets.add(_ImagePreview( imagePaths[i], From 55692ef41c8ce3679527abd6e61f300d6e3915ea Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Fri, 18 Dec 2020 10:54:45 +0100 Subject: [PATCH 10/11] fixed versioning issue --- packages/connectivity_plus/CHANGELOG.md | 4 ++++ packages/connectivity_plus/pubspec.yaml | 4 ++-- packages/connectivity_plus_linux/CHANGELOG.md | 4 ++++ packages/connectivity_plus_linux/pubspec.yaml | 4 ++-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/packages/connectivity_plus/CHANGELOG.md b/packages/connectivity_plus/CHANGELOG.md index 3e07c83789..c0dae836e1 100644 --- a/packages/connectivity_plus/CHANGELOG.md +++ b/packages/connectivity_plus/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.7.1 + +- Bump linux version. + ## 0.7.0 - Add Linux support (`connectivity_plus_linux`). diff --git a/packages/connectivity_plus/pubspec.yaml b/packages/connectivity_plus/pubspec.yaml index c4a2caf31e..561b762ff0 100644 --- a/packages/connectivity_plus/pubspec.yaml +++ b/packages/connectivity_plus/pubspec.yaml @@ -1,6 +1,6 @@ name: connectivity_plus description: Flutter plugin for discovering the state of the network (WiFi & mobile/cellular) connectivity on Android and iOS. -version: 0.7.0 +version: 0.7.1 homepage: https://plus.fluttercommunity.dev/ repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/ @@ -24,7 +24,7 @@ dependencies: sdk: flutter meta: ^1.0.5 connectivity_plus_platform_interface: ^0.3.0 - connectivity_plus_linux: ^0.1.0 + connectivity_plus_linux: ^0.2.0 connectivity_plus_macos: ^0.3.0 connectivity_plus_web: ^0.5.0 diff --git a/packages/connectivity_plus_linux/CHANGELOG.md b/packages/connectivity_plus_linux/CHANGELOG.md index f7950bb58c..e3f4c0ee67 100644 --- a/packages/connectivity_plus_linux/CHANGELOG.md +++ b/packages/connectivity_plus_linux/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.2.0 + +* Upgrade to latest platform interface + ## 0.1.0 * Initial release for Linux. diff --git a/packages/connectivity_plus_linux/pubspec.yaml b/packages/connectivity_plus_linux/pubspec.yaml index eb9f41e02b..7345aaf866 100644 --- a/packages/connectivity_plus_linux/pubspec.yaml +++ b/packages/connectivity_plus_linux/pubspec.yaml @@ -2,7 +2,7 @@ name: connectivity_plus_linux description: Linux implementation of the connectivity_plus plugin homepage: https://plus.fluttercommunity.dev/ repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/ -version: 0.1.0 +version: 0.2.0 environment: sdk: ">=2.7.0 <3.0.0" @@ -11,7 +11,7 @@ environment: dependencies: flutter: sdk: flutter - connectivity_plus_platform_interface: ^0.2.0 + connectivity_plus_platform_interface: ^0.3.0 dbus: ^0.1.0 meta: ^1.2.3 From 0d8bca35cafb4f0998f57db336399f4aa0d46347 Mon Sep 17 00:00:00 2001 From: Miguel Beltran Date: Fri, 18 Dec 2020 11:01:21 +0100 Subject: [PATCH 11/11] unify sdk version on projects --- packages/connectivity_plus/example/pubspec.yaml | 3 +++ packages/device_info_plus/example/pubspec.yaml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/connectivity_plus/example/pubspec.yaml b/packages/connectivity_plus/example/pubspec.yaml index 03ddb09783..d6a005c7a9 100644 --- a/packages/connectivity_plus/example/pubspec.yaml +++ b/packages/connectivity_plus/example/pubspec.yaml @@ -1,6 +1,9 @@ name: connectivity_plus_example description: Demonstrates how to use the connectivity_plus plugin. +environment: + sdk: ">=2.7.0 <3.0.0" + dependencies: flutter: sdk: flutter diff --git a/packages/device_info_plus/example/pubspec.yaml b/packages/device_info_plus/example/pubspec.yaml index 9abc1c7594..428ee8eb89 100644 --- a/packages/device_info_plus/example/pubspec.yaml +++ b/packages/device_info_plus/example/pubspec.yaml @@ -17,4 +17,4 @@ flutter: uses-material-design: true environment: - sdk: '>=2.10.0 <3.0.0' + sdk: '>=2.7.0 <3.0.0'