From 5deed63a7cdf0ca67c405022978bc28bc19a9fce Mon Sep 17 00:00:00 2001 From: ColdPaleLight Date: Thu, 30 Dec 2021 14:10:45 +0800 Subject: [PATCH] Ensure that the engine is destroyed when 'EngineBindings.detach' in the multiple_flutters example on Android --- .../main/java/dev/flutter/multipleflutters/EngineBindings.kt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt b/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt index 6c0ac0d17a3..5c5003f6837 100644 --- a/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt +++ b/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt @@ -74,8 +74,7 @@ class EngineBindings(activity: Activity, delegate: EngineBindingsDelegate, entry * This tears down the messaging connections on the platform channel and the DataModel. */ fun detach() { - // TODO: Uncomment after https://github.com/flutter/engine/pull/24644 is on stable. - // engine.destroy(); + engine.destroy(); DataModel.instance.removeObserver(this) channel.setMethodCallHandler(null) }