Skip to content

Commit be28a34

Browse files
committed
added missing FlutterEngine.destroy as a comment
1 parent 3aeb60e commit be28a34

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/DoubleFlutterActivity.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,14 @@ class DoubleFlutterActivity : FragmentActivity(), EngineBindingsDelegate {
6464
}
6565

6666
override fun onDestroy() {
67-
topBindings.detach()
68-
topBindings.detach()
69-
7067
for (i in 0 until numberOfFlutters) {
7168
FlutterEngineCache.getInstance().remove(i.toString())
7269
}
7370

7471
super.onDestroy()
72+
73+
bottomBindings.detach()
74+
topBindings.detach()
7575
}
7676

7777
override fun onNext() {

add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ class EngineBindings(activity: Activity, delegate: EngineBindingsDelegate, entry
7474
* This tears down the messaging connections on the platform channel and the DataModel.
7575
*/
7676
fun detach() {
77+
// TODO: Uncomment after https://github.com/flutter/engine/pull/24644 is on stable.
78+
// engine.destroy();
7779
DataModel.instance.removeObserver(this)
7880
channel.setMethodCallHandler(null)
7981
}

0 commit comments

Comments
 (0)