-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[webview_flutter] Added Android implementation of PlatformWebViewController #6674
[webview_flutter] Added Android implementation of PlatformWebViewController #6674
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but with the caveat that as I mentioned I'm not immersed in this code so I would likely not catch subtle errors (e.g., around the weak handling, or proxying). @bparrishMines should ideally take a look, but if he isn't able to review soon we can land it to unblock the next steps, and he can do a post-landing review for any follow-up since presumably issue would be internal details, not API-level.
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/test/v4/android_webview_controller_test.dart
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/test/v4/android_webview_controller_test.dart
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/v4/src/android_webview_controller.dart
Outdated
Show resolved
Hide resolved
bparrishMines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stuartmorgan this and other PRs are getting the error:
❗ Failed to stop: Error getting access token for service account: 400 Bad Request
POST https://oauth2.googleapis.com/token
{"error":"invalid_grant","error_description":"Invalid JWT Signature."}, iss: [[email protected]](mailto:[email protected])
Could this be caused by this PR being merge to a branch that isn't main?
|
It looks like pulling in the latest changes from the main branch into v4_webview fixes these test errors: #6713. Could you review this PR? |
|
That was probably due to a credential rotation. |
…droid_webview_controller
|
@mvanbeusekom It looks like this PR still had some failing analysis errors. Can you fix them in your next PR? |
Sorry about that, completely missed it. PR #6732 should fix this. |
Adds the Android implementation of the
PlatformWebViewControllerto the v4 Android implementation.Part of issue flutter/flutter#94051
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).