This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] add getDirectoryPaths implementation on Linux #6573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
from
fe75c5d to
d2864db
Compare
This was referenced Oct 14, 2022
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
from
d2864db to
667f525
Compare
stuartmorgan-g
suggested changes
Oct 17, 2022
packages/file_selector/file_selector_linux/lib/file_selector_linux.dart
Outdated
Show resolved
Hide resolved
packages/file_selector/file_selector_linux/linux/file_selector_plugin.cc
Outdated
Show resolved
Hide resolved
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
3 times, most recently
from
0cf7ba6 to
fe8c0e5
Compare
Contributor
Author
|
Changes applied, thanks |
VanesaOshiro
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
from
fe8c0e5 to
5b904ba
Compare
adpinola
changed the title
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
2 times, most recently
from
898579f to
be33cb1
Compare
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
from
be33cb1 to
12039d1
Compare
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
3 times, most recently
from
e677837 to
bb55a74
Compare
11 tasks
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
6 times, most recently
from
35a3574 to
387d68e
Compare
packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart
Outdated
Show resolved
Hide resolved
Add getDirectoriesPaths to method channel. Increment version to 2.3.0 apply feedback extract assertion method
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
from
387d68e to
332d8dc
Compare
adpinola
force-pushed
the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
from
332d8dc to
ae9ab80
Compare
Contributor
|
What's the state of this PR? Is it ready for re-review? |
Contributor
Author
Yes, it is. |
stuartmorgan-g
approved these changes
Jan 9, 2023
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM
@cbracken for second review.
cbracken
approved these changes
Jan 20, 2023
| @@ -0,0 +1,2 @@ | |||
| CMakeCache.txt | |||
| CMakeFiles/ No newline at end of file | |||
Member
There was a problem hiding this comment.
Extremely pedantic nitpick: add a trailing newline. :)
Contributor
|
I'm going to land this as-is so we're not doing a new test run just for the newline; if we ever need to touch that file again we can always add the missing newline then. |
Contributor
|
|
adpinola
deleted the
file_selector/linux/74323-add-get-directories-paths-implementation
branch
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…r#6573) * Add getDirectoriesPaths method to the file_selector_platform_interface Add getDirectoriesPaths to method channel. Increment version to 2.3.0 apply feedback extract assertion method * add getDirectoryPaths Linux implementation * apply rebase * update version to 0.9.1 Co-authored-by: eugerossetto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Linux implementation for retrieving multiple directories paths from a select folder dialog.
Issue: Support for selection of multiple directories, through desktop's native open panel, in 'file_selector' package #74323
New option on example application
GetDirectoriesPaths
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.