From 7eea758ad03c5da318a62f363ab941f3fc727591 Mon Sep 17 00:00:00 2001 From: eugerossetto Date: Wed, 5 Oct 2022 15:56:52 -0300 Subject: [PATCH 1/2] Remove ignore and change XTypeGroup to const. Pump version for file_selector_platform_interface/ --- .../lib/image_picker_windows.dart | 12 +++--------- .../image_picker/image_picker_windows/pubspec.yaml | 2 +- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/image_picker/image_picker_windows/lib/image_picker_windows.dart b/packages/image_picker/image_picker_windows/lib/image_picker_windows.dart index 10880d12ae6b..90e86bf486b4 100644 --- a/packages/image_picker/image_picker_windows/lib/image_picker_windows.dart +++ b/packages/image_picker/image_picker_windows/lib/image_picker_windows.dart @@ -118,9 +118,7 @@ class ImagePickerWindows extends ImagePickerPlatform { throw UnimplementedError( 'ImageSource.gallery is currently the only supported source on Windows'); } - final XTypeGroup typeGroup = - // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906 - // ignore: prefer_const_constructors + const XTypeGroup typeGroup = XTypeGroup(label: 'images', extensions: imageFormats); final XFile? file = await fileSelector .openFile(acceptedTypeGroups: [typeGroup]); @@ -144,9 +142,7 @@ class ImagePickerWindows extends ImagePickerPlatform { throw UnimplementedError( 'ImageSource.gallery is currently the only supported source on Windows'); } - final XTypeGroup typeGroup = - // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906 - // ignore: prefer_const_constructors + const XTypeGroup typeGroup = XTypeGroup(label: 'videos', extensions: videoFormats); final XFile? file = await fileSelector .openFile(acceptedTypeGroups: [typeGroup]); @@ -162,9 +158,7 @@ class ImagePickerWindows extends ImagePickerPlatform { double? maxHeight, int? imageQuality, }) async { - final XTypeGroup typeGroup = - // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906 - // ignore: prefer_const_constructors + const XTypeGroup typeGroup = XTypeGroup(label: 'images', extensions: imageFormats); final List files = await fileSelector .openFiles(acceptedTypeGroups: [typeGroup]); diff --git a/packages/image_picker/image_picker_windows/pubspec.yaml b/packages/image_picker/image_picker_windows/pubspec.yaml index 2887b080cef3..221896658b3e 100644 --- a/packages/image_picker/image_picker_windows/pubspec.yaml +++ b/packages/image_picker/image_picker_windows/pubspec.yaml @@ -16,7 +16,7 @@ flutter: dartPluginClass: ImagePickerWindows dependencies: - file_selector_platform_interface: ^2.0.4 + file_selector_platform_interface: ^2.2.0 file_selector_windows: ^0.8.2 flutter: sdk: flutter From 24ad8fd918d38eaef4a4291d469a3599fe883805 Mon Sep 17 00:00:00 2001 From: eugerossetto Date: Thu, 6 Oct 2022 12:26:42 -0300 Subject: [PATCH 2/2] Version pump. --- packages/image_picker/image_picker_windows/CHANGELOG.md | 3 ++- packages/image_picker/image_picker_windows/pubspec.yaml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/image_picker/image_picker_windows/CHANGELOG.md b/packages/image_picker/image_picker_windows/CHANGELOG.md index 2480d6da9ea4..427598760a4b 100644 --- a/packages/image_picker/image_picker_windows/CHANGELOG.md +++ b/packages/image_picker/image_picker_windows/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 0.1.0+3 +* Changes XTypeGroup initialization from final to const. * Updates minimum Flutter version to 2.10. ## 0.1.0+2 diff --git a/packages/image_picker/image_picker_windows/pubspec.yaml b/packages/image_picker/image_picker_windows/pubspec.yaml index 221896658b3e..5d6988cc2931 100644 --- a/packages/image_picker/image_picker_windows/pubspec.yaml +++ b/packages/image_picker/image_picker_windows/pubspec.yaml @@ -2,7 +2,7 @@ name: image_picker_windows description: Windows platform implementation of image_picker repository: https://github.com/flutter/plugins/tree/main/packages/image_picker/image_picker_windows issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22 -version: 0.1.0+2 +version: 0.1.0+3 environment: sdk: ">=2.12.0 <3.0.0"