Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] Annotate all parameters of XTypeGroup with // ignore: prefer_const_literals_to_create_immutables #6499

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[file_selector] Annotate all parameters of XTypeGroup with // ignore: prefer_const_literals_to_create_immutables #6499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/file_selector/file_selector/example/lib/open_image_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_constructors
// ignore_for_file: prefer_const_constructors, prefer_const_literals_to_create_immutables

import 'dart:io';

Expand Down
2 changes: 1 addition & 1 deletion packages/file_selector/file_selector/example/lib/open_multiple_images_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_constructors
// ignore_for_file: prefer_const_constructors, prefer_const_literals_to_create_immutables

import 'dart:io';

Expand Down
2 changes: 2 additions & 0 deletions packages/file_selector/file_selector/example/lib/open_text_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class OpenTextPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'text',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
// This demonstrates using an initial directory for the prompt, which should
Expand Down
3 changes: 3 additions & 0 deletions packages/file_selector/file_selector/test/file_selector_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'package:file_selector/file_selector.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:flutter_test/flutter_test.dart';
Expand Down
4 changes: 4 additions & 0 deletions packages/file_selector/file_selector_ios/example/lib/open_image_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ class OpenImagePage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'images',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
macUTIs: <String>['public.image'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
3 changes: 3 additions & 0 deletions packages/file_selector/file_selector_ios/example/lib/open_multiple_images_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'dart:io';

import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
Expand Down
4 changes: 4 additions & 0 deletions packages/file_selector/file_selector_ios/example/lib/open_text_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ class OpenTextPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'text',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
macUTIs: <String>['public.text'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
3 changes: 3 additions & 0 deletions packages/file_selector/file_selector_ios/test/file_selector_ios_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'package:file_selector_ios/file_selector_ios.dart';
import 'package:file_selector_ios/src/messages.g.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
Expand Down
2 changes: 2 additions & 0 deletions packages/file_selector/file_selector_linux/example/lib/open_image_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class OpenImagePage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'images',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
4 changes: 4 additions & 0 deletions packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ class OpenMultipleImagesPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'jpeg'],
);
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_constructors
final XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['png'],
);
final List<XFile> files = await FileSelectorPlatform.instance
Expand Down
2 changes: 2 additions & 0 deletions packages/file_selector/file_selector_linux/example/lib/open_text_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class OpenTextPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'text',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
3 changes: 3 additions & 0 deletions packages/file_selector/file_selector_linux/test/file_selector_linux_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'package:file_selector_linux/file_selector_linux.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:flutter/services.dart';
Expand Down
2 changes: 2 additions & 0 deletions packages/file_selector/file_selector_macos/example/lib/open_image_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class OpenImagePage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'images',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
4 changes: 4 additions & 0 deletions packages/file_selector/file_selector_macos/example/lib/open_multiple_images_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ class OpenMultipleImagesPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'jpeg'],
);
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_constructors
final XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['png'],
);
final List<XFile> files = await FileSelectorPlatform.instance
Expand Down
2 changes: 2 additions & 0 deletions packages/file_selector/file_selector_macos/example/lib/open_text_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class OpenTextPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'text',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
3 changes: 3 additions & 0 deletions packages/file_selector/file_selector_macos/test/file_selector_macos_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'package:file_selector_macos/file_selector_macos.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:flutter/services.dart';
Expand Down
3 changes: 3 additions & 0 deletions ...ages/file_selector/file_selector_web/example/integration_test/file_selector_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'dart:html';
import 'dart:typed_data';

Expand Down
3 changes: 3 additions & 0 deletions packages/file_selector/file_selector_web/test/utils_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:file_selector_web/src/utils.dart';
import 'package:flutter_test/flutter_test.dart';
Expand Down
2 changes: 2 additions & 0 deletions packages/file_selector/file_selector_windows/example/lib/open_image_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class OpenImagePage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'images',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
4 changes: 4 additions & 0 deletions packages/file_selector/file_selector_windows/example/lib/open_multiple_images_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ class OpenMultipleImagesPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'jpeg'],
);
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_constructors
final XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['png'],
);
final List<XFile> files = await FileSelectorPlatform.instance
Expand Down
2 changes: 2 additions & 0 deletions packages/file_selector/file_selector_windows/example/lib/open_text_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class OpenTextPage extends StatelessWidget {
// ignore: prefer_const_constructors
final XTypeGroup typeGroup = XTypeGroup(
label: 'text',
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
final XFile? file = await FileSelectorPlatform.instance
Expand Down
3 changes: 3 additions & 0 deletions packages/file_selector/file_selector_windows/test/file_selector_windows_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
// ignore_for_file: prefer_const_literals_to_create_immutables

import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:file_selector_windows/file_selector_windows.dart';
import 'package:file_selector_windows/src/messages.g.dart';
Expand Down