Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Jan 13, 2022

This test is for a change that was entirely in Android Java code when it
was written, so is testing behavior that is internal to the Android
implementation, and a copy of this test already runs
webview_flutter_android. Given that it's testing internal Android
behavior, only that copy is needed.

For unknown reasons, this copy seems to hang test runs, while the
webview_flutter_android copy does not. Since it's a duplicate that we
want to remove anyway, this simply removes it to fix the tree without
meaningful loss of coverage.

Also fixes a race condition in an integration test, where a future
could be completed more than once.

Part of flutter/flutter#91004

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

This test is for a change that was entirely in Android Java code when it
was written, so is testing behavior that is internal to the Android
implementation, and a copy of this test already runs
webview_flutter_android. Given that it's testing internal Android
behavior, only that copy is needed.

For unknown reasons, this copy seems to hang test runs, while the
webview_flutter_android copy does not. Since it's a duplicate that we
want to remove anyway, this simply removes it to fix the tree without
meaningful loss of coverage.

Part of flutter/flutter#91004
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android labels Jan 13, 2022
@stuartmorgan-g
Copy link
Contributor Author

This fixes things for me locally, but doesn't seem to be enough to make CI happy :(

@stuartmorgan-g
Copy link
Contributor Author

I'm going to go ahead and land this even though it's not enough to fix CI since it does at least fix issues I'm having locally, so landing it should remove some potential issues for people trying to reproduce the problem locally to figure out a fix.

@stuartmorgan-g stuartmorgan-g merged commit ec80d34 into flutter:main Jan 13, 2022
@stuartmorgan-g stuartmorgan-g deleted the webview-remove-duplicate-android-test branch January 13, 2022 20:36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants