From f8a9c1bc891ea789cbf77d157bf132cde347ea06 Mon Sep 17 00:00:00 2001 From: Emmanuel Garcia Date: Mon, 8 Nov 2021 12:04:58 -0800 Subject: [PATCH 1/3] Implemement DartMessenger new methods --- .../io/flutter/plugins/camera/DartMessengerTest.java | 10 ++++++++++ .../flutter/plugins/quickactions/QuickActionsTest.java | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java b/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java index 0a2fc43d03cb..5c4af7749311 100644 --- a/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java +++ b/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java @@ -47,6 +47,16 @@ public void setMessageHandler(@NonNull String channel, BinaryMessageHandler hand List getMessages() { return new ArrayList<>(sentMessages); } + + @Override + void enableBufferingIncomingMessages() { + // Do nothing. + } + + @Override + void disableBufferingIncomingMessages() { + // Do nothing. + } } private Handler mockHandler; diff --git a/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java b/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java index 208a119efafe..c429d7b6bdfc 100644 --- a/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java +++ b/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java @@ -53,6 +53,16 @@ public void send( public void setMessageHandler(@NonNull String channel, @Nullable BinaryMessageHandler handler) { // Do nothing. } + + @Override + void enableBufferingIncomingMessages() { + // Do nothing. + } + + @Override + void disableBufferingIncomingMessages() { + // Do nothing. + } } static final int SUPPORTED_BUILD = 25; From 6dd8a2878ba6fa4168d3111d37a09e54e8d1dd12 Mon Sep 17 00:00:00 2001 From: Emmanuel Garcia Date: Mon, 8 Nov 2021 12:21:01 -0800 Subject: [PATCH 2/3] access --- .../java/io/flutter/plugins/camera/DartMessengerTest.java | 4 ++-- .../io/flutter/plugins/quickactions/QuickActionsTest.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java b/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java index 5c4af7749311..73f35cae23a3 100644 --- a/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java +++ b/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java @@ -49,12 +49,12 @@ List getMessages() { } @Override - void enableBufferingIncomingMessages() { + public void enableBufferingIncomingMessages() { // Do nothing. } @Override - void disableBufferingIncomingMessages() { + public void disableBufferingIncomingMessages() { // Do nothing. } } diff --git a/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java b/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java index c429d7b6bdfc..e0089cbb9603 100644 --- a/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java +++ b/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java @@ -55,12 +55,12 @@ public void setMessageHandler(@NonNull String channel, @Nullable BinaryMessageHa } @Override - void enableBufferingIncomingMessages() { + public void enableBufferingIncomingMessages() { // Do nothing. } @Override - void disableBufferingIncomingMessages() { + public void disableBufferingIncomingMessages() { // Do nothing. } } From d329ad514e20af29c91cd7c9d33be31cd61bcdf3 Mon Sep 17 00:00:00 2001 From: Emmanuel Garcia Date: Mon, 8 Nov 2021 13:56:48 -0800 Subject: [PATCH 3/3] Disable tests --- .../io/flutter/plugins/camera/DartMessengerTest.java | 10 ---------- .../flutter/plugins/quickactions/QuickActionsTest.java | 10 ---------- script/configs/exclude_native_unit_android.yaml | 4 ++++ 3 files changed, 4 insertions(+), 20 deletions(-) diff --git a/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java b/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java index 73f35cae23a3..0a2fc43d03cb 100644 --- a/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java +++ b/packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java @@ -47,16 +47,6 @@ public void setMessageHandler(@NonNull String channel, BinaryMessageHandler hand List getMessages() { return new ArrayList<>(sentMessages); } - - @Override - public void enableBufferingIncomingMessages() { - // Do nothing. - } - - @Override - public void disableBufferingIncomingMessages() { - // Do nothing. - } } private Handler mockHandler; diff --git a/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java b/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java index e0089cbb9603..208a119efafe 100644 --- a/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java +++ b/packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java @@ -53,16 +53,6 @@ public void send( public void setMessageHandler(@NonNull String channel, @Nullable BinaryMessageHandler handler) { // Do nothing. } - - @Override - public void enableBufferingIncomingMessages() { - // Do nothing. - } - - @Override - public void disableBufferingIncomingMessages() { - // Do nothing. - } } static final int SUPPORTED_BUILD = 25; diff --git a/script/configs/exclude_native_unit_android.yaml b/script/configs/exclude_native_unit_android.yaml index 5ec80eee73a0..1437e8b23c62 100644 --- a/script/configs/exclude_native_unit_android.yaml +++ b/script/configs/exclude_native_unit_android.yaml @@ -9,3 +9,7 @@ # No need for unit tests: - espresso + +# TODO(egarciad): Re-enable these tests https://github.com/flutter/flutter/issues/93286 +- camera/camera +- quick_actions/quick_actions