From 85cd373a8d27e1ffab6a4722ac99e9bf7accb232 Mon Sep 17 00:00:00 2001 From: James Lin Date: Tue, 8 Sep 2020 17:52:23 -0700 Subject: [PATCH 1/2] [url_launcher_web] Fix a typo in a test name and fix quote consistency --- .../test/url_launcher_web_test.dart | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/url_launcher/url_launcher_web/test/url_launcher_web_test.dart b/packages/url_launcher/url_launcher_web/test/url_launcher_web_test.dart index 9cbaf686069f..56f23a464f1d 100644 --- a/packages/url_launcher/url_launcher_web/test/url_launcher_web_test.dart +++ b/packages/url_launcher/url_launcher_web/test/url_launcher_web_test.dart @@ -145,17 +145,17 @@ void main() { verify(mockWindow.open('sms:+19725551212?body=hello%20there', '')); }); - test('setting oOnlyLinkTarget as _self opens the url in the same tab', + test('setting webOnlyLinkTarget as _self opens the url in the same tab', () { - plugin.openNewWindow("https://www.google.com", - webOnlyWindowName: "_self"); + plugin.openNewWindow('https://www.google.com', + webOnlyWindowName: '_self'); verify(mockWindow.open('https://www.google.com', '_self')); }); test('setting webOnlyLinkTarget as _blank opens the url in a new tab', () { - plugin.openNewWindow("https://www.google.com", - webOnlyWindowName: "_blank"); + plugin.openNewWindow('https://www.google.com', + webOnlyWindowName: '_blank'); verify(mockWindow.open('https://www.google.com', '_blank')); }); @@ -197,9 +197,9 @@ void main() { test( 'mailto urls should use _blank if webOnlyWindowName is set as _blank', () { - plugin.openNewWindow("mailto:name@mydomain.com", - webOnlyWindowName: "_blank"); - verify(mockWindow.open("mailto:name@mydomain.com", "_blank")); + plugin.openNewWindow('mailto:name@mydomain.com', + webOnlyWindowName: '_blank'); + verify(mockWindow.open('mailto:name@mydomain.com', '_blank')); }); }); }); From a4244d9adf9eafe56c25da518e0f1d974d042814 Mon Sep 17 00:00:00 2001 From: James Lin Date: Wed, 9 Sep 2020 14:13:47 -0700 Subject: [PATCH 2/2] [url_launcher_web] Update package version --- packages/url_launcher/url_launcher_web/CHANGELOG.md | 4 ++++ packages/url_launcher/url_launcher_web/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/url_launcher/url_launcher_web/CHANGELOG.md b/packages/url_launcher/url_launcher_web/CHANGELOG.md index 4bf47fe2c1fb..b12189336e74 100644 --- a/packages/url_launcher/url_launcher_web/CHANGELOG.md +++ b/packages/url_launcher/url_launcher_web/CHANGELOG.md @@ -1,3 +1,7 @@ +# 0.1.3+2 + +- Fix a typo in a test name and fix some style inconsistencies. + # 0.1.3+1 - Depend explicitly on the `platform_interface` package that adds the `webOnlyWindowName` parameter. diff --git a/packages/url_launcher/url_launcher_web/pubspec.yaml b/packages/url_launcher/url_launcher_web/pubspec.yaml index 6c1285f22090..d206c0f1bbb9 100644 --- a/packages/url_launcher/url_launcher_web/pubspec.yaml +++ b/packages/url_launcher/url_launcher_web/pubspec.yaml @@ -4,7 +4,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/u # 0.1.y+z is compatible with 1.0.0, if you land a breaking change bump # the version to 2.0.0. # See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0 -version: 0.1.3+1 +version: 0.1.3+2 flutter: plugin: