Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 8f55fb6

Browse files
[webview_flutter_android] Implementation of Android WebView widget using pigeon (#4503)
1 parent 4ccc904 commit 8f55fb6

37 files changed

+2219
-1741
lines changed

packages/webview_flutter/analysis_options.yaml

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: ../../../analysis_options_legacy.yaml

packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,11 @@ void main() {
197197
onPageFinished: () => onPageFinished.complete(),
198198
));
199199
await onPageFinished.future;
200-
if (Platform.isAndroid) {
201-
await initialResizeCompleter.future;
202-
}
200+
// Wait for a potential call to resize after page is loaded.
201+
await initialResizeCompleter.future.timeout(
202+
const Duration(seconds: 3),
203+
onTimeout: () => null,
204+
);
203205

204206
resizeButtonTapped = true;
205207
await tester.tap(find.byKey(const ValueKey('resizeButton')));

packages/webview_flutter/webview_flutter_android/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.3.0
2+
3+
* Replaces platform implementation with API built with pigeon.
4+
15
## 2.2.1
26

37
* Fix `NullPointerException` from a race condition when changing focus. This only affects `WebView`

packages/webview_flutter/webview_flutter_android/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterDownloadListener.java

Lines changed: 0 additions & 33 deletions
This file was deleted.

0 commit comments

Comments
 (0)