Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 09e7832

Browse files
authored
Fix Java lint warnings in google maps plugin (#745)
1 parent 8dd8fa6 commit 09e7832

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ private static BitmapDescriptor toBitmapDescriptor(Object o) {
3737
return BitmapDescriptorFactory.fromAsset(
3838
FlutterMain.getLookupKeyForAsset(toString(data.get(1)), toString(data.get(2))));
3939
}
40+
default:
41+
throw new IllegalArgumentException("Cannot interpret " + o + " as BitmapDescriptor");
4042
}
41-
throw new IllegalArgumentException("Cannot interpret " + o + " as BitmapDescriptor");
4243
}
4344

4445
private static boolean toBoolean(Object o) {
@@ -83,8 +84,9 @@ static CameraUpdate toCameraUpdate(Object o, float density) {
8384
return CameraUpdateFactory.zoomOut();
8485
case "zoomTo":
8586
return CameraUpdateFactory.zoomTo(toFloat(data.get(1)));
87+
default:
88+
throw new IllegalArgumentException("Cannot interpret " + o + " as CameraUpdate");
8689
}
87-
throw new IllegalArgumentException("Cannot interpret " + o + " as CameraUpdate");
8890
}
8991

9092
private static double toDouble(Object o) {

packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ void init() {
108108
case CREATED:
109109
mapView.onCreate(null);
110110
break;
111+
default:
112+
throw new IllegalArgumentException(
113+
"Cannot interpret " + activityState.get() + " as an activity state");
111114
}
112115
registrar.activity().getApplication().registerActivityLifecycleCallbacks(this);
113116
mapView.getMapAsync(this);
@@ -164,6 +167,7 @@ public void onMapReady(GoogleMap googleMap) {
164167
googleMap.setOnMarkerClickListener(this);
165168
}
166169

170+
@Override
167171
public void onMethodCall(MethodCall call, MethodChannel.Result result) {
168172
switch (call.method) {
169173
case "map#waitForMap":

0 commit comments

Comments
 (0)