From 76b3851a302c4024ab64a0d9a36ce04b108f9f67 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Fri, 7 Mar 2025 10:41:56 -0500 Subject: [PATCH] [camera] Fix unit test asserting external value A unit test in the app-facing package that predates federation is asserting an expected string that includes constant text that is controlled by a `toString` method from the platform interface package. This fixes the test to only assert the parts that are within the package's control. Unblocks https://github.com/flutter/packages/pull/8723 --- .../camera/camera/test/camera_value_test.dart | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/packages/camera/camera/test/camera_value_test.dart b/packages/camera/camera/test/camera_value_test.dart index dbb1ddcbf78..2c5ff71dcee 100644 --- a/packages/camera/camera/test/camera_value_test.dart +++ b/packages/camera/camera/test/camera_value_test.dart @@ -146,8 +146,22 @@ void main() { description: FakeController.fakeDescription, ); - expect(cameraValue.toString(), - 'CameraValue(isRecordingVideo: false, isInitialized: false, errorDescription: null, previewSize: Size(10.0, 10.0), isStreamingImages: false, flashMode: FlashMode.auto, exposureMode: ExposureMode.auto, focusMode: FocusMode.auto, exposurePointSupported: true, focusPointSupported: true, deviceOrientation: DeviceOrientation.portraitUp, lockedCaptureOrientation: DeviceOrientation.portraitUp, recordingOrientation: DeviceOrientation.portraitUp, isPreviewPaused: true, previewPausedOrientation: DeviceOrientation.portraitUp, description: CameraDescription(, CameraLensDirection.back, 0))'); + expect( + cameraValue.toString(), + 'CameraValue(isRecordingVideo: false, isInitialized: false, ' + 'errorDescription: null, previewSize: Size(10.0, 10.0), ' + 'isStreamingImages: false, flashMode: FlashMode.auto, ' + 'exposureMode: ExposureMode.auto, focusMode: FocusMode.auto, ' + 'exposurePointSupported: true, focusPointSupported: true, ' + 'deviceOrientation: DeviceOrientation.portraitUp, ' + 'lockedCaptureOrientation: DeviceOrientation.portraitUp, ' + 'recordingOrientation: DeviceOrientation.portraitUp, ' + 'isPreviewPaused: true, ' + 'previewPausedOrientation: DeviceOrientation.portraitUp, ' + // CameraDescription.toString is defined in the platform interface + // package, so don't assert a specific value for it, only that + // whatever it returns is inserted as expected. + 'description: ${FakeController.fakeDescription})'); }); }); }