[flutter_svg] Implement errorBuilder callback #8364
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Hey @memishood, thank you for your Pull Request. Can you please add a test to confirm that this code works as expected? |
Alright, I will be adding them soon |
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
LGTM, PTAL @stuartmorgan
|
@jonahwilliams (or someone else in the engine team) should be the secondary reviewer for |
stuartmorgan-g
requested review from
jonahwilliams
and removed request for
stuartmorgan-g
domesticmouse
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/8364, due to - The status or check suite Windows_x64 dart_unit_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
@stuartmorgan Who can deflake the broken CI test? I can't see the failure. |
|
Perhaps using |
It's not flake; I can reproduce it locally. There just isn't any output; AFAICT from debugging, calling I tried changing it to |
domesticmouse
added
the
autosubmit
flutter/packages@3fc6b7a...6554751 2025-01-09 [email protected] [webview_flutter_wkwebview] Add a listener for the canGoBack property change on the iOS platform. (flutter/packages#8203) 2025-01-09 [email protected] [flutter_svg] Implement errorBuilder callback (flutter/packages#8364) 2025-01-08 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdDisplayContainer`. (flutter/packages#8153) 2025-01-08 [email protected] [go_router_builder] Add a fallback for a not null List or Set param (flutter/packages#8349) 2025-01-08 [email protected] Manual roll Flutter (stable) from 8495dee to 17025dd (2 revisions) (flutter/packages#8396) 2025-01-08 [email protected] [ci][video_player_android][camera_android_camerax] Manual roll and fix tests (flutter/packages#8391) 2025-01-07 [email protected] [ci] Run web tests in wasm (unit + integration). (flutter/packages#8111) 2025-01-07 [email protected] [camera_platform_interface] Add API support query for image streaming (flutter/packages#8307) 2025-01-07 [email protected] [camera_android_camerax][video_player_android] Suppresses deprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388) 2025-01-07 [email protected] Bump Remaining Plugin Example Apps to targetSdkVersion >= 34 and compileSdkVersion >= 34 (flutter/packages#8361) 2025-01-07 [email protected] Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter/packages#8384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
closes flutter/flutter#158612 ## Description - Implemented errorBuilder callback to handle loading failures
closes flutter/flutter#158612 ## Description - Implemented errorBuilder callback to handle loading failures
4 participants
closes flutter/flutter#158612
Description
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.