Skip to content

[in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift #7172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 19, 2024
Merged

[in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift #7172

merged 8 commits into from
Jul 19, 2024

Conversation

@LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Jul 18, 2024

Part of flutter/flutter#151624

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@LouiseHsu
Copy link
Contributor Author

LouiseHsu commented Jul 18, 2024

Theres only 2 more test files after this 🙏

@LouiseHsu LouiseHsu marked this pull request as ready for review July 19, 2024 00:01
@LouiseHsu LouiseHsu requested a review from hellohuanlin July 19, 2024 00:02
hellohuanlin
hellohuanlin approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

..._purchase/in_app_purchase_storekit/example/shared/RunnerTests/FIATransactionCacheTests.swift Outdated
final class FIATransactionCacheTests: XCTestCase {

func testAddObjectsForNewKey() {
let dummyArray: [Int] = [1, 2, 3]
Copy link
Contributor

@hellohuanlin hellohuanlin Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

   let dummyArray = [1, 2, 3]

..._purchase/in_app_purchase_storekit/example/shared/RunnerTests/FIATransactionCacheTests.swift Outdated
cache.add(dummyArray, for: TransactionCacheKey.updatedTransactions)

XCTAssertEqual(
dummyArray, cache.getObjectsFor(TransactionCacheKey.updatedTransactions) as! [Int])
Copy link
Contributor

@hellohuanlin hellohuanlin Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use that unwrap function and avoid ! here?

let updatedTransactions = try XCTUnwrap(cache.getObjectsFor(TransactionCacheKey.updatedTransactions) as? [Int])

Copy link
Contributor Author

@LouiseHsu LouiseHsu Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh yes, done

..._purchase/in_app_purchase_storekit/example/shared/RunnerTests/FIATransactionCacheTests.swift Outdated
func testClear() {
let fakeUpdatedTransactions: [Int] = [1, 2, 3]
let fakeRemovedTransactions: [String] = ["Remove 1", "Remove 2", "Remove 3"]
let fakeUpdatedDownloads: [String] = ["Download 1", "Download 2"]
Copy link
Contributor

@hellohuanlin hellohuanlin Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need the type

Copy link
Contributor Author

@LouiseHsu LouiseHsu Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed all types

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 19, 2024

auto label is removed for flutter/packages/7172, due to - The status or check suite Mac_arm64 macos_repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2024
@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2024
@auto-submit auto-submit bot merged commit 3144ac0 into flutter:main Jul 19, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
3144ac0 [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m…
af939e9 
… to.Swift (flutter/packages#7172)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
3144ac0 [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m…
be4b2f2 
… to.Swift (flutter/packages#7172)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
Roll Packages from c7f0526 to 3144ac0 (8 revisions) (#152044)
20242d0 
flutter/packages@c7f0526...3144ac0

2024-07-19 [email protected] [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 [email protected] [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 [email protected] [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 [email protected] [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 [email protected] [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 [email protected] [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 25, 2024
Merged
11 tasks
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Packages from c7f0526 to 3144ac0 (8 revisions) (flutter#152044)
fb21ebe 
flutter/packages@c7f0526...3144ac0

2024-07-19 [email protected] [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 [email protected] [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 [email protected] [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 [email protected] [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 [email protected] [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 [email protected] [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@LouiseHsu LouiseHsu mentioned this pull request Aug 8, 2024
Closed
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from c7f0526 to 3144ac0 (8 revisions) (flutter#152044)
3e87673 
flutter/packages@c7f0526...3144ac0

2024-07-19 [email protected] [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 [email protected] [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 [email protected] [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 [email protected] [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 [email protected] [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 [email protected] [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-ios platform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LouiseHsu @hellohuanlin