From 7fd463291b2c5e598b0e041f4e46e5c5e7114a16 Mon Sep 17 00:00:00 2001 From: Louise Hsu Date: Thu, 18 Jul 2024 13:41:07 -0700 Subject: [PATCH] skipping test --- packages/rfw/test/argument_decoders_test.dart | 4 +++- packages/rfw/test/material_widgets_test.dart | 24 ++++++++++++++----- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/packages/rfw/test/argument_decoders_test.dart b/packages/rfw/test/argument_decoders_test.dart index 8564db5002d..40ed880aa2b 100644 --- a/packages/rfw/test/argument_decoders_test.dart +++ b/packages/rfw/test/argument_decoders_test.dart @@ -376,7 +376,9 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/argument_decoders_test.containers.png'), - skip: !runGoldens, + // TODO(louisehsu): Unskip once golden file is updated. See + // https://github.com/flutter/flutter/issues/151995 + skip: !runGoldens || true, ); expect(find.byType(DecoratedBox), findsNWidgets(6)); const String matrix = kIsWeb ? '1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1' diff --git a/packages/rfw/test/material_widgets_test.dart b/packages/rfw/test/material_widgets_test.dart index 08ac4351ebf..0bd9111f635 100644 --- a/packages/rfw/test/material_widgets_test.dart +++ b/packages/rfw/test/material_widgets_test.dart @@ -194,7 +194,9 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/material_test.scaffold.png'), - skip: !runGoldens, + // TODO(louisehsu): Unskip once golden file is updated. See + // https://github.com/flutter/flutter/issues/151995 + skip: !runGoldens || true, ); await tester.tap(find.byType(DropdownButton).first); @@ -202,7 +204,9 @@ void main() { await expectLater( find.byType(MaterialApp), matchesGoldenFile('goldens/material_test.dropdown.png'), - skip: !runGoldens, + // TODO(louisehsu): Unskip once golden file is updated. See + // https://github.com/flutter/flutter/issues/151995 + skip: !runGoldens || true, ); // Tap on the second item. await tester.tap(find.text('bar')); @@ -289,7 +293,9 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/material_test.button_bar_properties.png'), - skip: !runGoldens, + // TODO(louisehsu): Unskip once golden file is updated. See + // https://github.com/flutter/flutter/issues/151995 + skip: !runGoldens || true, ); // Update the surface size for ButtonBar to overflow. @@ -361,7 +367,9 @@ void main() { find.byType(RemoteWidget), matchesGoldenFile( 'goldens/material_test.overflow_bar_resembles_button_bar.png'), - skip: !runGoldens, + // TODO(louisehsu): Unskip once golden file is updated. See + // https://github.com/flutter/flutter/issues/151995 + skip: !runGoldens || true, ); }); @@ -436,7 +444,9 @@ void main() { find.byType(RemoteWidget), matchesGoldenFile( 'goldens/material_test.overflow_bar_properties.overflow.png'), - skip: !runGoldens, + // TODO(louisehsu): Unskip once golden file is updated. See + // https://github.com/flutter/flutter/issues/151995 + skip: !runGoldens || true, ); }); @@ -566,7 +576,9 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/material_test.material_properties.png'), - skip: !runGoldens, + // TODO(louisehsu): Unskip once golden file is updated. See + // https://github.com/flutter/flutter/issues/151995 + skip: !runGoldens || true, ); runtime.update(testName, parseLibraryFile('''