From 169240d7e98821e73ca8296d0f9ef30ec8dbf3f4 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Fri, 5 Apr 2024 21:41:10 +0000 Subject: [PATCH 01/16] Add missing_code_block_language_in_doc_comment lint to flutter/packages. --- analysis_options.yaml | 1 + .../flutter_migrate/lib/src/base/common.dart | 4 +- .../flutter_migrate/lib/src/base/logger.dart | 2 +- packages/go_router/lib/src/route.dart | 33 ++++++------ packages/go_router/lib/src/state.dart | 2 +- .../google_sign_in/lib/testing.dart | 2 +- .../.plugin_symlinks/local_auth_windows | 1 + packages/rfw/lib/src/dart/binary.dart | 2 +- packages/rfw/lib/src/dart/text.dart | 52 +++++++++---------- packages/web_benchmarks/lib/src/browser.dart | 2 +- packages/web_benchmarks/lib/src/recorder.dart | 6 +-- .../lib/src/weak_reference_utils.dart | 2 +- .../lib/src/common/weak_reference_utils.dart | 2 +- .../lib/src/update_release_info_command.dart | 2 +- 14 files changed, 59 insertions(+), 54 deletions(-) create mode 120000 packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows diff --git a/analysis_options.yaml b/analysis_options.yaml index 05f98247f13..6f7467b38d3 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -112,6 +112,7 @@ linter: # - lines_longer_than_80_chars # not required by flutter style - literal_only_boolean_expressions # - matching_super_parameters # blocked on https://github.com/dart-lang/language/issues/2509 + - missing_code_block_language_in_doc_comment - missing_whitespace_between_adjacent_strings - no_adjacent_strings_in_list - no_default_cases diff --git a/packages/flutter_migrate/lib/src/base/common.dart b/packages/flutter_migrate/lib/src/base/common.dart index 6612e3a30ee..1bf38431b52 100644 --- a/packages/flutter_migrate/lib/src/base/common.dart +++ b/packages/flutter_migrate/lib/src/base/common.dart @@ -63,7 +63,7 @@ String getEnumName(dynamic enumItem) { /// Rationale: /// /// Consider the following snippet: -/// ``` +/// ```dart /// try { /// await foo(); /// ... @@ -87,7 +87,7 @@ String getEnumName(dynamic enumItem) { /// [asyncGuard] is intended to wrap awaited expressions occurring in a `try` /// block. The behavior described above gives the behavior that users /// intuitively expect from `await`. Consider the snippet: -/// ``` +/// ```dart /// try { /// await asyncGuard(() async { /// var c = Completer(); diff --git a/packages/flutter_migrate/lib/src/base/logger.dart b/packages/flutter_migrate/lib/src/base/logger.dart index 70ff228a390..92ba372c611 100644 --- a/packages/flutter_migrate/lib/src/base/logger.dart +++ b/packages/flutter_migrate/lib/src/base/logger.dart @@ -1125,7 +1125,7 @@ class SpinnerStatus extends AnonymousSpinnerStatus { /// ``` /// /// yields: -/// ``` +/// ```none /// Usage: app main_command /// [arguments] /// ``` diff --git a/packages/go_router/lib/src/route.dart b/packages/go_router/lib/src/route.dart index 6fa9b8bb748..fff33ba7f2b 100644 --- a/packages/go_router/lib/src/route.dart +++ b/packages/go_router/lib/src/route.dart @@ -77,7 +77,7 @@ typedef ExitCallback = FutureOr Function( /// with the sub routes. /// /// For example these routes: -/// ``` +/// ```none /// / => HomePage() /// family/f1 => FamilyPage('f1') /// person/p2 => PersonPage('f1', 'p2') ← showing this page, Back pops ↑ @@ -85,7 +85,7 @@ typedef ExitCallback = FutureOr Function( /// /// Can be represented as: /// -/// ``` +/// ```dart /// final GoRouter _router = GoRouter( /// routes: [ /// GoRoute( @@ -122,12 +122,14 @@ typedef ExitCallback = FutureOr Function( /// ), /// ], /// ); +/// ``` /// /// If there are multiple routes that match the location, the first match is used. /// To make predefined routes to take precedence over dynamic routes eg. '/:id' -/// consider adding the dynamic route at the end of the routes +/// consider adding the dynamic route at the end of the routes. +/// /// For example: -/// ``` +/// ```dart /// final GoRouter _router = GoRouter( /// routes: [ /// GoRoute( @@ -145,9 +147,10 @@ typedef ExitCallback = FutureOr Function( /// ], /// ); /// ``` -/// In the above example, if /family route is matched, it will be used. -/// else /:username route will be used. -/// /// +/// +/// In the above example, if `/family` route is matched, it will be used. +/// else `/:username` route will be used. +/// /// See [main.dart](https://github.com/flutter/packages/blob/main/packages/go_router/example/lib/main.dart) @immutable abstract class RouteBase with Diagnosticable { @@ -327,7 +330,7 @@ class GoRoute extends RouteBase { /// The path of this go route. /// /// For example: - /// ``` + /// ```dart /// GoRoute( /// path: '/', /// pageBuilder: (BuildContext context, GoRouterState state) => MaterialPage( @@ -352,7 +355,7 @@ class GoRoute extends RouteBase { /// A page builder for this route. /// /// Typically a MaterialPage, as in: - /// ``` + /// ```dart /// GoRoute( /// path: '/', /// pageBuilder: (BuildContext context, GoRouterState state) => MaterialPage( @@ -369,7 +372,7 @@ class GoRoute extends RouteBase { /// A custom builder for this route. /// /// For example: - /// ``` + /// ```dart /// GoRoute( /// path: '/', /// builder: (BuildContext context, GoRouterState state) => FamilyPage( @@ -391,7 +394,7 @@ class GoRoute extends RouteBase { /// This method can be useful it one wants to launch a dialog for user to /// confirm if they want to exit the screen. /// - /// ``` + /// ```dart /// final GoRouter _router = GoRouter( /// routes: [ /// GoRoute( @@ -542,7 +545,7 @@ class ShellRouteContext { /// passed to the /b/details route so that it displays on the root Navigator /// instead of the ShellRoute's Navigator: /// -/// ``` +/// ```dart /// final GlobalKey _rootNavigatorKey = /// GlobalKey(); /// @@ -601,7 +604,7 @@ class ShellRouteContext { /// /// For example: /// -/// ``` +/// ```dart /// ShellRoute( /// builder: (BuildContext context, GoRouterState state, Widget child) { /// return Scaffold( @@ -739,7 +742,7 @@ class ShellRoute extends ShellRouteBase { /// accomplished by using the method [StatefulNavigationShell.goBranch], for /// example: /// -/// ``` +/// ```dart /// void _onItemTapped(int index) { /// navigationShell.goBranch(index: index); /// } @@ -1059,7 +1062,7 @@ typedef ShellNavigationContainerBuilder = Widget Function(BuildContext context, /// where the List of Widgets represent the Navigators for each branch. /// /// Example: -/// ``` +/// ```dart /// builder: (BuildContext context, GoRouterState state, /// StatefulNavigationShell navigationShell) { /// return StatefulNavigationShell( diff --git a/packages/go_router/lib/src/state.dart b/packages/go_router/lib/src/state.dart index 323321b6a8b..0a1fb54ba79 100644 --- a/packages/go_router/lib/src/state.dart +++ b/packages/go_router/lib/src/state.dart @@ -102,7 +102,7 @@ class GoRouterState { /// /// To access GoRouterState from a widget. /// - /// ``` + /// ```dart /// GoRoute( /// path: '/:id' /// builder: (_, __) => MyWidget(), diff --git a/packages/google_sign_in/google_sign_in/lib/testing.dart b/packages/google_sign_in/google_sign_in/lib/testing.dart index e519b34b199..23510a2c4a7 100644 --- a/packages/google_sign_in/google_sign_in/lib/testing.dart +++ b/packages/google_sign_in/google_sign_in/lib/testing.dart @@ -10,7 +10,7 @@ import 'package:flutter/services.dart' show MethodCall; /// /// Example usage: /// -/// ``` +/// ```dart /// GoogleSignIn googleSignIn; /// FakeSignInBackend fakeSignInBackend; /// diff --git a/packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows b/packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows new file mode 120000 index 00000000000..221702bef24 --- /dev/null +++ b/packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows @@ -0,0 +1 @@ +/usr/local/google/home/kallentu/.pub-cache/hosted/pub.dev/local_auth_windows-1.0.10/ \ No newline at end of file diff --git a/packages/rfw/lib/src/dart/binary.dart b/packages/rfw/lib/src/dart/binary.dart index cd999377f20..a3c64c9b101 100644 --- a/packages/rfw/lib/src/dart/binary.dart +++ b/packages/rfw/lib/src/dart/binary.dart @@ -220,7 +220,7 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// /// For example, this switch: /// -/// ``` +/// ```none /// switch (args.a) { /// 0: 'z', /// 1: 'o', diff --git a/packages/rfw/lib/src/dart/text.dart b/packages/rfw/lib/src/dart/text.dart index 248f15ea26b..2dc82c0283b 100644 --- a/packages/rfw/lib/src/dart/text.dart +++ b/packages/rfw/lib/src/dart/text.dart @@ -139,7 +139,7 @@ import 'model.dart'; /// The numbers represented must be in the range -9,223,372,036,854,775,808 to /// 9,223,372,036,854,775,807. /// -/// ``` +/// ```bnf /// double ::= "-"? digit+ ("." digit+)? (("e" | "E") "-"? digit+)? /// ``` /// @@ -224,13 +224,13 @@ DynamicMap parseDataFile(String file) { /// /// Imports have this form: /// -/// ``` +/// ```none /// import library.name; /// ``` /// /// For example: /// -/// ``` +/// ```none /// import core.widgets; /// ``` /// @@ -245,7 +245,7 @@ DynamicMap parseDataFile(String file) { /// /// To declare a widget named A in terms of a widget B, the following form is used: /// -/// ``` +/// ```none /// widget A = B(); /// ``` /// @@ -253,14 +253,14 @@ DynamicMap parseDataFile(String file) { /// /// If the widget A is to be stateful, a map is inserted before the equals sign: /// -/// ``` +/// ```none /// widget A { } = B(); /// ``` /// /// The map describes the default values of the state. For example, a button /// might have a "down" state, which is initially false: /// -/// ``` +/// ```none /// widget Button { down: false } = Container(); /// ``` /// @@ -277,7 +277,7 @@ DynamicMap parseDataFile(String file) { /// /// In this example, several constructor calls are nested together: /// -/// ``` +/// ```none /// widget Foo = Column( /// children: [ /// Container( @@ -306,7 +306,7 @@ DynamicMap parseDataFile(String file) { /// /// In this example several widget builders are nested together: /// -/// ``` +/// ```none /// widget Foo {text: 'this is cool'} = Builder( /// builder: (foo) => Builder( /// builder: (bar) => Builder( @@ -374,21 +374,21 @@ DynamicMap parseDataFile(String file) { /// /// For example, suppose one instantiated a widget Foo as follows: /// -/// ``` +/// ```none /// Foo(name: "Bobbins") /// ``` /// /// ...then in the definition of Foo, one might pass the value of this "name" /// argument to another widget, say a Text widget, as follows: /// -/// ``` +/// ```none /// widget Foo = Text(text: args.name); /// ``` /// /// The arguments can have structure. For example, if the argument passed to Foo /// was: /// -/// ``` +/// ```none /// Foo(show: { name: "Cracking the Cryptic", phrase: "Bobbins" }) /// ``` /// @@ -396,7 +396,7 @@ DynamicMap parseDataFile(String file) { /// would specify an argument reference consisting of the values "show" and /// "phrase", as in `args.show.phrase`. For example: /// -/// ``` +/// ```none /// widget Foo = Text(text: args.show.phrase); /// ``` /// @@ -410,7 +410,7 @@ DynamicMap parseDataFile(String file) { /// doubles, bools, and strings (see [DynamicContent]). For example, if the data /// model looks like this: /// -/// ``` +/// ```none /// { server: { cart: [ { name: "Apple"}, { name: "Banana"} ] } /// ``` /// @@ -418,7 +418,7 @@ DynamicMap parseDataFile(String file) { /// would specify a data model reference consisting of the values "server", /// "cart", 1, and "name", as in `data.server.cart.1.name`. For example: /// -/// ``` +/// ```none /// Text(text: data.server.cart.1.name) /// ``` /// @@ -433,7 +433,7 @@ DynamicMap parseDataFile(String file) { /// A widget that shows all the values from a list in a [ListView] might look /// like this: /// -/// ``` +/// ```none /// widget Items = ListView( /// children: [ /// ...for item in args.list: @@ -444,7 +444,7 @@ DynamicMap parseDataFile(String file) { /// /// Such a widget would be used like this: /// -/// ``` +/// ```none /// Items(list: [ "Hello", "World" ]) /// ``` /// @@ -461,7 +461,7 @@ DynamicMap parseDataFile(String file) { /// Loop references use the _ident_. In the example above, that is `item`. In /// more elaborate examples, it can include subreferences. For example: /// -/// ``` +/// ```none /// widget Items = ListView( /// children: [ /// Text(text: 'Products:'), @@ -474,7 +474,7 @@ DynamicMap parseDataFile(String file) { /// /// This might be used as follows: /// -/// ``` +/// ```none /// Items(products: [ /// { name: { abbreviation: "TI4", displayName: "Twilight Imperium IV" }, price: 120.0 }, /// { name: { abbreviation: "POK", displayName: "Prophecy of Kings" }, price: 100.0 }, @@ -490,7 +490,7 @@ DynamicMap parseDataFile(String file) { /// Here a button is described as having a "down" state whose first value is /// "false": /// -/// ``` +/// ```none /// widget Button { down: false } = Container( /// // ... /// ); @@ -503,7 +503,7 @@ DynamicMap parseDataFile(String file) { /// Here, the button's state is referenced (in a pretty nonsensical way; /// controlling whether its label wraps based on the value of the state): /// -/// ``` +/// ```none /// widget Button { down: false } = Container( /// child: Text(text: 'Hello World', softWrap: state.down), /// ); @@ -523,7 +523,7 @@ DynamicMap parseDataFile(String file) { /// /// The syntax for a switch uses the following form: /// -/// ``` +/// ```none /// switch value { /// case1: template1, /// case2: template2, @@ -546,7 +546,7 @@ DynamicMap parseDataFile(String file) { /// appeared pressed when the "down" state was true (but note that we still /// don't have anything to toggle that state!): /// -/// ``` +/// ```none /// widget Button { down: false } = Container( /// margin: switch state.down { /// false: [ 0.0, 0.0, 8.0, 8.0 ], @@ -565,7 +565,7 @@ DynamicMap parseDataFile(String file) { /// /// Signalling event handlers have a name and an arguments map: /// -/// ``` +/// ```none /// event "..." { } /// ``` /// @@ -575,7 +575,7 @@ DynamicMap parseDataFile(String file) { /// For example, the event handler in the following sequence sends the event /// called "hello" with a map containing just one key, "id", whose value is 1: /// -/// ``` +/// ```none /// Button( /// onPressed: event "hello" { id: 1 }, /// child: Text(text: "Greetings"), @@ -586,7 +586,7 @@ DynamicMap parseDataFile(String file) { /// to assign to that state. Such handlers are only meaningful within widgets /// that have state, as described above. They have this form: /// -/// ``` +/// ```none /// set state.foo.bar = value /// ``` /// @@ -595,7 +595,7 @@ DynamicMap parseDataFile(String file) { /// /// This lets us finish the earlier button: /// -/// ``` +/// ```none /// widget Button { down: false } = GestureDetector( /// onTapDown: set state.down = true, /// onTapUp: set state.down = false, diff --git a/packages/web_benchmarks/lib/src/browser.dart b/packages/web_benchmarks/lib/src/browser.dart index 9c575b167b4..272a41d7b2b 100644 --- a/packages/web_benchmarks/lib/src/browser.dart +++ b/packages/web_benchmarks/lib/src/browser.dart @@ -481,7 +481,7 @@ class BlinkTraceEvent { /// /// Sample event encoded as JSON (the data is bogus, this just shows the format): /// - /// ``` + /// ```json /// { /// "name": "myName", /// "cat": "category,list", diff --git a/packages/web_benchmarks/lib/src/recorder.dart b/packages/web_benchmarks/lib/src/recorder.dart index eea86b30731..92a710dbc8b 100644 --- a/packages/web_benchmarks/lib/src/recorder.dart +++ b/packages/web_benchmarks/lib/src/recorder.dart @@ -134,7 +134,7 @@ abstract class Recorder { /// /// Example: /// -/// ``` +/// ```dart /// class BenchForLoop extends RawRecorder { /// BenchForLoop() : super(name: benchmarkName); /// @@ -185,7 +185,7 @@ abstract class RawRecorder extends Recorder { /// /// Example: /// -/// ``` +/// ```dart /// class BenchDrawCircle extends SceneBuilderRecorder { /// BenchDrawCircle() : super(name: benchmarkName); /// @@ -277,7 +277,7 @@ abstract class SceneBuilderRecorder extends Recorder { /// /// Example: /// -/// ``` +/// ```dart /// class BenchListView extends WidgetRecorder { /// BenchListView() : super(name: benchmarkName); /// diff --git a/packages/webview_flutter/webview_flutter_android/lib/src/weak_reference_utils.dart b/packages/webview_flutter/webview_flutter_android/lib/src/weak_reference_utils.dart index fc247f8b60f..f12485ad6e7 100644 --- a/packages/webview_flutter/webview_flutter_android/lib/src/weak_reference_utils.dart +++ b/packages/webview_flutter/webview_flutter_android/lib/src/weak_reference_utils.dart @@ -5,7 +5,7 @@ /// Helper method for creating callbacks methods with a weak reference. /// /// Example: -/// ``` +/// ```dart /// final JavascriptChannelRegistry javascriptChannelRegistry = ... /// /// final WKScriptMessageHandler handler = WKScriptMessageHandler( diff --git a/packages/webview_flutter/webview_flutter_wkwebview/lib/src/common/weak_reference_utils.dart b/packages/webview_flutter/webview_flutter_wkwebview/lib/src/common/weak_reference_utils.dart index fc247f8b60f..f12485ad6e7 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/lib/src/common/weak_reference_utils.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/lib/src/common/weak_reference_utils.dart @@ -5,7 +5,7 @@ /// Helper method for creating callbacks methods with a weak reference. /// /// Example: -/// ``` +/// ```dart /// final JavascriptChannelRegistry javascriptChannelRegistry = ... /// /// final WKScriptMessageHandler handler = WKScriptMessageHandler( diff --git a/script/tool/lib/src/update_release_info_command.dart b/script/tool/lib/src/update_release_info_command.dart index 29ff14389b2..c35759668b6 100644 --- a/script/tool/lib/src/update_release_info_command.dart +++ b/script/tool/lib/src/update_release_info_command.dart @@ -250,7 +250,7 @@ class UpdateReleaseInfoCommand extends PackageLoopingCommand { /// any missing periods. /// /// E.g., 'A line\nAnother line.' will become: - /// ``` + /// ```none /// [ '* A line.', '* Another line.' ] /// ``` Iterable _changelogAdditionsAsList({String listMarker = '*'}) { From 30ecb1a17176a05324d54b1042dbcc36f912df24 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Wed, 23 Oct 2024 22:31:30 +0000 Subject: [PATCH 02/16] Add more code block languages. --- packages/go_router/lib/src/route.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/go_router/lib/src/route.dart b/packages/go_router/lib/src/route.dart index fff33ba7f2b..a5dcc734d05 100644 --- a/packages/go_router/lib/src/route.dart +++ b/packages/go_router/lib/src/route.dart @@ -167,7 +167,7 @@ abstract class RouteBase with Diagnosticable { /// the GoRoute constructor. /// /// For example: - /// ``` + /// ```dart /// final GoRouter _router = GoRouter( /// routes: [ /// GoRoute( @@ -186,7 +186,7 @@ abstract class RouteBase with Diagnosticable { /// redirect takes priority over sub-route's. /// /// For example: - /// ``` + /// ```dart /// final GoRouter _router = GoRouter( /// routes: [ /// GoRoute( From d6ab43422c88e68172a2481f98acb904887b6c6b Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 24 Oct 2024 17:39:43 +0000 Subject: [PATCH 03/16] Change to code block. --- .../lib/src/http_request_factory.dart | 30 ++++++++++--------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart index 1540e547c02..7f810bf3153 100644 --- a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart +++ b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart @@ -38,22 +38,24 @@ class HttpRequestFactory { /// /// If `Access-Control-Expose-Headers` has not been set to true, only a subset of all the response headers will be returned when calling [getAllResponseHeaders]. /// /// The following is equivalent to the [getString] sample above: - /// - /// var name = Uri.encodeQueryComponent('John'); - /// var id = Uri.encodeQueryComponent('42'); - /// HttpRequest.request('users.json?name=$name&id=$id') - /// .then((HttpRequest resp) { - /// // Do something with the response. - /// }); + /// ```dart + /// var name = Uri.encodeQueryComponent('John'); + /// var id = Uri.encodeQueryComponent('42'); + /// HttpRequest.request('users.json?name=$name&id=$id') + /// .then((HttpRequest resp) { + /// // Do something with the response. + /// }); + /// ``` /// /// Here's an example of submitting an entire form with [FormData]. - /// - /// var myForm = querySelector('form#myForm'); - /// var data = new FormData(myForm); - /// HttpRequest.request('/submit', method: 'POST', sendData: data) - /// .then((HttpRequest resp) { - /// // Do something with the response. - /// }); + /// ```dart + /// var myForm = querySelector('form#myForm'); + /// var data = new FormData(myForm); + /// HttpRequest.request('/submit', method: 'POST', sendData: data) + /// .then((HttpRequest resp) { + /// // Do something with the response. + /// }); + /// ``` /// /// Requests for `file://` URIs are only supported by Chrome extensions /// with appropriate permissions in their manifest. Requests to file:// URIs From 32d3c1781e2d286dcb31701b501c1d8325a2a6c7 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 24 Oct 2024 19:27:43 +0000 Subject: [PATCH 04/16] Revert indented code block change --- .../lib/src/http_request_factory.dart | 30 +++++++++---------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart index 7f810bf3153..1540e547c02 100644 --- a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart +++ b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart @@ -38,24 +38,22 @@ class HttpRequestFactory { /// /// If `Access-Control-Expose-Headers` has not been set to true, only a subset of all the response headers will be returned when calling [getAllResponseHeaders]. /// /// The following is equivalent to the [getString] sample above: - /// ```dart - /// var name = Uri.encodeQueryComponent('John'); - /// var id = Uri.encodeQueryComponent('42'); - /// HttpRequest.request('users.json?name=$name&id=$id') - /// .then((HttpRequest resp) { - /// // Do something with the response. - /// }); - /// ``` + /// + /// var name = Uri.encodeQueryComponent('John'); + /// var id = Uri.encodeQueryComponent('42'); + /// HttpRequest.request('users.json?name=$name&id=$id') + /// .then((HttpRequest resp) { + /// // Do something with the response. + /// }); /// /// Here's an example of submitting an entire form with [FormData]. - /// ```dart - /// var myForm = querySelector('form#myForm'); - /// var data = new FormData(myForm); - /// HttpRequest.request('/submit', method: 'POST', sendData: data) - /// .then((HttpRequest resp) { - /// // Do something with the response. - /// }); - /// ``` + /// + /// var myForm = querySelector('form#myForm'); + /// var data = new FormData(myForm); + /// HttpRequest.request('/submit', method: 'POST', sendData: data) + /// .then((HttpRequest resp) { + /// // Do something with the response. + /// }); /// /// Requests for `file://` URIs are only supported by Chrome extensions /// with appropriate permissions in their manifest. Requests to file:// URIs From 080751138b7c63a52386434dfa4c9b602e3ff6ad Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Fri, 25 Oct 2024 18:23:54 +0000 Subject: [PATCH 05/16] Add ignores. --- .../lib/src/interface/process_manager.dart | 6 ++++++ packages/rfw/lib/src/dart/binary.dart | 18 ++++++++++++++++++ .../rfw/lib/src/flutter/material_widgets.dart | 6 ++++++ .../lib/src/http_request_factory.dart | 6 ++++++ 4 files changed, 36 insertions(+) diff --git a/packages/process/lib/src/interface/process_manager.dart b/packages/process/lib/src/interface/process_manager.dart index ba1e2a1099c..94aeb91036c 100644 --- a/packages/process/lib/src/interface/process_manager.dart +++ b/packages/process/lib/src/interface/process_manager.dart @@ -57,6 +57,9 @@ abstract class ProcessManager { /// The following code uses `start` to grep for `main` in the /// file `test.dart` on Linux. /// + // TODO(kallentu): Remove ignore and fix when stable is bumped. + // https://github.com/flutter/flutter/issues/157620 + // ignore: missing_code_block_language_in_doc_comment /// ProcessManager mgr = new LocalProcessManager(); /// mgr.start(['grep', '-i', 'main', 'test.dart']).then((process) { /// stdout.addStream(process.stdout); @@ -130,6 +133,9 @@ abstract class ProcessManager { /// The following code uses `run` to grep for `main` in the /// file `test.dart` on Linux. /// + // TODO(kallentu): Remove ignore and fix when stable is bumped. + // https://github.com/flutter/flutter/issues/157620 + // ignore: missing_code_block_language_in_doc_comment /// ProcessManager mgr = new LocalProcessManager(); /// mgr.run('grep', ['-i', 'main', 'test.dart']).then((result) { /// stdout.write(result.stdout); diff --git a/packages/rfw/lib/src/dart/binary.dart b/packages/rfw/lib/src/dart/binary.dart index a3c64c9b101..251fb81c646 100644 --- a/packages/rfw/lib/src/dart/binary.dart +++ b/packages/rfw/lib/src/dart/binary.dart @@ -115,6 +115,9 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// /// For example, the string "Hello" would be encoded as: /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// 05 00 00 00 00 00 00 00 48 65 6C 6C 6F /// /// * Lists are encoded as an integer length, followed by that many values @@ -124,6 +127,9 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// followed by the value (tagged lists). For example, a list of integers with /// the values 1 and 2 in that order would be encoded as: /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// 02 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 /// 02 00 00 00 00 00 00 00 /// @@ -131,6 +137,9 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// would be encoded as follows; 0x04 is the tag for "String" (the full list /// of tags is described below): /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// 01 00 00 00 00 00 00 00 04 05 00 00 00 00 00 00 /// 00 48 65 6C 6C 6F /// @@ -147,6 +156,9 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// strings, so they are untagged) is encoded as follows (0x02 is the tag for /// integers): /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// 01 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 /// 61 02 0F 00 00 00 00 00 00 00 /// @@ -159,6 +171,9 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// one of the subparts of the imported library name. For example, `import /// a.b` is encoded as: /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// 02 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 /// 61 01 00 00 00 00 00 00 00 62 /// @@ -230,6 +245,9 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// /// ...is encoded as follows (including the tag for the switch itself): /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// 0F 0A 01 00 00 00 00 00 00 00 61 03 00 00 00 00 /// 00 00 00 02 00 00 00 00 00 00 00 00 04 01 00 00 /// 00 00 00 00 00 7A 02 01 00 00 00 00 00 00 00 04 diff --git a/packages/rfw/lib/src/flutter/material_widgets.dart b/packages/rfw/lib/src/flutter/material_widgets.dart index 16132b1ad3c..55ef96e1e54 100644 --- a/packages/rfw/lib/src/flutter/material_widgets.dart +++ b/packages/rfw/lib/src/flutter/material_widgets.dart @@ -64,10 +64,16 @@ import 'runtime.dart'; /// be supported. As a result, the following `ButtonBar` parameters are no longer /// supported: /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// * `buttonMinWidth` /// * `buttonHeight` /// * `buttonAlignedDropdown` /// +// TODO(kallentu): Remove ignore and fix when stable is bumped. +// https://github.com/flutter/flutter/issues/157620 +// ignore: missing_code_block_language_in_doc_comment /// It is recommended to use the [OverflowBar] widget. /// /// Some features are not supported: diff --git a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart index 1540e547c02..d6b18026f59 100644 --- a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart +++ b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart @@ -39,6 +39,9 @@ class HttpRequestFactory { /// /// The following is equivalent to the [getString] sample above: /// + // TODO(kallentu): Remove ignore and fix when stable is bumped. + // https://github.com/flutter/flutter/issues/157620 + // ignore: missing_code_block_language_in_doc_comment /// var name = Uri.encodeQueryComponent('John'); /// var id = Uri.encodeQueryComponent('42'); /// HttpRequest.request('users.json?name=$name&id=$id') @@ -48,6 +51,9 @@ class HttpRequestFactory { /// /// Here's an example of submitting an entire form with [FormData]. /// + // TODO(kallentu): Remove ignore and fix when stable is bumped. + // https://github.com/flutter/flutter/issues/157620 + // ignore: missing_code_block_language_in_doc_comment /// var myForm = querySelector('form#myForm'); /// var data = new FormData(myForm); /// HttpRequest.request('/submit', method: 'POST', sendData: data) From d29187986af6dc4f2dad9952cb481db2cdc8b042 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Fri, 25 Oct 2024 21:15:45 +0000 Subject: [PATCH 06/16] Add changelog and pubspec changes. --- packages/flutter_migrate/CHANGELOG.md | 3 ++- packages/flutter_migrate/pubspec.yaml | 2 +- packages/go_router/CHANGELOG.md | 4 ++++ packages/go_router/pubspec.yaml | 2 +- packages/google_sign_in/google_sign_in/CHANGELOG.md | 3 ++- packages/google_sign_in/google_sign_in/pubspec.yaml | 2 +- .../flutter/ephemeral/.plugin_symlinks/local_auth_windows | 1 - packages/process/CHANGELOG.md | 3 ++- packages/process/pubspec.yaml | 2 +- packages/rfw/CHANGELOG.md | 3 ++- packages/rfw/pubspec.yaml | 2 +- packages/web_benchmarks/CHANGELOG.md | 4 ++++ packages/web_benchmarks/pubspec.yaml | 2 +- packages/webview_flutter/webview_flutter_android/CHANGELOG.md | 4 ++++ packages/webview_flutter/webview_flutter_android/pubspec.yaml | 2 +- 15 files changed, 27 insertions(+), 12 deletions(-) delete mode 120000 packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows diff --git a/packages/flutter_migrate/CHANGELOG.md b/packages/flutter_migrate/CHANGELOG.md index 19b1800df24..3db376d9984 100644 --- a/packages/flutter_migrate/CHANGELOG.md +++ b/packages/flutter_migrate/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 0.0.1+4 +* Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 0.0.1+3 diff --git a/packages/flutter_migrate/pubspec.yaml b/packages/flutter_migrate/pubspec.yaml index 5eae9bd21ba..f1aafdf48cf 100644 --- a/packages/flutter_migrate/pubspec.yaml +++ b/packages/flutter_migrate/pubspec.yaml @@ -1,6 +1,6 @@ name: flutter_migrate description: A tool to migrate legacy flutter projects to modern versions. -version: 0.0.1+3 +version: 0.0.1+4 repository: https://github.com/flutter/packages/tree/main/packages/flutter_migrate issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3Ap%3A%20flutter_migrate publish_to: none diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index 969415b10d5..7f4c3bbfa5b 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,3 +1,7 @@ +## 14.3.0+1 + +- Added `missing_code_block_language_in_doc_comment` lint. + ## 14.3.0 - Added missing implementation for the routerNeglect parameter in GoRouter. diff --git a/packages/go_router/pubspec.yaml b/packages/go_router/pubspec.yaml index 4e086f24559..4c85c928f69 100644 --- a/packages/go_router/pubspec.yaml +++ b/packages/go_router/pubspec.yaml @@ -1,7 +1,7 @@ name: go_router description: A declarative router for Flutter based on Navigation 2 supporting deep linking, data-driven routes and more -version: 14.3.0 +version: 14.3.0+1 repository: https://github.com/flutter/packages/tree/main/packages/go_router issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22 diff --git a/packages/google_sign_in/google_sign_in/CHANGELOG.md b/packages/google_sign_in/google_sign_in/CHANGELOG.md index 67fb3576b74..76104ea2da2 100644 --- a/packages/google_sign_in/google_sign_in/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 6.2.1+1 +* Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. * Updates support matrix in README to indicate that iOS 11 is no longer supported. * Clients on versions of Flutter that still support iOS 11 can continue to use this diff --git a/packages/google_sign_in/google_sign_in/pubspec.yaml b/packages/google_sign_in/google_sign_in/pubspec.yaml index 4161121f685..8a2db6d799c 100644 --- a/packages/google_sign_in/google_sign_in/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system for signing in with a Google account. repository: https://github.com/flutter/packages/tree/main/packages/google_sign_in/google_sign_in issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22 -version: 6.2.1 +version: 6.2.1+1 environment: sdk: ^3.3.0 diff --git a/packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows b/packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows deleted file mode 120000 index 221702bef24..00000000000 --- a/packages/local_auth/local_auth/example/windows/flutter/ephemeral/.plugin_symlinks/local_auth_windows +++ /dev/null @@ -1 +0,0 @@ -/usr/local/google/home/kallentu/.pub-cache/hosted/pub.dev/local_auth_windows-1.0.10/ \ No newline at end of file diff --git a/packages/process/CHANGELOG.md b/packages/process/CHANGELOG.md index 0e8d3bdcaa1..b39c43e16ef 100644 --- a/packages/process/CHANGELOG.md +++ b/packages/process/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 5.0.2+1 +* Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 5.0.2 diff --git a/packages/process/pubspec.yaml b/packages/process/pubspec.yaml index 4686706ea0a..cff255bac26 100644 --- a/packages/process/pubspec.yaml +++ b/packages/process/pubspec.yaml @@ -2,7 +2,7 @@ name: process description: A pluggable, mockable process invocation abstraction for Dart. repository: https://github.com/flutter/packages/tree/main/packages/process issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+process%22 -version: 5.0.2 +version: 5.0.2+1 environment: sdk: ^3.3.0 diff --git a/packages/rfw/CHANGELOG.md b/packages/rfw/CHANGELOG.md index ea4382a2581..20b8184b47f 100644 --- a/packages/rfw/CHANGELOG.md +++ b/packages/rfw/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 1.0.29+1 +* Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 1.0.29 diff --git a/packages/rfw/pubspec.yaml b/packages/rfw/pubspec.yaml index e405a0f6ba3..f414139b39b 100644 --- a/packages/rfw/pubspec.yaml +++ b/packages/rfw/pubspec.yaml @@ -2,7 +2,7 @@ name: rfw description: "Remote Flutter widgets: a library for rendering declarative widget description files at runtime." repository: https://github.com/flutter/packages/tree/main/packages/rfw issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+rfw%22 -version: 1.0.29 +version: 1.0.29+1 environment: sdk: ^3.3.0 diff --git a/packages/web_benchmarks/CHANGELOG.md b/packages/web_benchmarks/CHANGELOG.md index 0096da89124..1e6f4a7d141 100644 --- a/packages/web_benchmarks/CHANGELOG.md +++ b/packages/web_benchmarks/CHANGELOG.md @@ -1,3 +1,7 @@ +## 3.1.0+1 + +* Added `missing_code_block_language_in_doc_comment` lint. + ## 3.1.0 * Add `flutter_frame.total_time`, `flutter_frame.build_time`, and `flutter_frame.raster_time` diff --git a/packages/web_benchmarks/pubspec.yaml b/packages/web_benchmarks/pubspec.yaml index 1ee5ad4aebb..c85b57c1f24 100644 --- a/packages/web_benchmarks/pubspec.yaml +++ b/packages/web_benchmarks/pubspec.yaml @@ -2,7 +2,7 @@ name: web_benchmarks description: A benchmark harness for performance-testing Flutter apps in Chrome. repository: https://github.com/flutter/packages/tree/main/packages/web_benchmarks issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+web_benchmarks%22 -version: 3.1.0 +version: 3.1.0+1 environment: sdk: ^3.3.0 diff --git a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md index a7683435ce2..cd03850a822 100644 --- a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md @@ -1,3 +1,7 @@ +## 4.0.0+1 + +* Added `missing_code_block_language_in_doc_comment` lint. + ## 4.0.0 * Bumps androidx.webkit:webkit from 1.12.0 to 1.12.1. diff --git a/packages/webview_flutter/webview_flutter_android/pubspec.yaml b/packages/webview_flutter/webview_flutter_android/pubspec.yaml index 031ca80375d..8efcdb1231e 100644 --- a/packages/webview_flutter/webview_flutter_android/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_android/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_android description: A Flutter plugin that provides a WebView widget on Android. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 4.0.0 +version: 4.0.0+1 environment: sdk: ^3.5.0 From 838436a176e9a164c0089d1696b206ae8e87a589 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Fri, 25 Oct 2024 21:49:10 +0000 Subject: [PATCH 07/16] Changelog and pubspec for webview_flutter_wkwebview --- .../webview_flutter/webview_flutter_wkwebview/CHANGELOG.md | 4 ++++ .../webview_flutter/webview_flutter_wkwebview/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md b/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md index 3091a1b5a3e..46a17990eb8 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md @@ -1,3 +1,7 @@ +## 3.16.0+1 + +* Added `missing_code_block_language_in_doc_comment` lint. + ## 3.16.0 * Supports NTLM for authentication. diff --git a/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml b/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml index 573c90f04ca..3002167bb2f 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_wkwebview description: A Flutter plugin that provides a WebView widget based on Apple's WKWebView control. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_wkwebview issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 3.16.0 +version: 3.16.0+1 environment: sdk: ^3.5.0 From 03d5fd56c630f7a7b78b32022b68a185b35631af Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Fri, 25 Oct 2024 22:27:30 +0000 Subject: [PATCH 08/16] Update changelogs + pubspecs without +. --- packages/go_router/CHANGELOG.md | 2 +- packages/go_router/pubspec.yaml | 2 +- packages/google_sign_in/google_sign_in/CHANGELOG.md | 2 +- packages/google_sign_in/google_sign_in/pubspec.yaml | 2 +- packages/process/CHANGELOG.md | 2 +- packages/process/pubspec.yaml | 2 +- packages/rfw/CHANGELOG.md | 2 +- packages/rfw/pubspec.yaml | 2 +- packages/web_benchmarks/CHANGELOG.md | 2 +- packages/web_benchmarks/pubspec.yaml | 2 +- packages/webview_flutter/webview_flutter_android/CHANGELOG.md | 2 +- packages/webview_flutter/webview_flutter_android/pubspec.yaml | 2 +- packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md | 2 +- packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml | 2 +- 14 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index 7f4c3bbfa5b..1f74ad2cfe3 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,4 +1,4 @@ -## 14.3.0+1 +## 14.3.1 - Added `missing_code_block_language_in_doc_comment` lint. diff --git a/packages/go_router/pubspec.yaml b/packages/go_router/pubspec.yaml index 4c85c928f69..4b3cb61fcd5 100644 --- a/packages/go_router/pubspec.yaml +++ b/packages/go_router/pubspec.yaml @@ -1,7 +1,7 @@ name: go_router description: A declarative router for Flutter based on Navigation 2 supporting deep linking, data-driven routes and more -version: 14.3.0+1 +version: 14.3.1 repository: https://github.com/flutter/packages/tree/main/packages/go_router issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22 diff --git a/packages/google_sign_in/google_sign_in/CHANGELOG.md b/packages/google_sign_in/google_sign_in/CHANGELOG.md index 76104ea2da2..777851f692d 100644 --- a/packages/google_sign_in/google_sign_in/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in/CHANGELOG.md @@ -1,4 +1,4 @@ -## 6.2.1+1 +## 6.2.2 * Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. diff --git a/packages/google_sign_in/google_sign_in/pubspec.yaml b/packages/google_sign_in/google_sign_in/pubspec.yaml index 8a2db6d799c..c19b4c2b097 100644 --- a/packages/google_sign_in/google_sign_in/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system for signing in with a Google account. repository: https://github.com/flutter/packages/tree/main/packages/google_sign_in/google_sign_in issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22 -version: 6.2.1+1 +version: 6.2.2 environment: sdk: ^3.3.0 diff --git a/packages/process/CHANGELOG.md b/packages/process/CHANGELOG.md index b39c43e16ef..94bb16f77aa 100644 --- a/packages/process/CHANGELOG.md +++ b/packages/process/CHANGELOG.md @@ -1,4 +1,4 @@ -## 5.0.2+1 +## 5.0.3 * Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. diff --git a/packages/process/pubspec.yaml b/packages/process/pubspec.yaml index cff255bac26..4c5296dc7da 100644 --- a/packages/process/pubspec.yaml +++ b/packages/process/pubspec.yaml @@ -2,7 +2,7 @@ name: process description: A pluggable, mockable process invocation abstraction for Dart. repository: https://github.com/flutter/packages/tree/main/packages/process issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+process%22 -version: 5.0.2+1 +version: 5.0.3 environment: sdk: ^3.3.0 diff --git a/packages/rfw/CHANGELOG.md b/packages/rfw/CHANGELOG.md index 20b8184b47f..6810207b01b 100644 --- a/packages/rfw/CHANGELOG.md +++ b/packages/rfw/CHANGELOG.md @@ -1,4 +1,4 @@ -## 1.0.29+1 +## 1.0.30 * Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. diff --git a/packages/rfw/pubspec.yaml b/packages/rfw/pubspec.yaml index f414139b39b..76afa865e10 100644 --- a/packages/rfw/pubspec.yaml +++ b/packages/rfw/pubspec.yaml @@ -2,7 +2,7 @@ name: rfw description: "Remote Flutter widgets: a library for rendering declarative widget description files at runtime." repository: https://github.com/flutter/packages/tree/main/packages/rfw issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+rfw%22 -version: 1.0.29+1 +version: 1.0.30 environment: sdk: ^3.3.0 diff --git a/packages/web_benchmarks/CHANGELOG.md b/packages/web_benchmarks/CHANGELOG.md index 1e6f4a7d141..b41c2c41df9 100644 --- a/packages/web_benchmarks/CHANGELOG.md +++ b/packages/web_benchmarks/CHANGELOG.md @@ -1,4 +1,4 @@ -## 3.1.0+1 +## 3.1.1 * Added `missing_code_block_language_in_doc_comment` lint. diff --git a/packages/web_benchmarks/pubspec.yaml b/packages/web_benchmarks/pubspec.yaml index c85b57c1f24..1fdc26d8201 100644 --- a/packages/web_benchmarks/pubspec.yaml +++ b/packages/web_benchmarks/pubspec.yaml @@ -2,7 +2,7 @@ name: web_benchmarks description: A benchmark harness for performance-testing Flutter apps in Chrome. repository: https://github.com/flutter/packages/tree/main/packages/web_benchmarks issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+web_benchmarks%22 -version: 3.1.0+1 +version: 3.1.1 environment: sdk: ^3.3.0 diff --git a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md index cd03850a822..c79b57d4420 100644 --- a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md @@ -1,4 +1,4 @@ -## 4.0.0+1 +## 4.0.1 * Added `missing_code_block_language_in_doc_comment` lint. diff --git a/packages/webview_flutter/webview_flutter_android/pubspec.yaml b/packages/webview_flutter/webview_flutter_android/pubspec.yaml index 8efcdb1231e..2b8bf262b1c 100644 --- a/packages/webview_flutter/webview_flutter_android/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_android/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_android description: A Flutter plugin that provides a WebView widget on Android. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 4.0.0+1 +version: 4.0.1 environment: sdk: ^3.5.0 diff --git a/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md b/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md index 46a17990eb8..53626ccd62e 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md @@ -1,4 +1,4 @@ -## 3.16.0+1 +## 3.16.1 * Added `missing_code_block_language_in_doc_comment` lint. diff --git a/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml b/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml index 3002167bb2f..b07e68045fe 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_wkwebview description: A Flutter plugin that provides a WebView widget based on Apple's WKWebView control. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_wkwebview issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 3.16.0+1 +version: 3.16.1 environment: sdk: ^3.5.0 From 9b772571e3c1ca53d7fe1c94c1b8d03af255da70 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 31 Oct 2024 18:32:13 +0000 Subject: [PATCH 09/16] Update tense in changelog, remove some version changes. --- packages/flutter_migrate/CHANGELOG.md | 2 +- packages/go_router/CHANGELOG.md | 2 +- packages/google_sign_in/google_sign_in/CHANGELOG.md | 2 +- packages/process/CHANGELOG.md | 3 +-- packages/process/pubspec.yaml | 2 +- packages/rfw/CHANGELOG.md | 2 +- packages/web_benchmarks/CHANGELOG.md | 2 +- .../webview_flutter/webview_flutter_android/CHANGELOG.md | 6 +----- .../webview_flutter/webview_flutter_android/pubspec.yaml | 2 +- .../webview_flutter/webview_flutter_wkwebview/CHANGELOG.md | 2 +- 10 files changed, 10 insertions(+), 15 deletions(-) diff --git a/packages/flutter_migrate/CHANGELOG.md b/packages/flutter_migrate/CHANGELOG.md index 3db376d9984..2d132e53fc1 100644 --- a/packages/flutter_migrate/CHANGELOG.md +++ b/packages/flutter_migrate/CHANGELOG.md @@ -1,6 +1,6 @@ ## 0.0.1+4 -* Added `missing_code_block_language_in_doc_comment` lint. +* Adds `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 0.0.1+3 diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index 1f74ad2cfe3..07f73fea29e 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,6 +1,6 @@ ## 14.3.1 -- Added `missing_code_block_language_in_doc_comment` lint. +- Adds `missing_code_block_language_in_doc_comment` lint. ## 14.3.0 diff --git a/packages/google_sign_in/google_sign_in/CHANGELOG.md b/packages/google_sign_in/google_sign_in/CHANGELOG.md index 777851f692d..24564442c8f 100644 --- a/packages/google_sign_in/google_sign_in/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in/CHANGELOG.md @@ -1,6 +1,6 @@ ## 6.2.2 -* Added `missing_code_block_language_in_doc_comment` lint. +* Adds `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. * Updates support matrix in README to indicate that iOS 11 is no longer supported. * Clients on versions of Flutter that still support iOS 11 can continue to use this diff --git a/packages/process/CHANGELOG.md b/packages/process/CHANGELOG.md index 94bb16f77aa..0e8d3bdcaa1 100644 --- a/packages/process/CHANGELOG.md +++ b/packages/process/CHANGELOG.md @@ -1,6 +1,5 @@ -## 5.0.3 +## NEXT -* Added `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 5.0.2 diff --git a/packages/process/pubspec.yaml b/packages/process/pubspec.yaml index 4c5296dc7da..4686706ea0a 100644 --- a/packages/process/pubspec.yaml +++ b/packages/process/pubspec.yaml @@ -2,7 +2,7 @@ name: process description: A pluggable, mockable process invocation abstraction for Dart. repository: https://github.com/flutter/packages/tree/main/packages/process issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+process%22 -version: 5.0.3 +version: 5.0.2 environment: sdk: ^3.3.0 diff --git a/packages/rfw/CHANGELOG.md b/packages/rfw/CHANGELOG.md index 6810207b01b..e3fbedffe13 100644 --- a/packages/rfw/CHANGELOG.md +++ b/packages/rfw/CHANGELOG.md @@ -1,6 +1,6 @@ ## 1.0.30 -* Added `missing_code_block_language_in_doc_comment` lint. +* Adds `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 1.0.29 diff --git a/packages/web_benchmarks/CHANGELOG.md b/packages/web_benchmarks/CHANGELOG.md index b41c2c41df9..0c85d439909 100644 --- a/packages/web_benchmarks/CHANGELOG.md +++ b/packages/web_benchmarks/CHANGELOG.md @@ -1,6 +1,6 @@ ## 3.1.1 -* Added `missing_code_block_language_in_doc_comment` lint. +* Adds `missing_code_block_language_in_doc_comment` lint. ## 3.1.0 diff --git a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md index c79b57d4420..1766840c3e7 100644 --- a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md @@ -1,8 +1,4 @@ -## 4.0.1 - -* Added `missing_code_block_language_in_doc_comment` lint. - -## 4.0.0 +# 4.0.0 * Bumps androidx.webkit:webkit from 1.12.0 to 1.12.1. * **Breaking Change** Bumps Android `minSdkVersion` from 19 to 21. diff --git a/packages/webview_flutter/webview_flutter_android/pubspec.yaml b/packages/webview_flutter/webview_flutter_android/pubspec.yaml index 2b8bf262b1c..031ca80375d 100644 --- a/packages/webview_flutter/webview_flutter_android/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_android/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_android description: A Flutter plugin that provides a WebView widget on Android. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 4.0.1 +version: 4.0.0 environment: sdk: ^3.5.0 diff --git a/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md b/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md index 53626ccd62e..134f22aad28 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md @@ -1,6 +1,6 @@ ## 3.16.1 -* Added `missing_code_block_language_in_doc_comment` lint. +* Adds `missing_code_block_language_in_doc_comment` lint. ## 3.16.0 From 5cd3799cff3c0d65241caf2990bdc0eae114fbb7 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 31 Oct 2024 20:07:56 +0000 Subject: [PATCH 10/16] Fix typo. --- packages/webview_flutter/webview_flutter_android/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md index 1766840c3e7..a7683435ce2 100644 --- a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md @@ -1,4 +1,4 @@ -# 4.0.0 +## 4.0.0 * Bumps androidx.webkit:webkit from 1.12.0 to 1.12.1. * **Breaking Change** Bumps Android `minSdkVersion` from 19 to 21. From 79af3d1a90a155f64a698f9cc05733768a0055b6 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 31 Oct 2024 20:09:40 +0000 Subject: [PATCH 11/16] Update version for android. --- packages/webview_flutter/webview_flutter_android/CHANGELOG.md | 4 ++++ packages/webview_flutter/webview_flutter_android/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md index a7683435ce2..c660eb72f10 100644 --- a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md @@ -1,3 +1,7 @@ +## 4.0.1 + +* Adds `missing_code_block_language_in_doc_comment` lint. + ## 4.0.0 * Bumps androidx.webkit:webkit from 1.12.0 to 1.12.1. diff --git a/packages/webview_flutter/webview_flutter_android/pubspec.yaml b/packages/webview_flutter/webview_flutter_android/pubspec.yaml index 031ca80375d..2b8bf262b1c 100644 --- a/packages/webview_flutter/webview_flutter_android/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_android/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_android description: A Flutter plugin that provides a WebView widget on Android. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 4.0.0 +version: 4.0.1 environment: sdk: ^3.5.0 From f4fb9f5ac8beac28b76aaca737a974edfd02e50a Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 31 Oct 2024 22:32:57 +0000 Subject: [PATCH 12/16] Change some lints into fenced code blocks. --- packages/process/CHANGELOG.md | 3 +- .../lib/src/interface/process_manager.dart | 30 ++-- packages/process/pubspec.yaml | 2 +- packages/rfw/lib/src/dart/binary.dart | 133 ++++++++++-------- .../webview_flutter_web/CHANGELOG.md | 3 +- .../lib/src/http_request_factory.dart | 34 +++-- .../webview_flutter_web/pubspec.yaml | 2 +- 7 files changed, 110 insertions(+), 97 deletions(-) diff --git a/packages/process/CHANGELOG.md b/packages/process/CHANGELOG.md index 0e8d3bdcaa1..603c5efc8ae 100644 --- a/packages/process/CHANGELOG.md +++ b/packages/process/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 5.0.3 +* Adds `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 5.0.2 diff --git a/packages/process/lib/src/interface/process_manager.dart b/packages/process/lib/src/interface/process_manager.dart index 94aeb91036c..d506cdc20f0 100644 --- a/packages/process/lib/src/interface/process_manager.dart +++ b/packages/process/lib/src/interface/process_manager.dart @@ -57,14 +57,13 @@ abstract class ProcessManager { /// The following code uses `start` to grep for `main` in the /// file `test.dart` on Linux. /// - // TODO(kallentu): Remove ignore and fix when stable is bumped. - // https://github.com/flutter/flutter/issues/157620 - // ignore: missing_code_block_language_in_doc_comment - /// ProcessManager mgr = new LocalProcessManager(); - /// mgr.start(['grep', '-i', 'main', 'test.dart']).then((process) { - /// stdout.addStream(process.stdout); - /// stderr.addStream(process.stderr); - /// }); + /// ```dart + /// ProcessManager mgr = new LocalProcessManager(); + /// mgr.start(['grep', '-i', 'main', 'test.dart']).then((process) { + /// stdout.addStream(process.stdout); + /// stderr.addStream(process.stderr); + /// }); + /// ``` /// /// If [mode] is [ProcessStartMode.normal] (the default) a child /// process will be started with `stdin`, `stdout` and `stderr` @@ -133,14 +132,13 @@ abstract class ProcessManager { /// The following code uses `run` to grep for `main` in the /// file `test.dart` on Linux. /// - // TODO(kallentu): Remove ignore and fix when stable is bumped. - // https://github.com/flutter/flutter/issues/157620 - // ignore: missing_code_block_language_in_doc_comment - /// ProcessManager mgr = new LocalProcessManager(); - /// mgr.run('grep', ['-i', 'main', 'test.dart']).then((result) { - /// stdout.write(result.stdout); - /// stderr.write(result.stderr); - /// }); + /// ```dart + /// ProcessManager mgr = new LocalProcessManager(); + /// mgr.run('grep', ['-i', 'main', 'test.dart']).then((result) { + /// stdout.write(result.stdout); + /// stderr.write(result.stderr); + /// }); + /// ``` Future run( List command, { String? workingDirectory, diff --git a/packages/process/pubspec.yaml b/packages/process/pubspec.yaml index 4686706ea0a..4c5296dc7da 100644 --- a/packages/process/pubspec.yaml +++ b/packages/process/pubspec.yaml @@ -2,7 +2,7 @@ name: process description: A pluggable, mockable process invocation abstraction for Dart. repository: https://github.com/flutter/packages/tree/main/packages/process issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+process%22 -version: 5.0.2 +version: 5.0.3 environment: sdk: ^3.3.0 diff --git a/packages/rfw/lib/src/dart/binary.dart b/packages/rfw/lib/src/dart/binary.dart index 251fb81c646..a3efe8237f2 100644 --- a/packages/rfw/lib/src/dart/binary.dart +++ b/packages/rfw/lib/src/dart/binary.dart @@ -65,7 +65,8 @@ Uint8List encodeDataBlob(Object value) { /// Remote Flutter Widgets binary library blobs. /// * [parseDataFile], which parses the text variant of this format. Object decodeDataBlob(Uint8List bytes) { - final _BlobDecoder decoder = _BlobDecoder(bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); + final _BlobDecoder decoder = _BlobDecoder( + bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); decoder.expectSignature(dataBlobSignature); final Object result = decoder.readValue(); if (!decoder.finished) { @@ -115,10 +116,9 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// /// For example, the string "Hello" would be encoded as: /// -// TODO(kallentu): Remove ignore and fix when stable is bumped. -// https://github.com/flutter/flutter/issues/157620 -// ignore: missing_code_block_language_in_doc_comment -/// 05 00 00 00 00 00 00 00 48 65 6C 6C 6F +/// ```none +/// 05 00 00 00 00 00 00 00 48 65 6C 6C 6F +/// ``` /// /// * Lists are encoded as an integer length, followed by that many values /// back to back. When lists are of specific types (e.g. lists of imports), @@ -127,21 +127,19 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// followed by the value (tagged lists). For example, a list of integers with /// the values 1 and 2 in that order would be encoded as: /// -// TODO(kallentu): Remove ignore and fix when stable is bumped. -// https://github.com/flutter/flutter/issues/157620 -// ignore: missing_code_block_language_in_doc_comment -/// 02 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 -/// 02 00 00 00 00 00 00 00 +/// ```none +/// 02 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 +/// 02 00 00 00 00 00 00 00 +/// ``` /// /// A list of arbitrary values that happens to contain one string "Hello" /// would be encoded as follows; 0x04 is the tag for "String" (the full list /// of tags is described below): /// -// TODO(kallentu): Remove ignore and fix when stable is bumped. -// https://github.com/flutter/flutter/issues/157620 -// ignore: missing_code_block_language_in_doc_comment -/// 01 00 00 00 00 00 00 00 04 05 00 00 00 00 00 00 -/// 00 48 65 6C 6C 6F +/// ```none +/// 01 00 00 00 00 00 00 00 04 05 00 00 00 00 00 00 +/// 00 48 65 6C 6C 6F +/// ``` /// /// A list of length zero is eight zero bytes with no additional payload. /// @@ -156,11 +154,10 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// strings, so they are untagged) is encoded as follows (0x02 is the tag for /// integers): /// -// TODO(kallentu): Remove ignore and fix when stable is bumped. -// https://github.com/flutter/flutter/issues/157620 -// ignore: missing_code_block_language_in_doc_comment -/// 01 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 -/// 61 02 0F 00 00 00 00 00 00 00 +/// ```none +/// 01 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 +/// 61 02 0F 00 00 00 00 00 00 00 +/// ``` /// /// Objects are encoded as follows: /// @@ -171,11 +168,10 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// one of the subparts of the imported library name. For example, `import /// a.b` is encoded as: /// -// TODO(kallentu): Remove ignore and fix when stable is bumped. -// https://github.com/flutter/flutter/issues/157620 -// ignore: missing_code_block_language_in_doc_comment -/// 02 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 -/// 61 01 00 00 00 00 00 00 00 62 +/// ```none +/// 02 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 +/// 61 01 00 00 00 00 00 00 00 62 +/// ``` /// /// * Widget declarations are encoded as a string giving the declaration name, /// an untagged map for the initial state, and finally the value that @@ -245,14 +241,13 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// /// ...is encoded as follows (including the tag for the switch itself): /// -// TODO(kallentu): Remove ignore and fix when stable is bumped. -// https://github.com/flutter/flutter/issues/157620 -// ignore: missing_code_block_language_in_doc_comment -/// 0F 0A 01 00 00 00 00 00 00 00 61 03 00 00 00 00 -/// 00 00 00 02 00 00 00 00 00 00 00 00 04 01 00 00 -/// 00 00 00 00 00 7A 02 01 00 00 00 00 00 00 00 04 -/// 01 00 00 00 00 00 00 00 6F 10 04 01 00 00 00 00 -/// 00 00 00 64 +/// ```none +/// 0F 0A 01 00 00 00 00 00 00 00 61 03 00 00 00 00 +/// 00 00 00 02 00 00 00 00 00 00 00 00 04 01 00 00 +/// 00 00 00 00 00 7A 02 01 00 00 00 00 00 00 00 04 +/// 01 00 00 00 00 00 00 00 6F 10 04 01 00 00 00 00 +/// 00 00 00 64 +/// ``` /// /// * Event handlers have the tag 0x0E, and are encoded as a string /// ([EventHandler.eventName]) and an untagged map @@ -282,11 +277,13 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// Remote Flutter Widgets binary data blobs. /// * [parseDataFile], which parses the text variant of this format. RemoteWidgetLibrary decodeLibraryBlob(Uint8List bytes) { - final _BlobDecoder decoder = _BlobDecoder(bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); + final _BlobDecoder decoder = _BlobDecoder( + bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); decoder.expectSignature(libraryBlobSignature); final RemoteWidgetLibrary result = decoder.readLibrary(); if (!decoder.finished) { - throw const FormatException('Unexpected trailing bytes after constructors.'); + throw const FormatException( + 'Unexpected trailing bytes after constructors.'); } return result; } @@ -338,7 +335,8 @@ class _BlobDecoder { void _advance(String context, int length) { if (_cursor + length > bytes.lengthInBytes) { - throw FormatException('Could not read $context at offset $_cursor: unexpected end of file.'); + throw FormatException( + 'Could not read $context at offset $_cursor: unexpected end of file.'); } _cursor += length; } @@ -357,8 +355,10 @@ class _BlobDecoder { } // We use multiplication rather than bit shifts because << truncates to 32 bits when compiled to JS: // https://dart.dev/guides/language/numbers#bitwise-operations - final int a = bytes.getUint32(byteOffset, _blobEndian); // dead code on VM target - final int b = bytes.getInt32(byteOffset + 4, _blobEndian); // dead code on VM target + final int a = + bytes.getUint32(byteOffset, _blobEndian); // dead code on VM target + final int b = + bytes.getInt32(byteOffset + 4, _blobEndian); // dead code on VM target return a + (b * 0x100000000); // dead code on VM target } @@ -372,7 +372,8 @@ class _BlobDecoder { final int length = _readInt64(); final int byteOffset = _cursor; _advance('string', length); - return utf8.decode(bytes.buffer.asUint8List(bytes.offsetInBytes + byteOffset, length)); + return utf8.decode( + bytes.buffer.asUint8List(bytes.offsetInBytes + byteOffset, length)); } List _readPartList() { @@ -384,12 +385,14 @@ class _BlobDecoder { case _msInt64: return _readInt64(); default: - throw FormatException('Invalid reference type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); + throw FormatException( + 'Invalid reference type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); } }); } - Map? _readMap(Object Function() readNode, { bool nullIfEmpty = false }) { + Map? _readMap(Object Function() readNode, + {bool nullIfEmpty = false}) { final int count = _readInt64(); if (count == 0 && nullIfEmpty) { return null; @@ -444,7 +447,9 @@ class _BlobDecoder { return DynamicList.generate(_readInt64(), (int index) => readNode()); case _msMap: return _readMap(readNode)!; - default: throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); + default: + throw FormatException( + 'Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); } } @@ -472,7 +477,8 @@ class _BlobDecoder { case _msSwitch: return _readSwitch(); case _msSetState: - return SetStateHandler(StateReference(_readPartList()), _readArgument()); + return SetStateHandler( + StateReference(_readPartList()), _readArgument()); case _msWidgetBuilder: return _readWidgetBuilder(); case _msWidgetBuilderArgReference: @@ -496,7 +502,8 @@ class _BlobDecoder { final String argumentName = _readString(); final int type = _readByte(); if (type != _msWidget && type != _msSwitch) { - throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget builder blob.'); + throw FormatException( + 'Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget builder blob.'); } final BlobNode widget = type == _msWidget ? _readWidget() : _readSwitch(); return WidgetBuilderDeclaration(argumentName, widget); @@ -513,17 +520,20 @@ class _BlobDecoder { case _msWidget: root = _readWidget(); default: - throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget declaration root.'); + throw FormatException( + 'Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget declaration root.'); } return WidgetDeclaration(name, initialState, root); } List _readDeclarationList() { - return List.generate(_readInt64(), (int index) => _readDeclaration()); + return List.generate( + _readInt64(), (int index) => _readDeclaration()); } Import _readImport() { - return Import(LibraryName(List.generate(_readInt64(), (int index) => _readString()))); + return Import(LibraryName( + List.generate(_readInt64(), (int index) => _readString()))); } List _readImportList() { @@ -546,11 +556,9 @@ class _BlobDecoder { } } if (!match) { - throw FormatException( - 'File signature mismatch. ' - 'Expected ${signature.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")} ' - 'but found ${bytes.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")}.' - ); + throw FormatException('File signature mismatch. ' + 'Expected ${signature.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")} ' + 'but found ${bytes.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")}.'); } } } @@ -566,9 +574,11 @@ class _BlobEncoder { _BlobEncoder(); static final Uint8List _scratchOut = Uint8List(8); - static final ByteData _scratchIn = _scratchOut.buffer.asByteData(_scratchOut.offsetInBytes, _scratchOut.lengthInBytes); + static final ByteData _scratchIn = _scratchOut.buffer + .asByteData(_scratchOut.offsetInBytes, _scratchOut.lengthInBytes); - final BytesBuilder bytes = BytesBuilder(); // copying builder -- we repeatedly add _scratchOut after changing it + final BytesBuilder bytes = + BytesBuilder(); // copying builder -- we repeatedly add _scratchOut after changing it void _writeInt64(int value) { if (_has64Bits) { @@ -576,12 +586,15 @@ class _BlobEncoder { } else { // We use division rather than bit shifts because >> truncates to 32 bits when compiled to JS: // https://dart.dev/guides/language/numbers#bitwise-operations - if (value >= 0) { // dead code on VM target + if (value >= 0) { + // dead code on VM target _scratchIn.setInt32(0, value, _blobEndian); // dead code on VM target - _scratchIn.setInt32(4, value ~/ 0x100000000, _blobEndian); // dead code on VM target + _scratchIn.setInt32( + 4, value ~/ 0x100000000, _blobEndian); // dead code on VM target } else { _scratchIn.setInt32(0, value, _blobEndian); // dead code on VM target - _scratchIn.setInt32(4, -((-value) ~/ 0x100000000 + 1), _blobEndian); // dead code on VM target + _scratchIn.setInt32(4, -((-value) ~/ 0x100000000 + 1), + _blobEndian); // dead code on VM target } } bytes.add(_scratchOut); @@ -609,7 +622,8 @@ class _BlobEncoder { bytes.addByte(_msString); _writeString(value); } else { - throw StateError('Unexpected type ${value.runtimeType} while encoding blob.'); + throw StateError( + 'Unexpected type ${value.runtimeType} while encoding blob.'); } } @@ -618,7 +632,8 @@ class _BlobEncoder { bytes.addByte(_msFalse); } else if (value == true) { bytes.addByte(_msTrue); - } else if (value is double && value is! int) { // When compiled to JS, a Number can be both. + } else if (value is double && value is! int) { + // When compiled to JS, a Number can be both. bytes.addByte(_msBinary64); _scratchIn.setFloat64(0, value, _blobEndian); bytes.add(_scratchOut); diff --git a/packages/webview_flutter/webview_flutter_web/CHANGELOG.md b/packages/webview_flutter/webview_flutter_web/CHANGELOG.md index adabb359654..abe9eee1f0c 100644 --- a/packages/webview_flutter/webview_flutter_web/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_web/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 0.2.3+3 +* Adds `missing_code_block_language_in_doc_comment` lint. * Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. ## 0.2.3+2 diff --git a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart index d6b18026f59..1500921201b 100644 --- a/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart +++ b/packages/webview_flutter/webview_flutter_web/lib/src/http_request_factory.dart @@ -39,27 +39,25 @@ class HttpRequestFactory { /// /// The following is equivalent to the [getString] sample above: /// - // TODO(kallentu): Remove ignore and fix when stable is bumped. - // https://github.com/flutter/flutter/issues/157620 - // ignore: missing_code_block_language_in_doc_comment - /// var name = Uri.encodeQueryComponent('John'); - /// var id = Uri.encodeQueryComponent('42'); - /// HttpRequest.request('users.json?name=$name&id=$id') - /// .then((HttpRequest resp) { - /// // Do something with the response. - /// }); + /// ```dart + /// var name = Uri.encodeQueryComponent('John'); + /// var id = Uri.encodeQueryComponent('42'); + /// HttpRequest.request('users.json?name=$name&id=$id') + /// .then((HttpRequest resp) { + /// // Do something with the response. + /// }); + /// ``` /// /// Here's an example of submitting an entire form with [FormData]. /// - // TODO(kallentu): Remove ignore and fix when stable is bumped. - // https://github.com/flutter/flutter/issues/157620 - // ignore: missing_code_block_language_in_doc_comment - /// var myForm = querySelector('form#myForm'); - /// var data = new FormData(myForm); - /// HttpRequest.request('/submit', method: 'POST', sendData: data) - /// .then((HttpRequest resp) { - /// // Do something with the response. - /// }); + /// ```dart + /// var myForm = querySelector('form#myForm'); + /// var data = new FormData(myForm); + /// HttpRequest.request('/submit', method: 'POST', sendData: data) + /// .then((HttpRequest resp) { + /// // Do something with the response. + /// }); + /// ``` /// /// Requests for `file://` URIs are only supported by Chrome extensions /// with appropriate permissions in their manifest. Requests to file:// URIs diff --git a/packages/webview_flutter/webview_flutter_web/pubspec.yaml b/packages/webview_flutter/webview_flutter_web/pubspec.yaml index dccc235789b..6ca56109b37 100644 --- a/packages/webview_flutter/webview_flutter_web/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_web/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_web description: A Flutter plugin that provides a WebView widget on web. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_web issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 0.2.3+2 +version: 0.2.3+3 environment: sdk: ^3.4.0 From 33c1f1ec0b45214f1a630f0828c208b824f9a432 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 31 Oct 2024 22:40:14 +0000 Subject: [PATCH 13/16] Unformat, ugh. --- packages/rfw/lib/src/dart/binary.dart | 74 ++++++++++----------------- 1 file changed, 27 insertions(+), 47 deletions(-) diff --git a/packages/rfw/lib/src/dart/binary.dart b/packages/rfw/lib/src/dart/binary.dart index a3efe8237f2..7187488fb83 100644 --- a/packages/rfw/lib/src/dart/binary.dart +++ b/packages/rfw/lib/src/dart/binary.dart @@ -65,8 +65,7 @@ Uint8List encodeDataBlob(Object value) { /// Remote Flutter Widgets binary library blobs. /// * [parseDataFile], which parses the text variant of this format. Object decodeDataBlob(Uint8List bytes) { - final _BlobDecoder decoder = _BlobDecoder( - bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); + final _BlobDecoder decoder = _BlobDecoder(bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); decoder.expectSignature(dataBlobSignature); final Object result = decoder.readValue(); if (!decoder.finished) { @@ -277,13 +276,11 @@ Uint8List encodeLibraryBlob(RemoteWidgetLibrary value) { /// Remote Flutter Widgets binary data blobs. /// * [parseDataFile], which parses the text variant of this format. RemoteWidgetLibrary decodeLibraryBlob(Uint8List bytes) { - final _BlobDecoder decoder = _BlobDecoder( - bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); + final _BlobDecoder decoder = _BlobDecoder(bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes)); decoder.expectSignature(libraryBlobSignature); final RemoteWidgetLibrary result = decoder.readLibrary(); if (!decoder.finished) { - throw const FormatException( - 'Unexpected trailing bytes after constructors.'); + throw const FormatException('Unexpected trailing bytes after constructors.'); } return result; } @@ -335,8 +332,7 @@ class _BlobDecoder { void _advance(String context, int length) { if (_cursor + length > bytes.lengthInBytes) { - throw FormatException( - 'Could not read $context at offset $_cursor: unexpected end of file.'); + throw FormatException('Could not read $context at offset $_cursor: unexpected end of file.'); } _cursor += length; } @@ -355,10 +351,8 @@ class _BlobDecoder { } // We use multiplication rather than bit shifts because << truncates to 32 bits when compiled to JS: // https://dart.dev/guides/language/numbers#bitwise-operations - final int a = - bytes.getUint32(byteOffset, _blobEndian); // dead code on VM target - final int b = - bytes.getInt32(byteOffset + 4, _blobEndian); // dead code on VM target + final int a = bytes.getUint32(byteOffset, _blobEndian); // dead code on VM target + final int b = bytes.getInt32(byteOffset + 4, _blobEndian); // dead code on VM target return a + (b * 0x100000000); // dead code on VM target } @@ -372,8 +366,7 @@ class _BlobDecoder { final int length = _readInt64(); final int byteOffset = _cursor; _advance('string', length); - return utf8.decode( - bytes.buffer.asUint8List(bytes.offsetInBytes + byteOffset, length)); + return utf8.decode(bytes.buffer.asUint8List(bytes.offsetInBytes + byteOffset, length)); } List _readPartList() { @@ -385,14 +378,12 @@ class _BlobDecoder { case _msInt64: return _readInt64(); default: - throw FormatException( - 'Invalid reference type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); + throw FormatException('Invalid reference type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); } }); } - Map? _readMap(Object Function() readNode, - {bool nullIfEmpty = false}) { + Map? _readMap(Object Function() readNode, { bool nullIfEmpty = false }) { final int count = _readInt64(); if (count == 0 && nullIfEmpty) { return null; @@ -448,8 +439,7 @@ class _BlobDecoder { case _msMap: return _readMap(readNode)!; default: - throw FormatException( - 'Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); + throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); } } @@ -477,8 +467,7 @@ class _BlobDecoder { case _msSwitch: return _readSwitch(); case _msSetState: - return SetStateHandler( - StateReference(_readPartList()), _readArgument()); + return SetStateHandler(StateReference(_readPartList()), _readArgument()); case _msWidgetBuilder: return _readWidgetBuilder(); case _msWidgetBuilderArgReference: @@ -502,8 +491,7 @@ class _BlobDecoder { final String argumentName = _readString(); final int type = _readByte(); if (type != _msWidget && type != _msSwitch) { - throw FormatException( - 'Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget builder blob.'); + throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget builder blob.'); } final BlobNode widget = type == _msWidget ? _readWidget() : _readSwitch(); return WidgetBuilderDeclaration(argumentName, widget); @@ -520,20 +508,17 @@ class _BlobDecoder { case _msWidget: root = _readWidget(); default: - throw FormatException( - 'Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget declaration root.'); + throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding widget declaration root.'); } return WidgetDeclaration(name, initialState, root); } List _readDeclarationList() { - return List.generate( - _readInt64(), (int index) => _readDeclaration()); + return List.generate(_readInt64(), (int index) => _readDeclaration()); } Import _readImport() { - return Import(LibraryName( - List.generate(_readInt64(), (int index) => _readString()))); + return Import(LibraryName(List.generate(_readInt64(), (int index) => _readString()))); } List _readImportList() { @@ -556,9 +541,11 @@ class _BlobDecoder { } } if (!match) { - throw FormatException('File signature mismatch. ' - 'Expected ${signature.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")} ' - 'but found ${bytes.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")}.'); + throw FormatException( + 'File signature mismatch. ' + 'Expected ${signature.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")} ' + 'but found ${bytes.map((int byte) => byte.toRadixString(16).toUpperCase().padLeft(2, "0")).join(" ")}.' + ); } } } @@ -574,11 +561,9 @@ class _BlobEncoder { _BlobEncoder(); static final Uint8List _scratchOut = Uint8List(8); - static final ByteData _scratchIn = _scratchOut.buffer - .asByteData(_scratchOut.offsetInBytes, _scratchOut.lengthInBytes); + static final ByteData _scratchIn = _scratchOut.buffer.asByteData(_scratchOut.offsetInBytes, _scratchOut.lengthInBytes); - final BytesBuilder bytes = - BytesBuilder(); // copying builder -- we repeatedly add _scratchOut after changing it + final BytesBuilder bytes = BytesBuilder(); // copying builder -- we repeatedly add _scratchOut after changing it void _writeInt64(int value) { if (_has64Bits) { @@ -586,15 +571,12 @@ class _BlobEncoder { } else { // We use division rather than bit shifts because >> truncates to 32 bits when compiled to JS: // https://dart.dev/guides/language/numbers#bitwise-operations - if (value >= 0) { - // dead code on VM target + if (value >= 0) { // dead code on VM target _scratchIn.setInt32(0, value, _blobEndian); // dead code on VM target - _scratchIn.setInt32( - 4, value ~/ 0x100000000, _blobEndian); // dead code on VM target + _scratchIn.setInt32(4, value ~/ 0x100000000, _blobEndian); // dead code on VM target } else { _scratchIn.setInt32(0, value, _blobEndian); // dead code on VM target - _scratchIn.setInt32(4, -((-value) ~/ 0x100000000 + 1), - _blobEndian); // dead code on VM target + _scratchIn.setInt32(4, -((-value) ~/ 0x100000000 + 1), _blobEndian); // dead code on VM target } } bytes.add(_scratchOut); @@ -622,8 +604,7 @@ class _BlobEncoder { bytes.addByte(_msString); _writeString(value); } else { - throw StateError( - 'Unexpected type ${value.runtimeType} while encoding blob.'); + throw StateError('Unexpected type ${value.runtimeType} while encoding blob.'); } } @@ -632,8 +613,7 @@ class _BlobEncoder { bytes.addByte(_msFalse); } else if (value == true) { bytes.addByte(_msTrue); - } else if (value is double && value is! int) { - // When compiled to JS, a Number can be both. + } else if (value is double && value is! int) { // When compiled to JS, a Number can be both. bytes.addByte(_msBinary64); _scratchIn.setFloat64(0, value, _blobEndian); bytes.add(_scratchOut); From 42d8eb4801509a54021c70f96bac0e96e61bb937 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Thu, 31 Oct 2024 22:41:08 +0000 Subject: [PATCH 14/16] More unformatting. --- packages/rfw/lib/src/dart/binary.dart | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/rfw/lib/src/dart/binary.dart b/packages/rfw/lib/src/dart/binary.dart index 7187488fb83..181760b2e6f 100644 --- a/packages/rfw/lib/src/dart/binary.dart +++ b/packages/rfw/lib/src/dart/binary.dart @@ -438,8 +438,7 @@ class _BlobDecoder { return DynamicList.generate(_readInt64(), (int index) => readNode()); case _msMap: return _readMap(readNode)!; - default: - throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); + default: throw FormatException('Unrecognized data type 0x${type.toRadixString(16).toUpperCase().padLeft(2, "0")} while decoding blob.'); } } From 76321e0693e4dceb915e9c866ff61bc81a220bb1 Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Mon, 4 Nov 2024 20:05:32 +0000 Subject: [PATCH 15/16] Add code block language for svg.dart. --- third_party/packages/flutter_svg/CHANGELOG.md | 4 ++++ third_party/packages/flutter_svg/lib/svg.dart | 2 +- third_party/packages/flutter_svg/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/third_party/packages/flutter_svg/CHANGELOG.md b/third_party/packages/flutter_svg/CHANGELOG.md index 1f64d4639a5..9375426fcbb 100644 --- a/third_party/packages/flutter_svg/CHANGELOG.md +++ b/third_party/packages/flutter_svg/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.0.11+1 + +* Adds `missing_code_block_language_in_doc_comment` lint. + ## 2.0.11 * Transfers the package source from https://github.com/dnfield/flutter_svg diff --git a/third_party/packages/flutter_svg/lib/svg.dart b/third_party/packages/flutter_svg/lib/svg.dart index 964852a5787..0efcbdaa1ee 100644 --- a/third_party/packages/flutter_svg/lib/svg.dart +++ b/third_party/packages/flutter_svg/lib/svg.dart @@ -146,7 +146,7 @@ class SvgPicture extends StatelessWidget { /// bundled, the app has to specify which ones to include. For instance a /// package named `fancy_backgrounds` could have: /// - /// ``` + /// ```none /// lib/backgrounds/background1.svg /// lib/backgrounds/background2.svg /// lib/backgrounds/background3.svg diff --git a/third_party/packages/flutter_svg/pubspec.yaml b/third_party/packages/flutter_svg/pubspec.yaml index 5ac508491f6..5c7e6cb131c 100644 --- a/third_party/packages/flutter_svg/pubspec.yaml +++ b/third_party/packages/flutter_svg/pubspec.yaml @@ -2,7 +2,7 @@ name: flutter_svg description: An SVG rendering and widget library for Flutter, which allows painting and displaying Scalable Vector Graphics 1.1 files. repository: https://github.com/flutter/packages/tree/main/third_party/packages/flutter_svg issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_svg%22 -version: 2.0.11 +version: 2.0.11+1 environment: sdk: ^3.4.0 From 8c94d1c38b779ff62242da4a7f784c97ca9c65cb Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Mon, 4 Nov 2024 21:14:24 +0000 Subject: [PATCH 16/16] Update flutter_svg version. --- third_party/packages/flutter_svg/CHANGELOG.md | 2 +- third_party/packages/flutter_svg/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/third_party/packages/flutter_svg/CHANGELOG.md b/third_party/packages/flutter_svg/CHANGELOG.md index 9375426fcbb..9f135f77191 100644 --- a/third_party/packages/flutter_svg/CHANGELOG.md +++ b/third_party/packages/flutter_svg/CHANGELOG.md @@ -1,4 +1,4 @@ -## 2.0.11+1 +## 2.0.12 * Adds `missing_code_block_language_in_doc_comment` lint. diff --git a/third_party/packages/flutter_svg/pubspec.yaml b/third_party/packages/flutter_svg/pubspec.yaml index 5c7e6cb131c..c0183b44db4 100644 --- a/third_party/packages/flutter_svg/pubspec.yaml +++ b/third_party/packages/flutter_svg/pubspec.yaml @@ -2,7 +2,7 @@ name: flutter_svg description: An SVG rendering and widget library for Flutter, which allows painting and displaying Scalable Vector Graphics 1.1 files. repository: https://github.com/flutter/packages/tree/main/third_party/packages/flutter_svg issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_svg%22 -version: 2.0.11+1 +version: 2.0.12 environment: sdk: ^3.4.0