From 342013ea68d88d19c271fb6d5e1b93bcd6a305b6 Mon Sep 17 00:00:00 2001 From: David Iglesias Date: Wed, 27 Mar 2024 15:46:46 -0700 Subject: [PATCH 1/2] [ci] Temporarily allow-warnings in podspec_check_command.dart Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. To be removed soon! --- script/tool/lib/src/podspec_check_command.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/script/tool/lib/src/podspec_check_command.dart b/script/tool/lib/src/podspec_check_command.dart index b0982b7ee69..d437e2188c1 100644 --- a/script/tool/lib/src/podspec_check_command.dart +++ b/script/tool/lib/src/podspec_check_command.dart @@ -151,6 +151,7 @@ class PodspecCheckCommand extends PackageLoopingCommand { podspecPath, '--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices. '--skip-tests', + '--allow-warnings', '--use-modular-headers', // Flutter sets use_modular_headers! in its templates. if (libraryLint) '--use-libraries' ]; From 512cefce7d00ec8053d98f6fa9a284942b3e6834 Mon Sep 17 00:00:00 2001 From: David Iglesias Date: Wed, 27 Mar 2024 16:01:59 -0700 Subject: [PATCH 2/2] Adjust tests to expect the allow-warnings flag. --- script/tool/test/podspec_check_command_test.dart | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/script/tool/test/podspec_check_command_test.dart b/script/tool/test/podspec_check_command_test.dart index 6745f18b6d4..3bbe60b506c 100644 --- a/script/tool/test/podspec_check_command_test.dart +++ b/script/tool/test/podspec_check_command_test.dart @@ -156,6 +156,7 @@ void main() { .path, '--configuration=Debug', '--skip-tests', + '--allow-warnings', '--use-modular-headers', '--use-libraries' ], @@ -171,6 +172,7 @@ void main() { .path, '--configuration=Debug', '--skip-tests', + '--allow-warnings', '--use-modular-headers', ], packagesDir.path), @@ -212,6 +214,7 @@ void main() { .path, '--configuration=Debug', '--skip-tests', + '--allow-warnings', '--use-modular-headers', '--use-libraries' ], @@ -227,6 +230,7 @@ void main() { .path, '--configuration=Debug', '--skip-tests', + '--allow-warnings', '--use-modular-headers', ], packagesDir.path),