[in_app_purchase_storekit] Fix type of error code returned from native code in SKReceiptManager.retrieveReceiptData
#6265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e code in `SKReceiptManager.retrieveReceiptData`
Contributor
|
Ah, thanks a lot for the quick fix!! LGTM |
LouiseHsu
approved these changes
Mar 5, 2024
Contributor
Author
|
@LouiseHsu Thanks for the review! Is there anything else left for me to do before this can be merged? |
Contributor
|
Nope, go ahead and merge it :) |
Contributor
Author
|
Great! Could you do that for me? 😊 I don't have the necessary permissions. |
Contributor
|
oops, didnt realize! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2024
…om native code in `SKReceiptManager.retrieveReceiptData` (flutter/packages#6265)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2024
flutter/packages@0625827...2aa6e3f 2024-03-05 [email protected] [in_app_purchase_storekit] Fix type of error code returned from native code in `SKReceiptManager.retrieveReceiptData` (flutter/packages#6265) 2024-03-05 [email protected] [video_player] Fix typo in readme (flutter/packages#6264) 2024-03-05 [email protected] [pigeon] Separates message call code generation into separate methods in the SwiftGenerator (flutter/packages#5959) 2024-03-05 [email protected] [flutter_markdown] Fix WidgetSpan Support in MarkdownElementBuilder (flutter/packages#6225) 2024-03-04 [email protected] [webview_flutter] Make WebKitWebViewWidget unit tests stateless (flutter/packages#6228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native code did not convert the integer
codereturned fromFIAObjectTranslator getMapFromNSErrorto a string before passing it toFlutterError errorWithCode. This allowed anintto flow into a position where the corresponding Dart code expects aString.Fixes flutter/flutter#144595
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.