From fe9d02ae4d578c1be0816ffa964bcb330175ffe1 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 00:42:14 +0100 Subject: [PATCH 01/10] fix #141323 width and height unset --- .../pointer_interceptor_web/lib/pointer_interceptor_web.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart b/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart index 2ae4bf5f505..761df52a0b8 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart +++ b/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart @@ -18,6 +18,8 @@ class PointerInterceptorWeb extends PointerInterceptorPlatform { // Slightly modify the created `element` (for `debug` mode). void _onElementCreated(Object element) { + (element as web.HTMLElement).style.width = '100%'; + (element as web.HTMLElement).style.height = '100%'; (element as web.HTMLElement).style.backgroundColor = 'rgba(255, 0, 0, .5)'; } From 6ab3e6ec6f95bfe363636b294eec5501422b6626 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 00:46:01 +0100 Subject: [PATCH 02/10] change version --- .../pointer_interceptor_web/pubspec.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml index 69777108d45..c9999fb1ebf 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml @@ -2,11 +2,11 @@ name: pointer_interceptor_web description: Web implementation of the pointer_interceptor plugin. repository: https://github.com/flutter/packages/tree/main/packages/pointer_interceptor/pointer_interceptor_web issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3Apointer_interceptor -version: 0.10.1+1 +version: 0.10.2 environment: sdk: ^3.2.0 - flutter: '>=3.16.0' + flutter: ">=3.16.0" flutter: plugin: @@ -23,7 +23,7 @@ dependencies: sdk: flutter plugin_platform_interface: ^2.1.7 pointer_interceptor_platform_interface: ^0.10.0 - web: '>=0.3.0 <0.5.0' + web: ">=0.3.0 <0.5.0" dev_dependencies: flutter_test: @@ -31,4 +31,4 @@ dev_dependencies: topics: - pointer-interceptor - - web \ No newline at end of file + - web From d62990b3ba89502bdd858a06e5ac4f121b91e22a Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 00:47:25 +0100 Subject: [PATCH 03/10] add changelog entry for 10.0.2 --- .../pointer_interceptor/pointer_interceptor_web/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md b/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md index 6ab858277ad..00a36a1c417 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md +++ b/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.10.2 + +* Remove warning related to width and height on web. + ## 0.10.1+1 * Updates minimum required plugin_platform_interface version to 2.1.7. From 39c3881a3e56dcda9aa4739a802e6b33194ee890 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 00:56:15 +0100 Subject: [PATCH 04/10] Update pubspec.yaml remove some auto formatting --- .../pointer_interceptor/pointer_interceptor_web/pubspec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml index c9999fb1ebf..f704b6b0c94 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml @@ -6,7 +6,7 @@ version: 0.10.2 environment: sdk: ^3.2.0 - flutter: ">=3.16.0" + flutter: '>=3.16.0' flutter: plugin: @@ -23,7 +23,7 @@ dependencies: sdk: flutter plugin_platform_interface: ^2.1.7 pointer_interceptor_platform_interface: ^0.10.0 - web: ">=0.3.0 <0.5.0" + web: '>=0.3.0 <0.5.0' dev_dependencies: flutter_test: From 75d2147544af2792dba3ade284103326722e94e4 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 00:57:49 +0100 Subject: [PATCH 05/10] Update pubspec.yaml fix auto formatting From c83a978fb573d706711ab3b4e4b27beb0980b9f2 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 00:58:43 +0100 Subject: [PATCH 06/10] Update pubspec.yaml fix auto formatting --- .../pointer_interceptor/pointer_interceptor_web/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml index f704b6b0c94..68780d990a2 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml @@ -31,4 +31,4 @@ dev_dependencies: topics: - pointer-interceptor - - web + - web From 697dd1d4e62162dbd769805b44ea4b63e323bf29 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 00:59:11 +0100 Subject: [PATCH 07/10] Update pubspec.yaml fix auto formatting --- .../pointer_interceptor/pointer_interceptor_web/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml index 68780d990a2..f704b6b0c94 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml @@ -31,4 +31,4 @@ dev_dependencies: topics: - pointer-interceptor - - web + - web From bf225abb4f7fce7614d92a075f2dd5db10067bcb Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 01:00:05 +0100 Subject: [PATCH 08/10] Update pubspec.yaml fix auto formatting From 7c75573a8ccf7747203e08282e8fa32b3a713312 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Thu, 11 Jan 2024 20:56:28 +0100 Subject: [PATCH 09/10] fix comment --- .../lib/pointer_interceptor_web.dart | 7 ++++--- .../pointer_interceptor_web/pubspec.yaml | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart b/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart index 761df52a0b8..97e1fbe61c8 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart +++ b/packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart @@ -18,9 +18,10 @@ class PointerInterceptorWeb extends PointerInterceptorPlatform { // Slightly modify the created `element` (for `debug` mode). void _onElementCreated(Object element) { - (element as web.HTMLElement).style.width = '100%'; - (element as web.HTMLElement).style.height = '100%'; - (element as web.HTMLElement).style.backgroundColor = 'rgba(255, 0, 0, .5)'; + (element as web.HTMLElement) + ..style.width = '100%' + ..style.height = '100%' + ..style.backgroundColor = 'rgba(255, 0, 0, .5)'; } @override diff --git a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml index c9999fb1ebf..0ace4339e1d 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml @@ -6,7 +6,7 @@ version: 0.10.2 environment: sdk: ^3.2.0 - flutter: ">=3.16.0" + flutter: '>=3.16.0' flutter: plugin: @@ -23,7 +23,7 @@ dependencies: sdk: flutter plugin_platform_interface: ^2.1.7 pointer_interceptor_platform_interface: ^0.10.0 - web: ">=0.3.0 <0.5.0" + web: '>=0.3.0 <0.5.0' dev_dependencies: flutter_test: @@ -31,4 +31,4 @@ dev_dependencies: topics: - pointer-interceptor - - web + - web \ No newline at end of file From 58a68b62e4769cc6c5b722d4fa498768648d62fd Mon Sep 17 00:00:00 2001 From: David Iglesias Date: Thu, 18 Jan 2024 11:48:01 -0800 Subject: [PATCH 10/10] Tweaks to metadata. --- .../pointer_interceptor/pointer_interceptor_web/CHANGELOG.md | 4 ++-- .../pointer_interceptor/pointer_interceptor_web/pubspec.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md b/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md index 00a36a1c417..28955127a78 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md +++ b/packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md @@ -1,6 +1,6 @@ -## 0.10.2 +## 0.10.1+2 -* Remove warning related to width and height on web. +* Fixes "width and height missing" warning on web. ## 0.10.1+1 diff --git a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml index 0ace4339e1d..ff1f0747d9d 100644 --- a/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml @@ -2,7 +2,7 @@ name: pointer_interceptor_web description: Web implementation of the pointer_interceptor plugin. repository: https://github.com/flutter/packages/tree/main/packages/pointer_interceptor/pointer_interceptor_web issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3Apointer_interceptor -version: 0.10.2 +version: 0.10.1+2 environment: sdk: ^3.2.0