From abe9eb54ae3b8a7957abdecf8e0e1d3e3c3ac9a2 Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Fri, 3 Dec 2021 16:07:18 -0800 Subject: [PATCH 1/2] [pointer_interceptor] Mark `PointerInterceptor` as invisible --- packages/pointer_interceptor/CHANGELOG.md | 3 ++- packages/pointer_interceptor/lib/src/web.dart | 2 +- packages/pointer_interceptor/pubspec.yaml | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/pointer_interceptor/CHANGELOG.md b/packages/pointer_interceptor/CHANGELOG.md index da40c2084ea..d42932d8d4b 100644 --- a/packages/pointer_interceptor/CHANGELOG.md +++ b/packages/pointer_interceptor/CHANGELOG.md @@ -1,7 +1,8 @@ -## NEXT +## 0.9.1 * Removed `android` and `ios` directories from `example`, as the example doesn't build for those platforms. +* Marked `PointerInterceptor` as invisible, so it can be optimized by the engine. ## 0.9.0+1 diff --git a/packages/pointer_interceptor/lib/src/web.dart b/packages/pointer_interceptor/lib/src/web.dart index ad38e9fcc88..8c1d2818f26 100644 --- a/packages/pointer_interceptor/lib/src/web.dart +++ b/packages/pointer_interceptor/lib/src/web.dart @@ -28,7 +28,7 @@ void _registerFactory({bool debug = false}) { htmlElement.style.backgroundColor = 'rgba(255, 0, 0, .5)'; } return htmlElement; - }); + }, isVisible: false); } /// The web implementation of the `PointerInterceptor` widget. diff --git a/packages/pointer_interceptor/pubspec.yaml b/packages/pointer_interceptor/pubspec.yaml index 8b1832e0fae..4cfdd0bb51a 100644 --- a/packages/pointer_interceptor/pubspec.yaml +++ b/packages/pointer_interceptor/pubspec.yaml @@ -2,7 +2,7 @@ name: pointer_interceptor description: A widget to prevent clicks from being swallowed by underlying HtmlElementViews on the web. repository: https://github.com/flutter/packages/tree/master/packages/pointer_interceptor issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pointer_interceptor%22 -version: 0.9.0+1 +version: 0.9.1 environment: sdk: ">=2.12.0 <3.0.0" From 96f523300212c7519e24fd1812e82e9d6ba198ea Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Fri, 3 Dec 2021 16:19:01 -0800 Subject: [PATCH 2/2] dartfmt --- packages/pointer_interceptor/lib/src/shim/dart_ui_fake.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/pointer_interceptor/lib/src/shim/dart_ui_fake.dart b/packages/pointer_interceptor/lib/src/shim/dart_ui_fake.dart index 65cd719c8d0..f310a46a441 100644 --- a/packages/pointer_interceptor/lib/src/shim/dart_ui_fake.dart +++ b/packages/pointer_interceptor/lib/src/shim/dart_ui_fake.dart @@ -13,7 +13,8 @@ class platformViewRegistry { /// Shim for registerViewFactory /// https://github.com/flutter/engine/blob/master/lib/web_ui/lib/ui.dart#L72 static void registerViewFactory( - String viewTypeId, dynamic Function(int viewId) viewFactory) {} + String viewTypeId, dynamic Function(int viewId) viewFactory, + {bool isVisible = true}) {} } // ignore: avoid_classes_with_only_static_members