[camera_avfoundation] Set highest available resolution for ResolutionPreset.Max #5245

sergeidesenko · 2023-10-27T15:02:19Z

The current implementation of the camera plugin for iOS iterates though all other resolution presets when set to FLTResolutionPresetMax. This results in a resolution of 3840x2160 at most, while native camera is able to produce 4032x3024

This change should partially address these issues at least.

[camera] Unable To Get High Quality/Full Frame Image & Camera Stretching Issue flutter#58163
[camera] Low Resolution in Camera Image Stream, ResolutionPreset Constructor Parameter is ignored flutter#78247
[Camera] ResolutionPreset.max is producing 4k but not camera max images flutter#45906

P.S. I'm not really sure about tests - it seems that resolution presets are not covered by any. Any feedback is appreciated!

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…-max-resolution

google-cla · 2023-10-27T15:02:23Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

flutter-dashboard · 2023-10-27T15:02:23Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

hellohuanlin

Can you add some unit test?

hellohuanlin · 2023-10-27T18:09:19Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+              if ( [_captureDevice lockForConfiguration:NULL] == YES ) {
+
+                  // set best device format and finish device configuration
+                  _captureDevice.activeFormat = bestFormat;


is this only required in best format but not other resolutions?

In all other cases device is configured with sessionPreset through capture session, like this:
_videoCaptureSession.sessionPreset = AVCaptureSessionPreset3840x2160;

The max resolution case is different because there is no predetermined option

hellohuanlin · 2023-10-27T18:10:36Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+          bestFormat = format;
+        }
+    }
+    return bestFormat;


what if [_captureDevice formats] is empty? do we want to handle nil case?

We do handle it actually, this method returns nil if there is no bestFormat and switch case from setCaptureSessionPreset doesn't break and falls through to other cases

sergeidesenko · 2023-10-28T07:04:44Z

Can you add some unit test?

@hellohuanlin
As I said in original pr message, I'm not really sure about tests - it seems that resolution presets are not covered by any. Could you tell me a little bit more about what you are expecting? Happy to add some tests, just feel a little bit lost

hellohuanlin · 2023-11-01T18:00:09Z

it seems that resolution presets are not covered by any.

Are you saying we didn't have tests this function? Now it's a good time to add those tests

hellohuanlin · 2023-11-14T19:32:18Z

@sergeidesenko For testing, at a high level, we will want verify if each of different configs correctly updates the capture session. If you take a look at the FLTCam constructor, it takes both audio and video sessions, so we can inject them in the test. Let me know if it makes sense.

stuartmorgan-g · 2024-01-09T20:52:50Z

@sergeidesenko Are you planning on updating this PR with tests as discussed above?

sergeidesenko · 2024-01-10T05:07:36Z

@stuartmorgan Hi! Didn't have enough bandwidth at the end of the year to look into this. Yes, I will add tests before the end of January, does this work?

hellohuanlin · 2024-01-16T19:32:43Z

I'm converting this to draft state. Feel free to add tests and re-request for review.

sergeidesenko · 2024-01-22T06:59:54Z

@hellohuanlin Hi! Added tests that check whether setting the resolutionPreset actually updates the captureSession. Would be happy to hear what you think!

jmagman · 2024-01-24T21:49:36Z

@hellohuanlin can you take another look?

hellohuanlin · 2024-01-30T20:07:21Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

 }

+/// Finds the highest available resolution in terms of pixel count for the given device
+- (AVCaptureDeviceFormat *)getHighestResolutionFormatFor:(AVCaptureDevice *)captureDevice {


nit: getHighestResolutionFormatForCaptureDevice

hellohuanlin · 2024-01-30T20:08:04Z

packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSessionPresetsTest.m

+}
+
+- (void)
+    testResolutionPresetWithCanSetSessionPresetUltraHigh_mustUpdateCaptureSessionPreset {  // TODO


is this still TODO?

hellohuanlin · 2024-01-30T20:09:25Z

packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSessionPresetsTest.m

+  OCMExpect([videoSessionMock setSessionPreset:[OCMArg checkWithBlock:^BOOL(id value) {
+                                // Return YES if the value is one of the expected presets
+                                return [value isEqualToString:expectedUltraHighPreset] ||
+                                       [value isEqualToString:expectedMaxPreset];


can you explicitly mock the values and verify each of them?

Thanks for the review!
I'm not sure I understood your message here. If you are suggesting two different tests (one for expectedUltraHighPreset and one for expectedMaxPreset), then that's not really the expected behaviour.
The test is for the case where camera receives FLTResolutionPresetMax, and in that case sessionPreset can be one of these two values and both are acceptable.
If I missed your point - could you please clarify what you meant?

in that case sessionPreset can be one of these two values and both are acceptable.

Can you explain when will it be one value and when the other value? It's unclear which one will be true when running the test.

If you take a look in the file FLTCam.m at line 372, there are two options on how to handle FLTResolutionPresetMax. Either we can find bestFormat, in which case sessionPreset is set to AVCaptureSessionPresetInputPriority, or the bestFormat is nil, in which case we try to set sessionPreset to AVCaptureSessionPreset3840x2160.

Since method canSetSessionPreset of our mock object always returns true, we can expect that if we try to set AVCaptureSessionPreset3840x2160, we will always succeed. That's how we get only to possible outcomes.

It's unclear which one will be true when running the test.

About that - we could mock further and provide our videoSessionMock with availableFormats, split the test in two different tests - one that covers case with the best format and one that covers case with no formats and AVCaptureSessionPreset3840x2160. But since both of those cases are an acceptable response to setting FLTResolutionPresetMax (as I explained above), I didn't see the need to go this far

Since method canSetSessionPreset of our mock object always returns true, we can expect that if we try to set AVCaptureSessionPreset3840x2160, we will always succeed. That's how we get only to possible outcomes.

If we have two codepaths, we should be testing both of them.

But since both of those cases are an acceptable response to setting FLTResolutionPresetMax (as I explained above), I didn't see the need to go this far

Why would we want no test coverage that one of the possible outcomes actually works?

If we have two codepaths, we should be testing both of them.

Thank you! I'll add another test

Why would we want no test coverage that one of the possible outcomes actually works?

I'm not sure, since this whole behavior of resolution presets wasn't covered by any test at all :)

https://github.com/flutter/flutter/wiki/Plugin-Tests#faq-do-i-need-to-add-tests-even-if-the-part-of-the-code-im-changing-isnt-already-tested

hellohuanlin · 2024-01-30T20:09:41Z

packages/camera/camera/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.10.5+6
+
+* Fixes bug where max resolution preset does not produce highest available resolution on iOS.


this doesn't need a bump

sergeidesenko · 2024-02-13T10:06:07Z

@stuartmorgan Ready for re-review

stuartmorgan-g · 2024-02-21T15:48:02Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

 /// Videos are written to disk by `videoAdaptor` on an internal queue managed by AVFoundation.
 @property(strong, nonatomic) dispatch_queue_t photoIOQueue;
 @property(assign, nonatomic) UIDeviceOrientation deviceOrientation;
+/// A block property to dynamically determine video dimensions based on a given


Nit: comments should not explain things that are inherently obvious to anyone who can read the language, so a property comment should not say that it's a property (same with class, method, etc.), and it should not say what the types of the block params/returns are.

In the context of an implementation file, the interesting thing is to explain what this is and why it exists:

/// A wrapper for CMVideoFormatDescriptionGetDimensions to allow for alternate implementations in tests.

stuartmorgan-g · 2024-02-21T15:55:02Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+@property(nonatomic, copy) VideoDimensionsForFormatBlock videoDimensionsForFormatBlock;
+/// A block property to retrieve an AVCaptureDevice instance without input parameters.
+/// Designed to return a predefined or default capture device, facilitating simple access within the
+/// application.


Same comments here. Also, this doesn't exist to facilitate access, it exists for dependency injection.

/// A wrapper for AVCaptureDevice creation to allow for dependency injection in tests.

stuartmorgan-g · 2024-02-21T15:55:31Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

-  return [self initWithCameraName:cameraName
-                 resolutionPreset:resolutionPreset
+  return [self initWithCameraName:(NSString *)cameraName
+                 resolutionPreset:(NSString *)resolutionPreset


Why are you adding explicit casts to the types they already have?

stuartmorgan-g · 2024-02-21T15:56:12Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+/// A block property to retrieve an AVCaptureDevice instance without input parameters.
+/// Designed to return a predefined or default capture device, facilitating simple access within the
+/// application.
+@property(nonatomic, copy) CaptureDeviceBlock captureDeviceBlock;


captureDeviceFactory

stuartmorgan-g · 2024-02-21T15:57:54Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+/// A block property to dynamically determine video dimensions based on a given
+/// AVCaptureDeviceFormat. It accepts an AVCaptureDeviceFormat object and returns a
+/// CMVideoDimensions struct, indicating the video's width and height.
+@property(nonatomic, copy) VideoDimensionsForFormatBlock videoDimensionsForFormatBlock;


videoDimensionsForFormat

stuartmorgan-g · 2024-02-21T16:03:35Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam_Test.h

+
+ This block is intended to be used for determining the video dimensions (width and height) for a
+ given capture device format. It accepts an AVCaptureDeviceFormat object as its input and returns a
+ CMVideoDimensions struct representing the video dimensions associated with that format.


See previous comments. The goal is to explain to someone who knows Obj-C but not this specific code what this is, not to explain to someone who doesn't know anything about the language what this is.

stuartmorgan-g · 2024-02-21T16:04:23Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam_Test.h

+
+ Returns:
+ A CMVideoDimensions struct containing the width and height (in pixels) of the video associated with
+ the provided format.


If you are going to do formal parameter and return documentation (which is optional), it needs to use Doxygen format for consistency.

stuartmorgan-g · 2024-02-21T16:04:40Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam_Test.h

+ An AVCaptureDevice instance. The specific instance returned by the block can be predefined within
+ the block's implementation, allowing for consistent access to a particular device, such as the
+ default camera or microphone, without the need for specifying its unique ID each time.
+ */


All the same comments apply here.

stuartmorgan-g · 2024-02-21T16:05:33Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam_Test.h

+/**
+ A block type definition named VideoDimensionsForFormatBlock.
+
+ This block is intended to be used for determining the video dimensions (width and height) for a


"This block is intended to be used for" adds a lot of unnecessary verbosity; people understand that the purpose of a declaration comment is to explain what something is used for.

stuartmorgan-g · 2024-02-21T16:06:21Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam_Test.h

+
+ This initializer allows the explicit configuration of media capture settings and direct
+ manipulation of internal components like capture sessions and device selection blocks, facilitating
+ thorough testing scenarios.


Readers can be expected to understand the purpose of declarations that are in a _Test.h file; you don't have to explain that part.

sergeidesenko · 2024-02-21T16:59:01Z

@stuartmorgan
updated comments. Just one thing - could you take a look at my question about styling? There is a mix of different styles as far as I can see from the existing code

sergeidesenko · 2024-02-21T17:37:44Z

@hellohuanlin
I believe that all changes you've requested are now in this pr. Could you confirm?

hellohuanlin · 2024-02-22T01:27:02Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+/// Allows for alternate implementations in tests.
+@property(nonatomic, copy) VideoDimensionsForFormatBlock videoDimensionsForFormat;
+/// A wrapper for AVCaptureDevice creation to allow for dependency injection in tests.
+@property(nonatomic, copy) CaptureDeviceBlock captureDeviceFactory;


can we call this type CaptureDeviceFactory?

hellohuanlin · 2024-02-22T01:34:15Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

 @property(assign, nonatomic) UIDeviceOrientation deviceOrientation;
+/// A wrapper for CMVideoFormatDescriptionGetDimensions.
+/// Allows for alternate implementations in tests.
+@property(nonatomic, copy) VideoDimensionsForFormatBlock videoDimensionsForFormat;


Nit: can we make the type name and variable name consistent?

sergeidesenko · 2024-02-28T09:30:39Z

@stuartmorgan Same question - is there anything else you would like to see changed?

stuartmorgan-g

A few more nits for things I didn't catch before, but otherwise LGTM. Thanks!

stuartmorgan-g · 2024-02-29T18:13:08Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+          break;
+        }
+      }
+    }


Nit: This should be after the code below, enclosing the entire case implementation, otherwise the indentation is very confusing.

fixed everything
In this case I decided to just remove everything related to AVCaptureSessionPreset3840x2160, since it was just a repetition of the next case (FLTResolutionPresetUltraHigh). Now it's more in line with other cases

Out of curiosity - what's your definition of nit in this context? I thought these are not compulsory

I generally use it to indicate that something is a very small change. I wasn't aware there was a doc that equated it with being optional; I'll stop using it given that.

stuartmorgan-g · 2024-02-29T18:14:25Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+          [self highestResolutionFormatForCaptureDevice:_captureDevice];
+      if (bestFormat) {
+        _videoCaptureSession.sessionPreset = AVCaptureSessionPresetInputPriority;
+        if ([_captureDevice lockForConfiguration:NULL] == YES) {


Nit: Never compare to YES; see go/objc-style#bool-expressions-and-conversions

stuartmorgan-g · 2024-02-29T18:15:42Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

+    (AVCaptureDevice *)captureDevice {
+  AVCaptureDeviceFormat *bestFormat = nil;
+  NSUInteger maxPixelCount = 0;
+  for (AVCaptureDeviceFormat *format in [_captureDevice formats]) {


Nit: in _captureDevice.formats

sergeidesenko · 2024-03-01T10:07:16Z

@stuartmorgan @hellohuanlin (sorry, not sure who would be responsible for this)
Is this pr ready for an autosubmit now or are there any additional steps?

stuartmorgan-g

The next step is to fix the issues I raised above. I had set my status bit to approval to make it easier to land once that was done, but it seems like that created confusion, so updating it to clarify.

…solutionPreset.Max (flutter/packages#5245)

flutter/packages@a9c68b8...0625827 2024-03-02 [email protected] Roll Flutter from ba719bc to 65cd84b (5 revisions) (flutter/packages#6239) 2024-03-01 [email protected] Roll Flutter from e92bca3 to ba719bc (37 revisions) (flutter/packages#6235) 2024-03-01 [email protected] [camera_avfoundation] Set highest available resolution for ResolutionPreset.Max (flutter/packages#5245) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…Preset.Max (flutter#5245) The current implementation of the camera plugin for iOS iterates though all other resolution presets when set to FLTResolutionPresetMax. This results in a resolution of 3840x2160 at most, while native camera is able to produce 4032x3024 This change should partially address these issues at least. - flutter/flutter#58163 - flutter/flutter#78247 - flutter/flutter#45906 P.S. I'm not really sure about tests - it seems that resolution presets are not covered by any. Any feedback is appreciated!

hellohuanlin · 2025-03-18T19:18:53Z

@sergeidesenko FYI This may have caused a regression based on discussion here: flutter/flutter#162376 (comment)

(Sorry for pinging in the PR since I wasn't able to tag you in the issue)

sergeidesenko · 2025-03-18T19:48:41Z

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m


-  _captureDevice = [AVCaptureDevice deviceWithUniqueID:cameraName];
+  _captureDevice = self.captureDeviceFactory();



@hellohuanlin you are probably right, this line is causing camera not updating.
Reverting this one line would fix it, I think, and wouldn't break the tests that depend on captureDeviceFactory to work. Unfortunately, I don't think I have enough bandwidth right now to go through with a new pr, which again will require writing new tests and going through a code review.

Would you consider just reverting this pr altogether?

It shouldn't be reverted, the cameraName should just be a parameter to the factory method. I missed in review that it was no longer using the local name.

sergeidesenko added 5 commits July 30, 2023 16:22

Set higher resolution when using max preset

01ad812

Merge remote-tracking branch 'upstream/main' into camera_avfoundation…

5f5cabc

…-max-resolution

chore: update changelog

f9f302f

chore: update changelog and pubspec

e5a33f6

refactor: add comments

d3ce411

sergeidesenko requested review from bparrishMines and hellohuanlin as code owners October 27, 2023 15:02

github-actions bot added p: camera platform-ios labels Oct 27, 2023

chore: update pubspec

5813f25

hellohuanlin requested changes Oct 27, 2023

View reviewed changes

sergeidesenko requested a review from hellohuanlin November 1, 2023 10:11

hellohuanlin marked this pull request as draft January 16, 2024 19:31

sergeidesenko added 2 commits January 22, 2024 09:54

feat(tests): add convenience method for camera init

60e043a

feat(tests): add tests for setting resolutionPresets

9830404

github-actions bot added the platform-macos label Jan 22, 2024

sergeidesenko marked this pull request as ready for review January 22, 2024 07:00

sergeidesenko added 2 commits January 22, 2024 10:11

chore(tests): add tests file to .pbxproj

87b0c59

chore: fix formatting for updated files

0c29019

hellohuanlin reviewed Jan 30, 2024

View reviewed changes

sergeidesenko requested a review from stuartmorgan-g February 14, 2024 11:21

stuartmorgan-g requested changes Feb 21, 2024

View reviewed changes

refactor: update comments

ddfe778

refactor: update comment to match arguments

5c01c8c

sergeidesenko requested a review from stuartmorgan-g February 21, 2024 17:35

hellohuanlin approved these changes Feb 22, 2024

View reviewed changes

refactor: rename types

0c40901

stuartmorgan-g approved these changes Feb 29, 2024

View reviewed changes

Merge branch 'main' into camera_avfoundation-max-resolution

42e9cfa

stuartmorgan-g requested changes Mar 1, 2024

View reviewed changes

refactor: address code review

8e019b3

sergeidesenko requested a review from stuartmorgan-g March 1, 2024 13:28

stuartmorgan-g approved these changes Mar 1, 2024

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2024

auto-submit bot merged commit 06c1fa4 into flutter:main Mar 1, 2024

engine-flutter-autoroll mentioned this pull request Mar 4, 2024

Roll Packages from a9c68b83356b to 06258277070f (3 revisions) flutter/flutter#144543

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2024

06c1fa4 [camera_avfoundation] Set highest available resolution for Re…

4f5ee5d

…solutionPreset.Max (flutter/packages#5245)

engine-flutter-autoroll mentioned this pull request Mar 4, 2024

Roll Packages from a9c68b83356b to 06258277070f (3 revisions) flutter/flutter#144556

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2024

06c1fa4 [camera_avfoundation] Set highest available resolution for Re…

4b39843

…solutionPreset.Max (flutter/packages#5245)

reidbaker mentioned this pull request Apr 1, 2024

[camera_android_camerax] Move integration_test dependency to tests reidbaker/packages#4

Closed

11 tasks

sergeidesenko commented Mar 18, 2025

View reviewed changes

		@@ -1,3 +1,7 @@
		## 0.10.5+6

		* Fixes bug where max resolution preset does not produce highest available resolution on iOS.


		_captureDevice = [AVCaptureDevice deviceWithUniqueID:cameraName];
		_captureDevice = self.captureDeviceFactory();

[camera_avfoundation] Set highest available resolution for ResolutionPreset.Max #5245

[camera_avfoundation] Set highest available resolution for ResolutionPreset.Max #5245

Uh oh!

Conversation

sergeidesenko commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented Oct 27, 2023

Uh oh!

flutter-dashboard bot commented Oct 27, 2023

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergeidesenko commented Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hellohuanlin commented Nov 1, 2023

Uh oh!

hellohuanlin commented Nov 14, 2023

Uh oh!

stuartmorgan-g commented Jan 9, 2024

Uh oh!

sergeidesenko commented Jan 10, 2024

Uh oh!

hellohuanlin commented Jan 16, 2024

Uh oh!

sergeidesenko commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Jan 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergeidesenko Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergeidesenko Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergeidesenko commented Feb 13, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

sergeidesenko commented Oct 27, 2023 •

edited

Loading

sergeidesenko commented Oct 28, 2023 •

edited

Loading

sergeidesenko commented Jan 22, 2024 •

edited

Loading

sergeidesenko Jan 31, 2024 •

edited

Loading

sergeidesenko Feb 2, 2024 •

edited

Loading

sergeidesenko Mar 1, 2024 •

edited

Loading