Skip to content

Conversation

@asaarnak
Copy link
Contributor

@asaarnak asaarnak commented Mar 4, 2023

Update roboelectric version to 4.4.1 to remove usages of 'android.support' and support androidX without jetifier. robolectric/robolectric#5523

flutter/flutter#117107

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard

This comment was marked as resolved.

@camsim99
Copy link
Contributor

camsim99 commented Mar 9, 2023

Thank you for your contribution. It looks like the tests are failing. Before we review the PR, please see what you can do to resolve the test failures. If you are unsure how to proceed, please reach out for help on the #hackers-new channel.

# Conflicts:
#	packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md
#	packages/google_maps_flutter/google_maps_flutter_android/example/android/gradle.properties
#	packages/url_launcher/url_launcher_android/CHANGELOG.md
#	packages/url_launcher/url_launcher_android/example/android/gradle.properties
@asaarnak
Copy link
Contributor Author

asaarnak commented Mar 9, 2023

Thanks!
I forgot to run native_tests locally.
@camsim99
Found that the tests failed because of RoboElectric 4.4 moved to newer LooperMode.Mode.PAUSED.
With @LooperMode(LooperMode.Mode.LEGACY) the tests succeeded.
I added fix suggested here: robolectric/robolectric#5356 (comment)
Should this be investigated why test succeed with LEGACY mode and fail with PAUSED mode?

@asaarnak
Copy link
Contributor Author

@camsim99 Just notifying. PR needs one more review.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 8ca6bc1 into flutter:main Mar 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
… version (flutter#3372)

[google_maps_flutter_android, url_launcher_android] bump roboelectric version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter p: url_launcher platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants