-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[camera_android] Fix camera android deprecation warning for CamcorderProfile.get() #3273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera_android] Fix camera android deprecation warning for CamcorderProfile.get() #3273
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cc7ba0c to
1f253a7
Compare
|
@stuartmorgan I'll recap my findings about the use of If I build the example with a release build: Build LogsThe deprecation messages no longer appear (which is the goal of this PR), Those messages are actually dependency problems (as the dependencies and the project itself use different version of the Kotlin Standard Libary, hence the warnings) and shouldn't be fatal? I'm not sure if there is a way to lower the severity of this category of messages (to an info category of sorts), so that we can rely on |
...d/android/src/main/java/io/flutter/plugins/camera/features/resolution/ResolutionFeature.java
Outdated
Show resolved
Hide resolved
|
I'm exploring an alternate solution for making deprecation warnings errors now; if that pans out I'll have a PR soon to enable it with an initial exclusion list, and then this PR will be able to include removing |
camsim99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me!
This is posted as #3293 Once that lands, this can be covered by just enabling this: https://github.com/flutter/packages/pull/3293/files#diff-c40bf8281656da0025c18216f38b473c0f0c018ccce9b04c57cf25f8a391b91fR38-R39 |
|
Removing needs tests as in follow up commits tests were added to verify the change. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…amcorderProfile.get() (flutter/packages#3273)
…amcorderProfile.get() (flutter/packages#3273) (#122104) Roll Packages from 789e3a7 to c40f189 (1 revision)
…rning for CamcorderProfile.get() (flutter/packages#3273) (#122104) Commit: 80be2bfc9f8cc39d197f616b8ce809217908a5f8
…ng for CamcorderProfile.get() (flutter#3273) (flutter/flutter#122104)
…ng for CamcorderProfile.get() (flutter#3273) (flutter/flutter#122104)
…ng for CamcorderProfile.get() (flutter#3273) (flutter/flutter#122104)
|
What release is this fix available in? |
You can look at the pubspec changes in a PR to know what version it is in. |
…ng for CamcorderProfile.get() (flutter#3273) (flutter/flutter#122104)
…ng for CamcorderProfile.get() (flutter#3273) (flutter/flutter#122104)
…Profile.get() (flutter#3273) [camera_android] Fix camera android deprecation warning for CamcorderProfile.get()
This PR was recreated from flutter/plugins#7062 in
flutter/pluginsThis PR adds a
@TargetApi()annotation and moves a@SuppressWarnings("deprecation")annotation to the right place.It also enables
javaclint options for thecamera_androidexample and fixes the warnings related to that.Fixes: flutter/flutter#94999
Part of: flutter/flutter#91868
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
N/A
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.