Commit c9347b8
authored
[go_router] Fix return type of current state getter to be non-nullable (#8173)
The `state` getter returns a `GoRouterState?`, but I don't think it needs to be nullable since `currentConfiguration.last.buildState()` never returns `null`.
I'm not sure if it is nullable on purpose for some changes planned in the Future. If there is a reason, it might be better to add a comment about it. Otherwise, it is just inconvenient that a null check is necessary.1 parent 913c949 commit c9347b8
File tree
5 files changed
+19
-17
lines changed- packages/go_router
- lib/src
- test
5 files changed
+19
-17
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
1 | 5 | | |
2 | 6 | | |
3 | 7 | | |
| |||
11 | 15 | | |
12 | 16 | | |
13 | 17 | | |
14 | | - | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
264 | | - | |
| 264 | + | |
265 | 265 | | |
266 | 266 | | |
267 | 267 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6030 | 6030 | | |
6031 | 6031 | | |
6032 | 6032 | | |
6033 | | - | |
6034 | | - | |
| 6033 | + | |
| 6034 | + | |
6035 | 6035 | | |
6036 | 6036 | | |
6037 | 6037 | | |
6038 | 6038 | | |
6039 | | - | |
6040 | | - | |
| 6039 | + | |
| 6040 | + | |
6041 | 6041 | | |
6042 | 6042 | | |
6043 | 6043 | | |
6044 | 6044 | | |
6045 | | - | |
6046 | | - | |
| 6045 | + | |
| 6046 | + | |
6047 | 6047 | | |
6048 | 6048 | | |
6049 | 6049 | | |
6050 | 6050 | | |
6051 | | - | |
6052 | | - | |
| 6051 | + | |
| 6052 | + | |
6053 | 6053 | | |
6054 | 6054 | | |
6055 | 6055 | | |
6056 | 6056 | | |
6057 | | - | |
6058 | | - | |
| 6057 | + | |
| 6058 | + | |
6059 | 6059 | | |
6060 | 6060 | | |
6061 | 6061 | | |
6062 | 6062 | | |
6063 | 6063 | | |
6064 | | - | |
6065 | | - | |
| 6064 | + | |
| 6065 | + | |
6066 | 6066 | | |
6067 | 6067 | | |
6068 | 6068 | | |
| |||
0 commit comments