[ci] Partially migrate macOS-host Pigeon tests to LUCI (#3046)

* Enable all tests that are in bringup mode

* See if debug affects unit tests

* Disable integration test for testing

* Disable iOS for faster debug cycles

* Disable output stream

* print logging

* More adjusting to experiment

* Re-enable integration

* Re-disable integration, remove some prints

* Remove another print

* Remove remaining print

* Re-add iOS tests

* Run with only the macOS integration tests

* Try the non-legacy iOS tests

* Try adding the other iOS tests

* try running everything, with process_runner

* Revert accidental changes

* Try enabling everything, split between LUCI and Cirrus

* Fix coverage check

* Move dependency

* Add simulator to macOS-host custom tests

* Re-disable Obj-C integration tests, which seem to hang too

* Revert process_runner, which seems to hang Windows CI :(

* Remove Dart code for running legacy unit tests

* Remove legacy iOS test harness

* Missed files

Author: stuartmorgan-g

.ci.yaml

@@ -211,7 +211,6 @@ targets:
       target_file: macos_platform_tests.yaml
 
   - name: Mac_arm64 custom_package_tests master
-    bringup: true # New configuration
     recipe: packages/packages
     timeout: 60
     properties:
@@ -221,7 +220,6 @@ targets:
       channel: master
 
   - name: Mac_arm64 custom_package_tests stable
-    bringup: true # New configuration
     recipe: packages/packages
     timeout: 60
     properties:

.ci/targets/macos_custom_package_tests.yaml

@@ -1,5 +1,7 @@
 tasks:
   - name: prepare tool
     script: .ci/scripts/prepare_tool.sh
+  - name: create simulator
+    script: .ci/scripts/create_simulator.sh
   - name: custom package tests
     script: .ci/scripts/custom_package_tests.sh

packages/pigeon/platform_tests/README.md

@@ -29,10 +29,3 @@ supported plugin languages. It covers:
 Dart unit tests for null-safe mode. This is a legacy structure from before
 NNBD was the only mode Pigeon supported; these should be folded back into
 the main tests.
-
-## ios\_unit\_tests
-
-This is a legacy harness that is only necessary for CI, and will be
-removed in the future. See
-[this PR](https://github.com/flutter/packages/pull/2816) for more
-details.

packages/pigeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/AllDatatypesTest.m

@@ -5,11 +5,7 @@
 @import Flutter;
 @import XCTest;
 
-#ifdef LEGACY_HARNESS
-#import "CoreTests.gen.h"
-#else
 @import alternate_language_test_plugin;
-#endif
 
 #import "EchoMessenger.h"
 

packages/pigeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/AsyncHandlersTest.m

@@ -5,11 +5,7 @@
 @import Flutter;
 @import XCTest;
 
-#ifdef LEGACY_HARNESS
-#import "AsyncHandlers.gen.h"
-#else
 @import alternate_language_test_plugin;
-#endif
 
 #import "MockBinaryMessenger.h"
 

packages/pigeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/EnumTest.m

@@ -5,11 +5,7 @@
 @import Flutter;
 @import XCTest;
 
-#ifdef LEGACY_HARNESS
-#import "Enum.gen.h"
-#else
 @import alternate_language_test_plugin;
-#endif
 
 #import "EchoMessenger.h"
 

packages/pigeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/ListTest.m

@@ -5,11 +5,7 @@
 @import Flutter;
 @import XCTest;
 
-#ifdef LEGACY_HARNESS
-#import "List.gen.h"
-#else
 @import alternate_language_test_plugin;
-#endif
 
 #import "EchoMessenger.h"
 

packages/pigeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/MultipleArityTest.m

@@ -5,11 +5,7 @@
 @import Flutter;
 @import XCTest;
 
-#ifdef LEGACY_HARNESS
-#import "MultipleArity.gen.h"
-#else
 @import alternate_language_test_plugin;
-#endif
 
 #import "HandlerBinaryMessenger.h"
 

packages/pigeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/NonNullFieldsTest.m

@@ -6,11 +6,7 @@
 @import Flutter;
 @import XCTest;
 
-#ifdef LEGACY_HARNESS
-#import "NonNullFields.gen.h"
-#else
 @import alternate_language_test_plugin;
-#endif
 
 #import "EchoMessenger.h"
 

packages/pigeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/NullFieldsTest.m

@@ -5,11 +5,7 @@
 @import Flutter;
 @import XCTest;
 
-#ifdef LEGACY_HARNESS
-#import "NullFields.gen.h"
-#else
 @import alternate_language_test_plugin;
-#endif
 
 #import "EchoMessenger.h"