[go_router] Resolves #5113 (comment)

Author: hrishikesh-kadam

packages/go_router/lib/src/configuration.dart

@@ -315,8 +315,8 @@ class RouteConfiguration {
   List<RouteMatch>? _getLocRouteMatches(
       Uri uri, Map<String, String> pathParameters) {
     final List<RouteMatch>? result = _getLocRouteRecursively(
-      location: uri.path.isEmpty ? '/' : uri.path,
-      remainingLocation: uri.path.isEmpty ? '/' : uri.path,
+      location: uri.path,
+      remainingLocation: uri.path,
       matchedLocation: '',
       matchedPath: '',
       pathParameters: pathParameters,

packages/go_router/lib/src/router.dart

@@ -526,8 +526,10 @@ class GoRouter implements RouterConfig<RouteMatchList> {
       // verified by assert() during the initialization.
       return initialLocation!;
     }
+    final Uri platformDefaultUri =
+        Uri.parse(WidgetsBinding.instance.platformDispatcher.defaultRouteName);
     final String platformDefault =
-        WidgetsBinding.instance.platformDispatcher.defaultRouteName;
+        platformDefaultUri.path.isEmpty ? '/' : platformDefaultUri.path;
     if (initialLocation == null) {
       return platformDefault;
     } else if (platformDefault == '/') {

packages/go_router/test/go_router_test.dart

@@ -2445,8 +2445,8 @@ void main() {
       // https://github.com/flutter/flutter/issues/124045.
       // ignore: deprecated_member_use
       expect(router.routeInformationProvider.value.location, '/dummy');
-      TestWidgetsFlutterBinding
-          .instance.platformDispatcher.defaultRouteNameTestValue = '/';
+      TestWidgetsFlutterBinding.instance.platformDispatcher
+          .clearDefaultRouteNameTestValue();
     });
 
     test('throws assertion if initialExtra is set w/o initialLocation', () {
@@ -2466,6 +2466,45 @@ void main() {
     });
   });
 
+  group('_effectiveInitialLocation()', () {
+    final List<GoRoute> routes = <GoRoute>[
+      GoRoute(
+        path: '/',
+        builder: (BuildContext context, GoRouterState state) =>
+            const HomeScreen(),
+      ),
+    ];
+
+    testWidgets(
+        'When platformDispatcher.defaultRouteName is deep-link Uri with '
+        'scheme, authority, no path', (WidgetTester tester) async {
+      TestWidgetsFlutterBinding.instance.platformDispatcher
+          .defaultRouteNameTestValue = 'https://domain.com';
+      final GoRouter router = await createRouter(
+        routes,
+        tester,
+      );
+      expect(router.routeInformationProvider.value.uri.path, '/');
+      TestWidgetsFlutterBinding.instance.platformDispatcher
+          .clearDefaultRouteNameTestValue();
+    });
+
+    testWidgets(
+        'When platformDispatcher.defaultRouteName is deep-link Uri with '
+        'scheme, authority, no path, but trailing slash',
+        (WidgetTester tester) async {
+      TestWidgetsFlutterBinding.instance.platformDispatcher
+          .defaultRouteNameTestValue = 'https://domain.com/';
+      final GoRouter router = await createRouter(
+        routes,
+        tester,
+      );
+      expect(router.routeInformationProvider.value.uri.path, '/');
+      TestWidgetsFlutterBinding.instance.platformDispatcher
+          .clearDefaultRouteNameTestValue();
+    });
+  });
+
   group('params', () {
     testWidgets('preserve path param case', (WidgetTester tester) async {
       final List<GoRoute> routes = <GoRoute>[

packages/go_router/test/matching_test.dart

@@ -107,28 +107,4 @@ void main() {
     expect(decoded, isNotNull);
     expect(decoded, equals(list1));
   });
-
-  test('RouteMatchList for deep-link Uri with scheme, authority', () {
-    final RouteConfiguration configuration = RouteConfiguration(
-      routes: <GoRoute>[
-        GoRoute(
-          path: '/',
-          builder: (BuildContext context, GoRouterState state) =>
-              const Placeholder(),
-        ),
-      ],
-      redirectLimit: 0,
-      navigatorKey: GlobalKey<NavigatorState>(),
-      topRedirect: (_, __) => null,
-    );
-
-    final RouteMatchList matchList1 = configuration.findMatch('/');
-    expect(matchList1.matches[0].matchedLocation, '/');
-    final RouteMatchList matchList2 =
-        configuration.findMatch('https://domain.com');
-    expect(matchList2.matches[0].matchedLocation, '/');
-    final RouteMatchList matchList3 =
-        configuration.findMatch('https://domain.com/');
-    expect(matchList3.matches[0].matchedLocation, '/');
-  });
 }

packages/go_router/test/path_utils_test.dart

@@ -100,8 +100,6 @@ void main() {
     verify('/a/', '/a');
     verify('/', '/');
     verify('/a/b/', '/a/b');
-    verify('scheme://authority', 'scheme://authority');
-    verify('scheme://authority/', 'scheme://authority');
 
     expect(() => canonicalUri('::::'), throwsA(isA<FormatException>()));
     expect(() => canonicalUri(''), throwsA(anything));