Skip to content

Commit 165e535

Browse files
authored
Remove add-to-app bitcode warning (#148587)
Flutter deprecated bitcode in 2022 flutter/flutter#112828, and introduced a warning in #112900 to let add-to-app devs know. Apps should be migrated by now, remove the outdated warning.
1 parent 5890a2f commit 165e535

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

dev/devicelab/bin/tasks/build_ios_framework_module_test.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
8787
const String outputDirectoryName = 'flutter-frameworks';
8888

8989
await inDirectory(projectDir, () async {
90-
final StringBuffer outputError = StringBuffer();
91-
await evalFlutter(
90+
await flutter(
9291
'build',
9392
options: <String>[
9493
'ios-framework',
@@ -97,11 +96,7 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
9796
'--obfuscate',
9897
'--split-debug-info=symbols',
9998
],
100-
stderr: outputError,
10199
);
102-
if (!outputError.toString().contains('Bitcode support has been deprecated.')) {
103-
throw TaskResult.failure('Missing bitcode deprecation warning');
104-
}
105100
});
106101

107102
final String outputPath = path.join(projectDir.path, outputDirectoryName);

packages/flutter_tools/lib/src/commands/build_ios_framework.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,10 +330,6 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand {
330330
'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.');
331331
}
332332

333-
globals.printWarning(
334-
'Bitcode support has been deprecated. Turn off the "Enable Bitcode" build setting in your Xcode project or you may encounter compilation errors.\n'
335-
'See https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes for details.');
336-
337333
return FlutterCommandResult.success();
338334
}
339335

0 commit comments

Comments
 (0)