Skip to content

Default child lists to empty lists #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2016
Merged

Default child lists to empty lists #6592

merged 1 commit into from
Oct 31, 2016

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Oct 30, 2016

Fixes #6591

@abarth
Copy link
Contributor Author

abarth commented Oct 30, 2016

@Hixie

@abarth abarth mentioned this pull request Oct 30, 2016
Closed
@Hixie
Copy link
Contributor

Hixie commented Oct 30, 2016

Search for _emptyWidgetList in basic.dart. We should presumably replace it with inline const <Widget>[] everywhere it's used too.

LGTM.

Test maybe?

@abarth
Copy link
Contributor Author

abarth commented Oct 31, 2016

We should presumably replace it with inline const [] everywhere it's used too.

Ok. I'll do that in a separate patch.

Test maybe?

I guess I could test it... I'm not sure it would be such a valuable test though.

@abarth abarth force-pushed the default_child_list branch from baa160e to 83a4489 Compare October 31, 2016 02:56
@abarth
Copy link
Contributor Author

abarth commented Oct 31, 2016

We should presumably replace it with inline const [] everywhere it's used too.

Ok. I'll do that in a separate patch.

Turns out I did it in this patch because I'm such a great guy.

Test maybe?

I guess I could test it... I'm not sure it would be such a valuable test though.

Alright, I tested that all these classes can be constructed with only required arguments. Turned up a bug (and a doc opportunity), so I guess it was worthwhile. :)

@abarth abarth force-pushed the default_child_list branch from 83a4489 to faa918f Compare October 31, 2016 02:58
@Hixie
Copy link
Contributor

Hixie commented Oct 31, 2016

:-)

@abarth abarth merged commit 018ab3f into flutter:master Oct 31, 2016
@abarth abarth deleted the default_child_list branch October 31, 2016 03:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ScrollableGrid: Omitting optional 'children' parameter returns broken widget

2 participants

@abarth @Hixie