Make device debuggable if useDwdsWebSocketConnection is true and added simple test case #171648

jyameo · 2025-07-04T18:33:51Z

Make device debuggable if useDwdsWebSocketConnection is true - This change is needed to support hot reload on web-server devices over websocket-based DWDS.
Added simple test case to test hot reload over websocket

related to dart-lang/webdev#2605, dart-lang/webdev#2645 and dart-lang/webdev#2646

flutter-dashboard · 2025-07-04T18:33:54Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart

packages/flutter_tools/test/integration.shard/test_data/hot_reload_websocket_test_common.dart

nshahan

LGTM with a few more comments.

nshahan · 2025-07-23T17:43:54Z

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart

  /// WebServer device is debuggable when running with --start-paused.
-  bool get deviceIsDebuggable => device!.device is! WebServerDevice || debuggingOptions.startPaused;
+  bool get deviceIsDebuggable =>
+      device!.device is! WebServerDevice ||
+      debuggingOptions.startPaused ||
+      _useDwdsWebSocketConnection;


Do we actually support debugging with the web socket connection without start paused?

yes we do now. When we run the app from the terminal it runs without --start-paused. From vscode, it starts paused.

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart

nshahan · 2025-08-08T22:10:40Z

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart

      assert(connectDebug != null);
-      _connectionResult = await connectDebug;
-      unawaited(_connectionResult!.debugConnection!.onDone.whenComplete(_cleanupAndExit));
+      unawaited(


The diff is making it tricky to see but is this the key difference that is breaking the deadlock we were discussing?

That's correct. The app.started event needs to go out for the tool to start the test driver process, and the VM service doesn't need to be configured before that's sent out since there's a separate app.debugPort event used to indicate that the service is available.

Attaching a listener to connectDebug instead of blocking on its completion and not requiring the service to be available before application startup lets us break the deadlock safely.

…e and added simple test case (flutter/flutter#171648)

flutter/flutter@3821790...1590543 2025-08-09 [email protected] Make device debuggable if useDwdsWebSocketConnection is true and added simple test case (flutter/flutter#171648) 2025-08-09 [email protected] Roll Dart SDK from 91cbf6d7563a to 6a7ae1ffd1c9 (1 revision) (flutter/flutter#173487) 2025-08-09 [email protected] add `--variance host_debug_unopt_arm64` for apple chip simulator (flutter/flutter#173475) 2025-08-08 [email protected] [WebParagraph] Fix a property name on newer Chrome versions (flutter/flutter#173477) 2025-08-08 [email protected] Make sure that a Checkbox doesn't crash in 0x0 environment (flutter/flutter#173178) 2025-08-08 [email protected] Make sure that a RawChip doesn't crash in 0x0 environment (flutter/flutter#173265) 2025-08-08 [email protected] Fix tooltip crash when route has secondary animation (flutter/flutter#172678) 2025-08-08 [email protected] Roll Skia from 86824ed582be to 44bb9d908ee4 (3 revisions) (flutter/flutter#173476) 2025-08-08 [email protected] Fix null value reference in `flutter logs` path (flutter/flutter#173437) 2025-08-08 [email protected] Remove jetifier usages from framework and engine (flutter/flutter#173459) 2025-08-08 [email protected] [a11y] Textfield has flag `isFocusable` set to true (flutter/flutter#173235) 2025-08-08 [email protected] Roll Dart SDK from 4b7b565eb468 to 91cbf6d7563a (1 revision) (flutter/flutter#173469) 2025-08-08 [email protected] Roll Packages from 6efb759 to 34948d1 (4 revisions) (flutter/flutter#173470) 2025-08-08 [email protected] Roll Skia from a6ccfeafbfba to 86824ed582be (20 revisions) (flutter/flutter#173468) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

jtmcdole · 2025-08-11T14:22:00Z

Reason for revert: Multiple breaking tree tests

auto-submit · 2025-08-11T14:22:22Z

Time to revert pull request flutter/flutter/171648 has elapsed.
You need to open the revert manually and process as a regular pull request.

…and added simple test case (flutter#171648)" This reverts commit 1590543.

#173551) Reverts #171648 for multiple failing tests <img width="624" height="347" alt="image" src="https://github.com/user-attachments/assets/affc7820-bd1a-408a-822c-3bc0df5f985d" />

…d simple test case (flutter#171648) - Make device debuggable if useDwdsWebSocketConnection is true - This change is needed to support hot reload on web-server devices over websocket-based DWDS. - Added simple test case to test hot reload over websocket related to dart-lang/webdev#2605, dart-lang/webdev#2645 and dart-lang/webdev#2646 --------- Co-authored-by: Ben Konyi <[email protected]>

flutter#173551) Reverts flutter#171648 for multiple failing tests <img width="624" height="347" alt="image" src="https://github.com/user-attachments/assets/affc7820-bd1a-408a-822c-3bc0df5f985d" />

…d simple test case (flutter#171648) - Make device debuggable if useDwdsWebSocketConnection is true - This change is needed to support hot reload on web-server devices over websocket-based DWDS. - Added simple test case to test hot reload over websocket related to dart-lang/webdev#2605, dart-lang/webdev#2645 and dart-lang/webdev#2646 --------- Co-authored-by: Ben Konyi <[email protected]>

flutter#173551) Reverts flutter#171648 for multiple failing tests <img width="624" height="347" alt="image" src="https://github.com/user-attachments/assets/affc7820-bd1a-408a-822c-3bc0df5f985d" />

…d simple test case (flutter#171648) - Make device debuggable if useDwdsWebSocketConnection is true - This change is needed to support hot reload on web-server devices over websocket-based DWDS. - Added simple test case to test hot reload over websocket related to dart-lang/webdev#2605, dart-lang/webdev#2645 and dart-lang/webdev#2646 --------- Co-authored-by: Ben Konyi <[email protected]>

flutter#173551) Reverts flutter#171648 for multiple failing tests <img width="624" height="347" alt="image" src="https://github.com/user-attachments/assets/affc7820-bd1a-408a-822c-3bc0df5f985d" />

…d simple test case (flutter#171648) - Make device debuggable if useDwdsWebSocketConnection is true - This change is needed to support hot reload on web-server devices over websocket-based DWDS. - Added simple test case to test hot reload over websocket related to dart-lang/webdev#2605, dart-lang/webdev#2645 and dart-lang/webdev#2646 --------- Co-authored-by: Ben Konyi <[email protected]>

flutter#173551) Reverts flutter#171648 for multiple failing tests <img width="624" height="347" alt="image" src="https://github.com/user-attachments/assets/affc7820-bd1a-408a-822c-3bc0df5f985d" />

make device debuggable if useDwdsWebSocketConnection is true

b47ba3b

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 4, 2025

jyameo added 2 commits July 4, 2025 16:17

added simple hot reload test case

1e43dbb

refactored code

707c9fd

jyameo changed the title ~~Make device debuggable if useDwdsWebSocketConnection is true~~ Make device debuggable if useDwdsWebSocketConnection is true and added simple test case Jul 4, 2025

jyameo added 3 commits July 4, 2025 16:26

rename test to testAll

c211c93

skip test if platform is not MacOS

d07ce8e

Merge branch 'main' into websocketproxy-1

800d614

jyameo mentioned this pull request Jul 17, 2025

Support running DWDS without a Chrome Debug Port (web-socket-based) dart-lang/webdev#2639

Merged

jyameo requested review from nshahan and srujzs July 18, 2025 19:13

biggs0125 requested changes Jul 21, 2025

View reviewed changes

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart Outdated Show resolved Hide resolved

packages/flutter_tools/test/integration.shard/test_data/hot_reload_websocket_test_common.dart Outdated Show resolved Hide resolved

quyenlv-unicloud mentioned this pull request Jul 21, 2025

remove --start-paused flag by default and set useDwdsWebSocketConnect… #170612

Merged

srujzs approved these changes Jul 21, 2025

View reviewed changes

packages/flutter_tools/test/integration.shard/test_data/hot_reload_websocket_test_common.dart Outdated Show resolved Hide resolved

packages/flutter_tools/test/integration.shard/test_data/hot_reload_websocket_test_common.dart Outdated Show resolved Hide resolved

nshahan approved these changes Jul 23, 2025

View reviewed changes

jyameo added 4 commits July 23, 2025 14:10

Merge branch 'main' into websocketproxy-1

6244bfb

Merge branch 'main' into websocketproxy-1

a48b012

Merge branch 'main' into websocketproxy-1

55f47ef

addressed comments

541df7d

jyameo requested a review from biggs0125 July 28, 2025 19:17

jyameo added 4 commits July 28, 2025 15:55

added skip comment

9b5b69f

Merge branch 'main' into websocketproxy-1

ee08d9a

added useDwdsWebSocketConnection to FakeWebDevFS

4ca1292

fix analyzer errors

d1ee3ed

jyameo requested a review from a team as a code owner July 29, 2025 14:49

github-actions bot added the team-ios Owned by iOS platform team label Jul 29, 2025

jyameo added 2 commits July 29, 2025 10:53

Merge branch 'main' into websocketproxy-1

a7b534e

revert change to build_macos_test

fd2c18a

github-actions bot removed the team-ios Owned by iOS platform team label Jul 29, 2025

bkonyi added 3 commits August 8, 2025 20:49

Fix more tests

d2b178c

Ensure test_driver utilities always wait for app.debugPort event

7d1af8a

Don't wait for app.debugPort for web-server device

785d590

nshahan reviewed Aug 8, 2025

View reviewed changes

Address comments

3336150

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 9, 2025

auto-submit bot added this pull request to the merge queue Aug 9, 2025

Merged via the queue into flutter:master with commit 1590543 Aug 9, 2025
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 9, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2025

1590543f6 Make device debuggable if useDwdsWebSocketConnection is tru…

f10f766

…e and added simple test case (flutter/flutter#171648)

engine-flutter-autoroll mentioned this pull request Aug 9, 2025

Roll Flutter from 38217906e95c to 1590543f6794 (14 revisions) flutter/packages#9779

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2025

1590543f6 Make device debuggable if useDwdsWebSocketConnection is tru…

24a1b3a

…e and added simple test case (flutter/flutter#171648)

engine-flutter-autoroll mentioned this pull request Aug 9, 2025

Roll Flutter from 38217906e95c to 1590543f6794 (14 revisions) flutter/packages#9780

Merged

jtmcdole added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

jtmcdole added a commit to jtmcdole/flutter that referenced this pull request Aug 11, 2025

Revert "Make device debuggable if useDwdsWebSocketConnection is true …

9c5c8a6

…and added simple test case (flutter#171648)" This reverts commit 1590543.

jtmcdole mentioned this pull request Aug 11, 2025

Revert "Make device debuggable if useDwdsWebSocketConnection is true … #173551

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make device debuggable if useDwdsWebSocketConnection is true and added simple test case #171648

Make device debuggable if useDwdsWebSocketConnection is true and added simple test case #171648

Uh oh!

jyameo commented Jul 4, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nshahan left a comment

Uh oh!

nshahan Jul 23, 2025

Uh oh!

jyameo Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

nshahan Aug 8, 2025

Uh oh!

bkonyi Aug 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

jtmcdole commented Aug 11, 2025

Uh oh!

auto-submit bot commented Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Make device debuggable if useDwdsWebSocketConnection is true and added simple test case #171648

Make device debuggable if useDwdsWebSocketConnection is true and added simple test case #171648

Uh oh!

Conversation

jyameo commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nshahan left a comment

Choose a reason for hiding this comment

Uh oh!

nshahan Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

jyameo Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nshahan Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jtmcdole commented Aug 11, 2025

Uh oh!

auto-submit bot commented Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jyameo commented Jul 4, 2025 •

edited

Loading

bkonyi Aug 9, 2025 •

edited

Loading