This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disambiguate horizontal and vertical scrolling #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. This is great. |
We now have separate gestures for horizontal, vertical, and pan scrolling.
abarth
force-pushed
the
scroll_disambig
branch
from
4da665a to
bf3db50
Compare
abarth
added a commit
that referenced
this pull request
Aug 29, 2015
Disambiguate horizontal and vertical scrolling
Contributor
|
Is this applied to the widgets yet? Does the card demo feel better, for instance? |
Contributor
Author
|
This is applied to widgets. It works in PinkSky. Hans is working integrating it with dismissable. |
skia-flutter-autoroll
added a commit
to skia-flutter-autoroll/engine
that referenced
this pull request
May 7, 2020
https://dart.googlesource.com/sdk.git/+log/e86e4d61834a..ce62ad2e8b40 git log e86e4d6..ce62ad2 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 [email protected] Migration: test "add hint" functionality, and fix a path problem on Windows 2020-05-07 [email protected] Migration: turn off removeViaComments by default. 2020-05-07 [email protected] [vm] Use consistent signatures for native call wrappers and native function symbolizers. 2020-05-07 [email protected] Adjust tests for new return rules, cf. language PR flutter#941, #948. 2020-05-07 [email protected] analyzer: Report unused public members of private and unnamed extensions 2020-05-07 [email protected] Migrator: Always remove @ from @required 2020-05-07 [email protected] [co19] Roll co19 to f65f3578f95415c9a2f3ad002aac7b507549e64a 2020-05-07 [email protected] [vm] Fix vm/dart/run_appended_aot_snapshot_test which uses dart2native internals. 2020-05-07 [email protected] Migrate tests to language/stack_trace. 2020-05-07 [email protected] [gardening] Skip isolate tests on android, make them run less in simulator mode 2020-05-07 [email protected] [vm/compiler] Disambiguate Code names when emitting instruction sizes info. 2020-05-07 [email protected] [SDK] Adds documentation about updating ABI_VERSION 2020-05-07 [email protected] [parser] Show errors from 'handleErrorToken' in parser suite tests Created with: gclient setdep -r src/third_party/dart@ce62ad2e8b40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: [email protected]
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Add "--verbose" to "--help" and hide most options normally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have separate gestures for horizontal, vertical, and pan scrolling.