This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll Dart to bb56d4592f7cde38cdf0a04ad7f40d105af99d11 #6253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dea9aa Share inlining cache between members 272473b Remove getters allowing access to all enclosing type parameter types. f5ec9b0 This CL changes some status comments, but also points out an issue. a16c7d8 Fix typo in mixin test. cea39db Perform instance member inference for mixins. 65b390c Simplify summary resynthesis tests ca8e5ba Fix #34443 fix tests that will fail with int2double 0e878dd Fix several inferred type summary tests. 1397fd9 Fix test_variable_final_top_level_untyped. 61096ac Improve analyzer/fasta error code matching 1a8b1bf Fix test_bottom_reference_shared. 7bc5c55 Fix test test_implicit_dependencies_follow_other_dependencies. 49da026 Report error for `extends void` type parameters 3cf61ae Fix #34444, rounded doubles in double literals test 260ea4b Add an option to use one-phase summaries. 7c5b3dc [vm/tfa] Pass receiver type into field initializer summaries. cd26b88 linter 0.1.62 8e4933c Tests for ClassElement.allSupertypes for mixins. a48120a Wire up placeholder executable in pkg/analyzer_fe_comparison.
zanderso
approved these changes
Sep 14, 2018
Member
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2018
flutter/engine@60bb5da...24d9460 git log 60bb5da..24d9460 --no-merges --oneline 24d9460 Roll Dart to bb56d4592f7cde38cdf0a04ad7f40d105af99d11 (flutter/engine#6253) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Sep 14, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2018
flutter/engine@60bb5da...a0dff81 git log 60bb5da..a0dff81 --no-merges --oneline a0dff81 Update test and license scripts for Dart SDK 2.1.0 (flutter/engine#6254) 24d9460 Roll Dart to bb56d4592f7cde38cdf0a04ad7f40d105af99d11 (flutter/engine#6253) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2018
flutter/engine@60bb5da...e817f2d git log 60bb5da..e817f2d --no-merges --oneline e817f2d Roll src/third_party/skia 7724d3f4949b..7b617a7fc85d (6 commits) (flutter/engine#6255) a0dff81 Update test and license scripts for Dart SDK 2.1.0 (flutter/engine#6254) 24d9460 Roll Dart to bb56d4592f7cde38cdf0a04ad7f40d105af99d11 (flutter/engine#6253) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
* bb56d45 Fix receiver type for js-interop access 8dea9aa Share inlining cache between members 272473b Remove getters allowing access to all enclosing type parameter types. f5ec9b0 This CL changes some status comments, but also points out an issue. a16c7d8 Fix typo in mixin test. cea39db Perform instance member inference for mixins. 65b390c Simplify summary resynthesis tests ca8e5ba Fix flutter#34443 fix tests that will fail with int2double 0e878dd Fix several inferred type summary tests. 1397fd9 Fix test_variable_final_top_level_untyped. 61096ac Improve analyzer/fasta error code matching 1a8b1bf Fix test_bottom_reference_shared. 7bc5c55 Fix test test_implicit_dependencies_follow_other_dependencies. 49da026 Report error for `extends void` type parameters 3cf61ae Fix flutter#34444, rounded doubles in double literals test 260ea4b Add an option to use one-phase summaries. 7c5b3dc [vm/tfa] Pass receiver type into field initializer summaries. cd26b88 linter 0.1.62 8e4933c Tests for ClassElement.allSupertypes for mixins. a48120a Wire up placeholder executable in pkg/analyzer_fe_comparison. * update licenses
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
* bb56d45 Fix receiver type for js-interop access 8dea9aa Share inlining cache between members 272473b Remove getters allowing access to all enclosing type parameter types. f5ec9b0 This CL changes some status comments, but also points out an issue. a16c7d8 Fix typo in mixin test. cea39db Perform instance member inference for mixins. 65b390c Simplify summary resynthesis tests ca8e5ba Fix flutter#34443 fix tests that will fail with int2double 0e878dd Fix several inferred type summary tests. 1397fd9 Fix test_variable_final_top_level_untyped. 61096ac Improve analyzer/fasta error code matching 1a8b1bf Fix test_bottom_reference_shared. 7bc5c55 Fix test test_implicit_dependencies_follow_other_dependencies. 49da026 Report error for `extends void` type parameters 3cf61ae Fix flutter#34444, rounded doubles in double literals test 260ea4b Add an option to use one-phase summaries. 7c5b3dc [vm/tfa] Pass receiver type into field initializer summaries. cd26b88 linter 0.1.62 8e4933c Tests for ClassElement.allSupertypes for mixins. a48120a Wire up placeholder executable in pkg/analyzer_fe_comparison. * update licenses
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.