Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@skia-flutter-autoroll
Copy link
Contributor

https://skia.googlesource.com/skia.git/+log/12c8bd6ac1d9..c1c8ff84997c

2024-11-25 [email protected] Revert "Change window::DisplayParams to be immutable and passed by pointer"
2024-11-25 [email protected] [rust png] Build / sources organization: Separate decoder/ directory.
2024-11-25 [email protected] Roll vulkan-deps from 73e40f43c062 to 64698c1a35b2 (1 revision)
2024-11-25 [email protected] Change window::DisplayParams to be immutable and passed by pointer
2024-11-25 [email protected] Use SkSafe32 functions when adding/subtracting deltas.
2024-11-25 [email protected] Save 16 bytes on GrContextOptions allocations* by reordering fields
2024-11-25 [email protected] Roll skottie-base from e4021a6fc9aa to 52028e548417
2024-11-25 [email protected] Roll debugger-app-base from 931df19ec335 to 9e05eb5b9edb
2024-11-25 [email protected] Roll shaders-base from 99b73d05cdae to 7bdb025e3cbb
2024-11-25 [email protected] Roll jsfiddle-base from 034839b9814b to 99d4627f212e
2024-11-25 [email protected] Roll skottie-base from c0ad379b6c58 to e4021a6fc9aa
2024-11-25 [email protected] Fix DefaultImageProvider::Make() leak
2024-11-25 [email protected] Make SkGlyph and GrDriverBugWorkarounds trivially destructible
2024-11-25 [email protected] [graphite] Fix texture matrix for asyncReadPixelsYUV420

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/12c8bd6ac1d9..c1c8ff84997c

2024-11-25 [email protected] Revert "Change window::DisplayParams to be immutable and passed by pointer"
2024-11-25 [email protected] [rust png] Build / sources organization: Separate `decoder/` directory.
2024-11-25 [email protected] Roll vulkan-deps from 73e40f43c062 to 64698c1a35b2 (1 revision)
2024-11-25 [email protected] Change window::DisplayParams to be immutable and passed by pointer
2024-11-25 [email protected] Use SkSafe32 functions when adding/subtracting deltas.
2024-11-25 [email protected] Save 16 bytes on GrContextOptions allocations* by reordering fields
2024-11-25 [email protected] Roll skottie-base from e4021a6fc9aa to 52028e548417
2024-11-25 [email protected] Roll debugger-app-base from 931df19ec335 to 9e05eb5b9edb
2024-11-25 [email protected] Roll shaders-base from 99b73d05cdae to 7bdb025e3cbb
2024-11-25 [email protected] Roll jsfiddle-base from 034839b9814b to 99d4627f212e
2024-11-25 [email protected] Roll skottie-base from c0ad379b6c58 to e4021a6fc9aa
2024-11-25 [email protected] Fix DefaultImageProvider::Make() leak
2024-11-25 [email protected] Make SkGlyph and GrDriverBugWorkarounds trivially destructible
2024-11-25 [email protected] [graphite] Fix texture matrix for asyncReadPixelsYUV420

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll skia-flutter-autoroll force-pushed the skia-flutter-autoroll-ad83daee-68bc-4c2b-86df-c51dabad3124-1732576691 branch from 981f089 to 0a9bfb9 Compare November 25, 2024 23:18
@skia-flutter-autoroll skia-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2024
@auto-submit auto-submit bot merged commit 6ebfd9a into flutter:main Nov 26, 2024
36 checks passed
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 26, 2024
…159461)

flutter/engine@fe45a66...fb64399

2024-11-26 [email protected] iOS: Migrate PlatformViewsController to
Objective-C (flutter/engine#56790)
2024-11-26 [email protected] Started caching
HandleGLES's hash and made them immutable (flutter/engine#56800)
2024-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56802)
2024-11-26 [email protected] Roll Skia from 12c8bd6ac1d9 to
c1c8ff84997c (14 revisions) (flutter/engine#56801)
2024-11-25 [email protected] [Impeller] better handle allocation
herustics of Android slide in page transition. (flutter/engine#56762)
2024-11-25 [email protected] iOS: Eliminate logging of non-zero origin
platformviews (flutter/engine#56796)
2024-11-25 [email protected] [impeller] gles:
started storing the number of handle deletions to avoid reallocation
(flutter/engine#56799)
2024-11-25 [email protected] Roll Fuchsia Linux SDK from
9o0fWa2xVhmxV6Mtn... to 50xtjbMWWrqay_7m_... (flutter/engine#56795)
2024-11-25 [email protected] Roll Dart SDK from
df716eaa6ed2 to 4b49546a1dfa (1 revision) (flutter/engine#56793)
2024-11-25 [email protected] [iOS] Full
keyboard access scrolling (flutter/engine#56606)
2024-11-25 [email protected] [android] remove fml_check from
surface_texture_external_texture (flutter/engine#56760)
2024-11-25 [email protected] removed unused
variable for skia initialization (flutter/engine#56791)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 9o0fWa2xVhmx to 50xtjbMWWrqa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 26, 2024
…visions) (#159461)" (#159498)

<!-- start_original_pr_link -->
Reverts: #159461
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: yjbanov
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: engine regression
#159497
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: engine-flutter-autoroll
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {fluttergithubbot}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:

flutter/engine@fe45a66...fb64399

2024-11-26 [email protected] iOS: Migrate PlatformViewsController to
Objective-C (flutter/engine#56790)
2024-11-26 [email protected] Started caching
HandleGLES's hash and made them immutable (flutter/engine#56800)
2024-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56802)
2024-11-26 [email protected] Roll Skia from 12c8bd6ac1d9 to
c1c8ff84997c (14 revisions) (flutter/engine#56801)
2024-11-25 [email protected] [Impeller] better handle allocation
herustics of Android slide in page transition. (flutter/engine#56762)
2024-11-25 [email protected] iOS: Eliminate logging of non-zero origin
platformviews (flutter/engine#56796)
2024-11-25 [email protected] [impeller] gles:
started storing the number of handle deletions to avoid reallocation
(flutter/engine#56799)
2024-11-25 [email protected] Roll Fuchsia Linux SDK from
9o0fWa2xVhmxV6Mtn... to 50xtjbMWWrqay_7m_... (flutter/engine#56795)
2024-11-25 [email protected] Roll Dart SDK from
df716eaa6ed2 to 4b49546a1dfa (1 revision) (flutter/engine#56793)
2024-11-25 [email protected] [iOS] Full
keyboard access scrolling (flutter/engine#56606)
2024-11-25 [email protected] [android] remove fml_check from
surface_texture_external_texture (flutter/engine#56760)
2024-11-25 [email protected] removed unused
variable for skia initialization (flutter/engine#56791)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 9o0fWa2xVhmx to 50xtjbMWWrqa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 26, 2024
…159504)

flutter/engine@fe45a66...bd165dc

2024-11-26 [email protected] Revert "iOS: Migrate PlatformViewsController
to Objective-C (#56790)" (flutter/engine#56817)
2024-11-26 [email protected] iOS: Rename FlutterPlatformViews_Internal.mm
(flutter/engine#56816)
2024-11-26 [email protected] iOS: Eliminate global in platformviews
controller (flutter/engine#56805)
2024-11-26 [email protected] Roll Skia from a276978ba7c8 to
f149f852c70a (1 revision) (flutter/engine#56812)
2024-11-26 [email protected] Roll Skia from d7a267d88fd6 to
a276978ba7c8 (1 revision) (flutter/engine#56811)
2024-11-26 [email protected] Roll Skia from 8d9d892657a7 to
d7a267d88fd6 (1 revision) (flutter/engine#56810)
2024-11-26 [email protected] Roll Dart SDK from
bdb76c714009 to ca02d403f1a8 (1 revision) (flutter/engine#56809)
2024-11-26 [email protected] Roll Skia from b697dd1b03b2 to
8d9d892657a7 (1 revision) (flutter/engine#56808)
2024-11-26 [email protected] Roll Skia from c1c8ff84997c to
b697dd1b03b2 (1 revision) (flutter/engine#56807)
2024-11-26 [email protected] iOS: Delete
FlutterPlatformViewsController.layerPoolSize (flutter/engine#56806)
2024-11-26 [email protected] Roll Dart SDK from
4b49546a1dfa to bdb76c714009 (1 revision) (flutter/engine#56803)
2024-11-26 [email protected] iOS: Migrate PlatformViewsController to
Objective-C (flutter/engine#56790)
2024-11-26 [email protected] Started caching
HandleGLES's hash and made them immutable (flutter/engine#56800)
2024-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56802)
2024-11-26 [email protected] Roll Skia from 12c8bd6ac1d9 to
c1c8ff84997c (14 revisions) (flutter/engine#56801)
2024-11-25 [email protected] [Impeller] better handle allocation
herustics of Android slide in page transition. (flutter/engine#56762)
2024-11-25 [email protected] iOS: Eliminate logging of non-zero origin
platformviews (flutter/engine#56796)
2024-11-25 [email protected] [impeller] gles:
started storing the number of handle deletions to avoid reallocation
(flutter/engine#56799)
2024-11-25 [email protected] Roll Fuchsia Linux SDK from
9o0fWa2xVhmxV6Mtn... to 50xtjbMWWrqay_7m_... (flutter/engine#56795)
2024-11-25 [email protected] Roll Dart SDK from
df716eaa6ed2 to 4b49546a1dfa (1 revision) (flutter/engine#56793)
2024-11-25 [email protected] [iOS] Full
keyboard access scrolling (flutter/engine#56606)
2024-11-25 [email protected] [android] remove fml_check from
surface_texture_external_texture (flutter/engine#56760)
2024-11-25 [email protected] removed unused
variable for skia initialization (flutter/engine#56791)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 9o0fWa2xVhmx to 50xtjbMWWrqa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll skia-flutter-autoroll deleted the skia-flutter-autoroll-ad83daee-68bc-4c2b-86df-c51dabad3124-1732576691 branch December 2, 2024 23:49
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…ngine#56801)

https://skia.googlesource.com/skia.git/+log/12c8bd6ac1d9..c1c8ff84997c

2024-11-25 [email protected] Revert "Change window::DisplayParams to be immutable and passed by pointer"
2024-11-25 [email protected] [rust png] Build / sources organization: Separate `decoder/` directory.
2024-11-25 [email protected] Roll vulkan-deps from 73e40f43c062 to 64698c1a35b2 (1 revision)
2024-11-25 [email protected] Change window::DisplayParams to be immutable and passed by pointer
2024-11-25 [email protected] Use SkSafe32 functions when adding/subtracting deltas.
2024-11-25 [email protected] Save 16 bytes on GrContextOptions allocations* by reordering fields
2024-11-25 [email protected] Roll skottie-base from e4021a6fc9aa to 52028e548417
2024-11-25 [email protected] Roll debugger-app-base from 931df19ec335 to 9e05eb5b9edb
2024-11-25 [email protected] Roll shaders-base from 99b73d05cdae to 7bdb025e3cbb
2024-11-25 [email protected] Roll jsfiddle-base from 034839b9814b to 99d4627f212e
2024-11-25 [email protected] Roll skottie-base from c0ad379b6c58 to e4021a6fc9aa
2024-11-25 [email protected] Fix DefaultImageProvider::Make() leak
2024-11-25 [email protected] Make SkGlyph and GrDriverBugWorkarounds trivially destructible
2024-11-25 [email protected] [graphite] Fix texture matrix for asyncReadPixelsYUV420

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants