-
Notifications
You must be signed in to change notification settings - Fork 6k
[dart2wasm] Move web wasm embedder to new dart2wasm embedder API #55037
[dart2wasm] Move web wasm embedder to new dart2wasm embedder API #55037
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This removes usages of the deprecated top-level instantiate and invoke methods and replaces it by method calls to the embedder objects. See [0] for the change that introduce this embedder API. [0] https://dart-review.googlesource.com/c/sdk/+/383242/6
ddcf6ff to
d025c60
Compare
|
Thanks, @eyebrowsoffire & @osa1 ! |
This removes usages of the deprecated top-level
instantiateandinvokemethods and replaces it by method calls to the embedder objects.See [0] for the change that introduce this embedder API.
[0] https://dart-review.googlesource.com/c/sdk/+/383242/6