Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[canvaskit] Add animation detection for GIFs #54483

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[canvaskit] Add animation detection for GIFs #54483

merged 3 commits into from
Aug 13, 2024

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Aug 9, 2024

Detect if a GIF is animated to determine if we need to use Skia to decode it or if we can use tag decoding.

Fixes flutter/flutter#151911

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Aug 9, 2024
@kevmoo
Copy link
Contributor

kevmoo commented Aug 9, 2024

Nit: I wish the source pointed to some docs about how this all was interpreted.

Would ease maintenance later.

@harryterkelsen
Copy link
Contributor Author

harryterkelsen commented Aug 10, 2024

I linked to the GIF 89a spec in the doc comment for the class. Unfortunately since it's a text file I can't link to specific sections corresponding to the methods, but I stick to the terminology in the spec so the sections should be easy to find if you have the spec open.

mdebbar
mdebbar approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/web_ui/lib/src/engine/image_format_detector.dart Outdated

// Read file size byte.
_readUint32();
// Skip reading file size byte.
Copy link
Contributor

@mdebbar mdebbar Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
// Skip reading file size byte.
// Skip reading file size bytes.

Copy link
Contributor Author

@harryterkelsen harryterkelsen Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2024
@harryterkelsen harryterkelsen requested a review from mdebbar August 13, 2024 19:46
@auto-submit auto-submit bot merged commit 2fcb51a into flutter:main Aug 13, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
2fcb51a3a [canvaskit] Add animation detection for GIFs (flutter/engin…
d35aeb2 
…e#54483)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
2fcb51a3a [canvaskit] Add animation detection for GIFs (flutter/engin…
481390d 
…e#54483)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
2fcb51a3a [canvaskit] Add animation detection for GIFs (flutter/engin…
77858a7 
…e#54483)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
2fcb51a3a [canvaskit] Add animation detection for GIFs (flutter/engin…
edbdf22 
…e#54483)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 14, 2024
@engine-flutter-autoroll
Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revi…
92c98e8 
…sions) (#153413)

Manual roll requested by [email protected]

flutter/engine@019f9e3...5909666

2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" (flutter/engine#54552)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (#54543)" (flutter/engine#54550)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (#54546)" (flutter/engine#54549)
2024-08-14 [email protected] macOS: refactor create_macos_framework.py (flutter/engine#54546)
2024-08-13 [email protected] [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
2024-08-13 [email protected] Update dartdoc for gpu.dart (flutter/engine#54529)
2024-08-13 [email protected] macOS: Clean up create_ios_framework.py (flutter/engine#54543)
2024-08-13 [email protected] Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
2024-08-13 [email protected] Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
2024-08-13 [email protected] [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
2024-08-13 [email protected] Preserve background frame damage (flutter/engine#54540)
2024-08-13 6844906[email protected] [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
@engine-flutter-autoroll @DBowen33
Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revi…
a9fe739 
…sions) (flutter#153413)

Manual roll requested by [email protected]

flutter/engine@019f9e3...5909666

2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter#54541)" (flutter/engine#54552)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (flutter#54543)" (flutter/engine#54550)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (flutter#54546)" (flutter/engine#54549)
2024-08-14 [email protected] macOS: refactor create_macos_framework.py (flutter/engine#54546)
2024-08-13 [email protected] [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
2024-08-13 [email protected] Update dartdoc for gpu.dart (flutter/engine#54529)
2024-08-13 [email protected] macOS: Clean up create_ios_framework.py (flutter/engine#54543)
2024-08-13 [email protected] Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
2024-08-13 [email protected] Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
2024-08-13 [email protected] [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
2024-08-13 [email protected] Preserve background frame damage (flutter/engine#54540)
2024-08-13 6844906[email protected] [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revi…
ad17c66 
…sions) (flutter#153413)

Manual roll requested by [email protected]

flutter/engine@019f9e3...5909666

2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter#54541)" (flutter/engine#54552)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (flutter#54543)" (flutter/engine#54550)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (flutter#54546)" (flutter/engine#54549)
2024-08-14 [email protected] macOS: refactor create_macos_framework.py (flutter/engine#54546)
2024-08-13 [email protected] [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
2024-08-13 [email protected] Update dartdoc for gpu.dart (flutter/engine#54529)
2024-08-13 [email protected] macOS: Clean up create_ios_framework.py (flutter/engine#54543)
2024-08-13 [email protected] Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
2024-08-13 [email protected] Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
2024-08-13 [email protected] [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
2024-08-13 [email protected] Preserve background frame damage (flutter/engine#54540)
2024-08-13 6844906[email protected] [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mdebbar mdebbar Awaiting requested review from mdebbar

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[canvaskit] Determine if image is animated by reading its header and use Skia to decode in that case

3 participants

@harryterkelsen @kevmoo @mdebbar