From 6b9ea14421cfdf9b349e136e222a3253c3fb10b7 Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Fri, 14 Jun 2024 11:17:14 -0400 Subject: [PATCH] [web] Don't add `href="#"` to semantics links --- lib/web_ui/lib/src/engine/semantics/link.dart | 5 ++--- lib/web_ui/test/engine/semantics/semantics_test.dart | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/web_ui/lib/src/engine/semantics/link.dart b/lib/web_ui/lib/src/engine/semantics/link.dart index 87a2a47a0759c..3108e8cea858a 100644 --- a/lib/web_ui/lib/src/engine/semantics/link.dart +++ b/lib/web_ui/lib/src/engine/semantics/link.dart @@ -18,9 +18,8 @@ class Link extends PrimaryRoleManager { @override DomElement createElement() { final DomElement element = domDocument.createElement('a'); - // TODO(chunhtai): Fill in the real link once the framework sends entire uri. - // https://github.com/flutter/flutter/issues/102535. - element.setAttribute('href', '#'); + // TODO(mdebbar): Fill in the real link once the framework sends entire uri. + // https://github.com/flutter/flutter/issues/150263. element.style.display = 'block'; return element; } diff --git a/lib/web_ui/test/engine/semantics/semantics_test.dart b/lib/web_ui/test/engine/semantics/semantics_test.dart index 117ebc55cb60a..c89472bbfa826 100644 --- a/lib/web_ui/test/engine/semantics/semantics_test.dart +++ b/lib/web_ui/test/engine/semantics/semantics_test.dart @@ -3536,6 +3536,7 @@ void _testLink() { final SemanticsObject object = pumpSemantics(); expect(object.element.tagName.toLowerCase(), 'a'); + expect(object.element.hasAttribute('href'), isFalse); }); }