Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@tugorez
Copy link
Contributor

@tugorez tugorez commented May 2, 2024

Put the view focus functionality behind a (disabled by default) flag

Should unblock flutter/flutter#143259

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label May 2, 2024
@tugorez tugorez requested review from ditman and yjbanov May 2, 2024 20:31
@tugorez tugorez marked this pull request as ready for review May 2, 2024 20:31
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tugorez tugorez added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024
@auto-submit auto-submit bot merged commit fc71b65 into flutter:main May 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 3, 2024
…147753)

flutter/engine@3f1f819...fc71b65

2024-05-02 [email protected] Put the view focus functionality behind a (disabled by default) flag (flutter/engine#52527)
2024-05-02 [email protected] Roll Skia from f9671ecda7da to 716e757c1ffb (5 revisions) (flutter/engine#52528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants