Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Apr 3, 2024

Reverts #51712

Reason for revert: As discussed in flutter/flutter#143312, and in https://discord.com/channels/608014603317936148/1224499330824802375. I apologize if this seems hasty and not fully justified, but it is important that the engine repo follows policies like this to make it easier for our various teams to work together.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Apr 3, 2024
@zanderso zanderso requested a review from yjbanov April 3, 2024 02:17
@zanderso
Copy link
Member Author

zanderso commented Apr 3, 2024

cc @goderbauer @matanlurey @mdebbar @eyebrowsoffire

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 0da1b2e into main Apr 3, 2024
@zanderso zanderso deleted the revert-51712-mdebbar-patch-2 branch April 3, 2024 03:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 3, 2024
…146179)

flutter/engine@e603f89...0da1b2e

2024-04-03 [email protected] Revert "Prevent `solo: true` from being committed" (flutter/engine#51858)
2024-04-03 [email protected] Roll Dart SDK from e6e6d5fe3fb0 to 091dd9120d35 (4 revisions) (flutter/engine#51845)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants