From bb0f4c7c7d887c23faa7a98fcacbc33370a95c41 Mon Sep 17 00:00:00 2001
From: jonahwilliams <jonahwilliams@google.com>
Date: Mon, 1 Apr 2024 12:20:01 -0700
Subject: [PATCH] make not consuming outputs warning ignored.

---
 impeller/renderer/backend/vulkan/debug_report_vk.cc | 7 +++++++
 impeller/scene/shaders/unlit.frag                   | 7 +------
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/impeller/renderer/backend/vulkan/debug_report_vk.cc b/impeller/renderer/backend/vulkan/debug_report_vk.cc
index fce16f8751d4b..2d69f7f84ed7b 100644
--- a/impeller/renderer/backend/vulkan/debug_report_vk.cc
+++ b/impeller/renderer/backend/vulkan/debug_report_vk.cc
@@ -110,6 +110,13 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
   if (data->messageIdNumber == 0x2c36905d) {
     return Result::kContinue;
   }
+  // This is a performance warning when a fragment stage does not consume all
+  // varyings from the vertex stage. We ignore this as we want to use a single
+  // vertex stage for the runtime effect shader without trying to determine if
+  // the fragment consumes it or not.
+  if (data->messageIdNumber == 0x609A13B) {
+    return Result::kContinue;
+  }
 
   std::vector<std::pair<std::string, std::string>> items;
 
diff --git a/impeller/scene/shaders/unlit.frag b/impeller/scene/shaders/unlit.frag
index 0c5c317652047..f9d8cd4173131 100644
--- a/impeller/scene/shaders/unlit.frag
+++ b/impeller/scene/shaders/unlit.frag
@@ -17,13 +17,8 @@ in vec4 v_color;
 
 out vec4 frag_color;
 
-float consume_unused() {
-  return (v_position.x + v_tangent_space[0][0]) * 0.001;
-}
-
 void main() {
   vec4 vertex_color = mix(vec4(1), v_color, frag_info.vertex_color_weight);
   frag_color = texture(base_color_texture, v_texture_coords) * vertex_color *
-                   frag_info.color +
-               consume_unused();
+               frag_info.color;
 }