This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. (#51685)"
#51718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Mar 27, 2024
auto-submit
bot
deleted the
revert_b7dddee939f2429e5fd3574a63f9dfac4f486a33
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2024
… as part of `goldctl imgtest add`. (flutter#51685)" (flutter/engine#51718)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2024
… as part of `goldctl imgtest add`. (flutter#51685)" (flutter/engine#51718)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2024
…145862) flutter/engine@d656625...73c145c 2024-03-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Use the scissor to limit all draws by clip coverage. (#51698)" (flutter/engine#51728) 2024-03-27 [email protected] [Skwasm] Correctly handle paragraphs with empty text. (flutter/engine#51695) 2024-03-27 [email protected] Roll Dart SDK from a600b67424a8 to 291217c1d399 (4 revisions) (flutter/engine#51716) 2024-03-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fail pre-submit if a negative image is encountered as part of `goldctl imgtest add`. (#51685)" (flutter/engine#51718) 2024-03-27 [email protected] [Impeller] Use the scissor to limit all draws by clip coverage. (flutter/engine#51698) 2024-03-27 [email protected] [canvaskit] Fix color filter for dst and dstIn (flutter/engine#51693) 2024-03-27 [email protected] [Impeller] add missing null check. (flutter/engine#51711) 2024-03-27 [email protected] [Impeller] fix remaining Validation errors. (flutter/engine#51692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #51685
Initiated by: matanlurey
Reason for reverting: goldctl does not disambiguate negatives from untriaged images (see https://github.com/google/skia-buildbot/blob/9b9adad0805e6da96c4939cbd3d3855ab59998ee/gold-client/cmd/goldctl/cmd_imgtest_test.go#L325).
Original PR Author: matanlurey
Reviewed By: {mdebbar, gaaclarke}
This change reverts the following previous change:
flutter/engine-side fix for flutter/flutter#145043.Added tests, and fixed up some unrelated tests that were accidentally setting
pidinstead ofexitCode. Oops!/cc @zanderso and @eyebrowsoffire (current engine sheriff).