[Impeller] add missing null check. #51711
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Should there be a test or something that was failing prior to this? Why would we fail to allocate the texture? |
|
It can happen if we run out of memory basically |
Can we add a comment to that effect? Help out the next shmuck. LGTM though. test-exempt: It would be nice to test this, but creating an artificial scenario where we run out of memory intentionally is likely not worth the burden to CI for a simple null-check. |
jonahwilliams
added
the
autosubmit
…145862) flutter/engine@d656625...73c145c 2024-03-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Use the scissor to limit all draws by clip coverage. (#51698)" (flutter/engine#51728) 2024-03-27 [email protected] [Skwasm] Correctly handle paragraphs with empty text. (flutter/engine#51695) 2024-03-27 [email protected] Roll Dart SDK from a600b67424a8 to 291217c1d399 (4 revisions) (flutter/engine#51716) 2024-03-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fail pre-submit if a negative image is encountered as part of `goldctl imgtest add`. (#51685)" (flutter/engine#51718) 2024-03-27 [email protected] [Impeller] Use the scissor to limit all draws by clip coverage. (flutter/engine#51698) 2024-03-27 [email protected] [canvaskit] Fix color filter for dst and dstIn (flutter/engine#51693) 2024-03-27 [email protected] [Impeller] add missing null check. (flutter/engine#51711) 2024-03-27 [email protected] [Impeller] fix remaining Validation errors. (flutter/engine#51692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
surface can return null if we failed to allocate MSAA or depth/stencil textures.