From 694e4bbdf3922041db76a7679827281dc848fa35 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Fri, 15 Mar 2024 13:29:18 -0700 Subject: [PATCH 1/2] Log the successful upload of an image to skia gold. --- testing/scenario_app/bin/run_android_tests.dart | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/testing/scenario_app/bin/run_android_tests.dart b/testing/scenario_app/bin/run_android_tests.dart index 9c16fb9ed6fe6..277f6a5bdbe02 100644 --- a/testing/scenario_app/bin/run_android_tests.dart +++ b/testing/scenario_app/bin/run_android_tests.dart @@ -196,8 +196,14 @@ Future _run({ } if (SkiaGoldClient.isAvailable()) { final Future comparison = skiaGoldClient! - // Each color channel can be off by 2. - .addImg(fileName, goldenFile, screenshotSize: screenshot.pixelCount, pixelColorDelta: 8) + .addImg( + fileName, + goldenFile, + screenshotSize: screenshot.pixelCount, + // Each color channel can be off by 2. + pixelColorDelta: 8, + ) + .then((_) => logImportant('skia gold comparison succeeded: $fileName')) .catchError((Object error) { logWarning('skia gold comparison failed: $error'); comparisonsFailed++; From 441c064fa0ec9fb42e0232d74e8ed5abebdf3d7c Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Fri, 15 Mar 2024 13:29:42 -0700 Subject: [PATCH 2/2] ++ --- testing/scenario_app/bin/run_android_tests.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testing/scenario_app/bin/run_android_tests.dart b/testing/scenario_app/bin/run_android_tests.dart index 277f6a5bdbe02..669a255440f06 100644 --- a/testing/scenario_app/bin/run_android_tests.dart +++ b/testing/scenario_app/bin/run_android_tests.dart @@ -197,9 +197,9 @@ Future _run({ if (SkiaGoldClient.isAvailable()) { final Future comparison = skiaGoldClient! .addImg( - fileName, - goldenFile, - screenshotSize: screenshot.pixelCount, + fileName, + goldenFile, + screenshotSize: screenshot.pixelCount, // Each color channel can be off by 2. pixelColorDelta: 8, )