This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Embedder API] Remove view #51400
Merged
[Embedder API] Remove view #51400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Mar 18, 2024
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Overall lgtm. Just a couple minor nits!
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2024
…145350) flutter/engine@016206d...3fde367 2024-03-18 [email protected] Write recent logcat output to the LUCI log directory if an Android unit test fails (flutter/engine#51462) 2024-03-18 [email protected] [Embedder API] Remove view (flutter/engine#51400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
FlutterEngineRemoveViewto the embedder API. This will be used to destroy a view.The embedder API does not allow embedders to create multiple views yet.
Design doc: https://flutter.dev/go/multi-view-embedder-apis
Part of flutter/flutter#144806
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.