Small improvements to et lint command #51372
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm modulo test failures. I think it's possible to write unit tests of some of this as well, like the fatal() log message, at least.
- Default to dumping out lint logs (can be disabled with `--quiet` flag). - Add Logger.fatal which logs an error and throws a FatalError which is caught in main. - Simplify `findDartBinDirectory` implementation. - Make JSON serialized process artifacts more human readable.
| platform: FakePlatform(operatingSystem: Platform.linux), | ||
| platform: FakePlatform( | ||
| operatingSystem: Platform.linux, | ||
| resolvedExecutable: io.Platform.resolvedExecutable), |
There was a problem hiding this comment.
Nit: please put the ), on a new line
There was a problem hiding this comment.
We should not be manually formatting code.
There was a problem hiding this comment.
While I agree in principle, we should follow our project's style guide. For now, this means manual formatting. In the future we might be able to use the new Dart formatter. This file was already using Flutter's formatting, I'm not a huge fan of being inconsistent within a single file.
added test here. |
…145113) flutter/engine@c889344...d65c7e4 2024-03-13 [email protected] Small improvements to et lint command (flutter/engine#51372) 2024-03-13 [email protected] [Impeller] cleanup and test vk image usage flags. (flutter/engine#51301) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
--quietflag).findDartBinDirectoryimplementation.