From 2032dc7e4b34eef7d6eb9f2e125f37c6c59eb327 Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Tue, 5 Mar 2024 13:23:00 -0800 Subject: [PATCH] [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209) Turn the page, wash your hands. Addresses the following issues: * https://github.com/flutter/flutter/issues/143077 * https://github.com/flutter/flutter/issues/137714 * https://github.com/flutter/flutter/issues/138460 * https://github.com/flutter/flutter/issues/123671 * https://github.com/flutter/flutter/issues/141961 * https://github.com/flutter/flutter/issues/134432 Previous attempts: 1. https://github.com/flutter/engine/pull/50856 - reverted with https://github.com/flutter/engine/pull/51191 - fixed with https://github.com/flutter/engine/pull/51198 2. https://github.com/flutter/engine/pull/51209 - reverted with https://github.com/flutter/engine/pull/51217 - fixed with https://github.com/flutter/engine/pull/51218 --- impeller/entity/contents/content_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impeller/entity/contents/content_context.h b/impeller/entity/contents/content_context.h index 6d4fc90298689..d38df9ae03b5a 100644 --- a/impeller/entity/contents/content_context.h +++ b/impeller/entity/contents/content_context.h @@ -408,7 +408,7 @@ class ContentContext { /// // TODO(bdero): Remove this setting once StC is fully de-risked // https://github.com/flutter/flutter/issues/123671 - static constexpr bool kEnableStencilThenCover = false; + static constexpr bool kEnableStencilThenCover = true; #if IMPELLER_ENABLE_3D std::shared_ptr GetSceneContext() const;