From 6ad4592655402be7a307049ecb78aa141fdb0d30 Mon Sep 17 00:00:00 2001 From: Loic Sharma Date: Tue, 27 Feb 2024 15:59:35 -0800 Subject: [PATCH] [Windows] Reduce log level of unsupported accessibility event message --- shell/platform/windows/accessibility_plugin.cc | 4 ++-- .../platform/windows/flutter_windows_engine_unittests.cc | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/shell/platform/windows/accessibility_plugin.cc b/shell/platform/windows/accessibility_plugin.cc index 83dee4d37e303..a1fe9fc21d060 100644 --- a/shell/platform/windows/accessibility_plugin.cc +++ b/shell/platform/windows/accessibility_plugin.cc @@ -63,8 +63,8 @@ void HandleMessage(AccessibilityPlugin* plugin, const EncodableValue& message) { plugin->Announce(*message); } else { - FML_LOG(ERROR) << "Accessibility message type '" << *type - << "' is not supported."; + FML_LOG(WARNING) << "Accessibility message type '" << *type + << "' is not supported."; } } diff --git a/shell/platform/windows/flutter_windows_engine_unittests.cc b/shell/platform/windows/flutter_windows_engine_unittests.cc index fe7c4fb33674d..f9ebdbc278dfb 100644 --- a/shell/platform/windows/flutter_windows_engine_unittests.cc +++ b/shell/platform/windows/flutter_windows_engine_unittests.cc @@ -4,6 +4,7 @@ #include "flutter/shell/platform/windows/flutter_windows_engine.h" +#include "flutter/fml/logging.h" #include "flutter/fml/macros.h" #include "flutter/shell/platform/embedder/embedder.h" #include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h" @@ -716,6 +717,8 @@ TEST_F(FlutterWindowsEngineTest, AccessibilityAnnouncementHeadless) { // Verify the engine does not crash if it receives an accessibility event // it does not support yet. TEST_F(FlutterWindowsEngineTest, AccessibilityTooltip) { + fml::testing::LogCapture log_capture; + auto& context = GetContext(); WindowsConfigBuilder builder{context}; builder.SetDartEntrypoint("sendAccessibilityTooltipEvent"); @@ -736,6 +739,11 @@ TEST_F(FlutterWindowsEngineTest, AccessibilityTooltip) { while (!done) { windows_engine->task_runner()->ProcessTasks(); } + + // Verify no error was logged. + // Regression test for: + // https://github.com/flutter/flutter/issues/144274 + EXPECT_EQ(log_capture.str().find("tooltip"), std::string::npos); } class MockWindowsLifecycleManager : public WindowsLifecycleManager {