This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Make the engine own a map of views #51017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Feb 27, 2024
Member
There was a problem hiding this comment.
This looks great! Was going to suggest using non-member begin/end for looking up from iterables, but we're not at all consistent about this in the engine and if anything, a brief grep suggests that we mostly use foo.begin() and only sometimes use begin(foo), only saves one character either way! If this were a template, I'd push for it though!
yaakovschectman
approved these changes
Feb 27, 2024
8 tasks
loic-sharma
added
the
autosubmit
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
64a375de9c [Windows] Make the engine own a map of views (flutter/engine#51017) 73480bf11d Rename some classes in the engine_build_configs package (flutter/engine#51016) 2756f14a46 Remove rewrapper prefix from compiler commands for clang-tidy (flutter/engine#51001) 0f727a5b31 Improve, test, and fix a bug related to `adb logcat` filtering. (flutter/engine#51012) ab4d6db3f1 Move vulkan-deps to //flutter/third_party/vulkan-deps (flutter/engine#51013)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Windows engine's data structures to use a map of views.
This is a refactoring with no semantic changes. Flutter Windows's APIs restrict users to 0 or 1 view only - it is not possible to create multiple views yet.
One small step for Windows. One giant leap for multi-view.
Part of flutter/flutter#143765
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.