This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename some classes in the engine_build_configs package #51016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnmccutchan
commented
Feb 27, 2024
johnmccutchan
commented
- BuildConfig -> BuilderConfig
- GlobalBuild -> Build
Contributor
Author
|
test-exempt: renames only |
matanlurey
approved these changes
Feb 27, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Looks like a clean rename to me
zanderso
approved these changes
Feb 27, 2024
johnmccutchan
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/51016, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
- BuildConfig -> BuilderConfig - GlobalBuild -> Build
johnmccutchan
added
the
autosubmit
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
64a375de9c [Windows] Make the engine own a map of views (flutter/engine#51017) 73480bf11d Rename some classes in the engine_build_configs package (flutter/engine#51016) 2756f14a46 Remove rewrapper prefix from compiler commands for clang-tidy (flutter/engine#51001) 0f727a5b31 Improve, test, and fix a bug related to `adb logcat` filtering. (flutter/engine#51012) ab4d6db3f1 Move vulkan-deps to //flutter/third_party/vulkan-deps (flutter/engine#51013)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.