From 6c6d24187b937e6b4b0bc70d3f75977dc591a466 Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Fri, 23 Feb 2024 18:44:03 -0800 Subject: [PATCH 1/3] [Impeller] Enable StC and clipping on the depth buffer --- impeller/entity/contents/content_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impeller/entity/contents/content_context.h b/impeller/entity/contents/content_context.h index 6d4fc90298689..d38df9ae03b5a 100644 --- a/impeller/entity/contents/content_context.h +++ b/impeller/entity/contents/content_context.h @@ -408,7 +408,7 @@ class ContentContext { /// // TODO(bdero): Remove this setting once StC is fully de-risked // https://github.com/flutter/flutter/issues/123671 - static constexpr bool kEnableStencilThenCover = false; + static constexpr bool kEnableStencilThenCover = true; #if IMPELLER_ENABLE_3D std::shared_ptr GetSceneContext() const; From daef2069ea370c27f32db3ba17fb4700510d04e1 Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Mon, 4 Mar 2024 14:33:02 -0800 Subject: [PATCH 2/3] blank From 1fb0d4173deb460928c920790aa0a5a714faa691 Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Mon, 4 Mar 2024 15:29:12 -0800 Subject: [PATCH 3/3] Use default stencil config for Picture::ToImage --- impeller/aiks/picture.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/impeller/aiks/picture.cc b/impeller/aiks/picture.cc index 77f7fa8dbcfd0..64ea0c19aea7a 100644 --- a/impeller/aiks/picture.cc +++ b/impeller/aiks/picture.cc @@ -66,17 +66,15 @@ std::shared_ptr Picture::RenderToTexture( /*mip_count=*/1, "Picture Snapshot MSAA", // label RenderTarget:: - kDefaultColorAttachmentConfigMSAA, // color_attachment_config - std::nullopt // stencil_attachment_config + kDefaultColorAttachmentConfigMSAA // color_attachment_config ); } else { target = render_target_allocator.CreateOffscreen( *impeller_context, // context size, // size /*mip_count=*/1, - "Picture Snapshot", // label - RenderTarget::kDefaultColorAttachmentConfig, // color_attachment_config - std::nullopt // stencil_attachment_config + "Picture Snapshot", // label + RenderTarget::kDefaultColorAttachmentConfig // color_attachment_config ); } if (!target.IsValid()) {