From 7701043f8f1b9de11f90d0eaee2b8e1562b42ad5 Mon Sep 17 00:00:00 2001 From: Jackson Gardner Date: Fri, 16 Feb 2024 10:44:44 -0800 Subject: [PATCH] Temporarily disable goldens for Safari. --- lib/web_ui/dev/steps/run_suite_step.dart | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/web_ui/dev/steps/run_suite_step.dart b/lib/web_ui/dev/steps/run_suite_step.dart index a19abdc5302c9..cfd043f30ed2f 100644 --- a/lib/web_ui/dev/steps/run_suite_step.dart +++ b/lib/web_ui/dev/steps/run_suite_step.dart @@ -179,6 +179,11 @@ class RunSuiteStep implements PipelineStep { // do not collect goldens. return null; } + if (suite.runConfig.browser == BrowserName.safari) { + // Goldens from Safari produce too many diffs, disabled for now. + // See https://github.com/flutter/flutter/issues/143591 + return null; + } final Renderer renderer = suite.testBundle.compileConfigs.first.renderer; final CanvasKitVariant? variant = suite.runConfig.variant; final io.Directory workDirectory = getSkiaGoldDirectoryForSuite(suite);